[Lens] Clean and inline disabling of react-hooks/exhaustive-deps eslint rule #70010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
Team:Visualizations
mbondyra
force-pushed
the
eslint-exhaustive-deps
branch
from
0440122 to
3d974dd
Compare
mbondyra
commented
Jul 30, 2020
| // redirectTo, | ||
| // state.persistedDoc, | ||
| ]); | ||
| useEffect( |
There was a problem hiding this comment.
indentation change because of added comment
mbondyra
commented
Jul 30, 2020
| isUnmounted = true; | ||
| }; | ||
| }, [allLoaded]); | ||
| useEffect( |
There was a problem hiding this comment.
indentation change because of added comment
mbondyra
commented
Jul 30, 2020
| }); | ||
| } | ||
| }, [props.doc]); | ||
| useEffect( |
There was a problem hiding this comment.
indentation change because of added comment
mbondyra
commented
Jul 30, 2020
| state.activeDatasourceId && !state.datasourceStates[state.activeDatasourceId].isLoading | ||
| ? props.datasourceMap[state.activeDatasourceId] | ||
| : undefined; | ||
| useEffect( |
There was a problem hiding this comment.
indentation change because of added comment
mbondyra
commented
Jul 30, 2020
| if (!dragDropContext.dragging || !activeDatasourceId) { | ||
| return; | ||
| } | ||
| const suggestionForDraggedField = useMemo( |
There was a problem hiding this comment.
indentation change because of added comment
mbondyra
commented
Jul 30, 2020
| framePublicAPI.query, | ||
| framePublicAPI.filters, | ||
| ]); | ||
| const expression = useMemo( |
There was a problem hiding this comment.
indentation change because of added comment
mbondyra
commented
Jul 30, 2020
| nextRequest.current = performLoad; | ||
| return; | ||
| } | ||
| useEffect( |
There was a problem hiding this comment.
indentation change because of added comment
mbondyra
changed the title
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mbondyra
added
release_note:skip
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
7 tasks
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
wylieconlon
approved these changes
Aug 5, 2020
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Aug 6, 2020
mbondyra
added a commit
that referenced
this pull request
Aug 6, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 6, 2020
* master: (208 commits) Observability Overview fix extra basepath prepend for alerting fetch (elastic#74465) [Lens] Clean and inline disabling of react-hooks/exhaustive-deps eslint rule (elastic#70010) Skip "space with index pattern management disabled" functional test for cloud env (elastic#74073) Filter out non-security jobs when collecting Detections telemetry (elastic#74456) [Security Solution][Test] Enzyme test for related events button (elastic#74411) [SECURITY_SOLUTION] add z-index to get over nav bar (elastic#74427) Rename package configs SO to package policies (elastic#74422) [DOCS] Add Kibana alerts to Stack Monitoring (elastic#73762) skip flaky suite (elastic#71390) [ML] DF Analytics: adds functional tests for edit form (elastic#73885) Rename agent configs SO to agent policies (elastic#74397) [Jenkins] run CI when plugin readmes change (elastic#74388) [Metrics UI] Fix validating Metrics Explorer URL (elastic#74311) fixing encoding issue with \ for enroll command (elastic#74379) [Ingest Manager] Update package registry for testing to f6b01d (elastic#74341) Change experimental message for visualizations (elastic#74354) [Alerting] Reload the Alerts List when alerts are deleted (elastic#73715) [Enterprise Search] Fix/DRY out plugin i18n strings (elastic#74323) update empty prompt in analytics list (elastic#74174) [Task Manager] Correctly handle `running` tasks when calling RunNow and reduce flakiness in related tests (elastic#73244) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #49564
Allows to enable react-hooks/exhaustive-deps eslint rule.
17/26 warnings were removed by refactoring of the code - the easy ones, where I only needed to add missing dependencies and haven't observed any performance problems.
9/26 is more complicated and I'll tackle it in separate PR(s) to not make this PR too bloated. For now, I've inlined turning off the eslint rule for these specific cases. That would stop us from producing more code that breaks the rule.