Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENDPOINT] Hide the Timeline Flyout while on the Management Pages #69998

Merged
merged 8 commits into from
Jun 26, 2020
Merged

[ENDPOINT] Hide the Timeline Flyout while on the Management Pages #69998

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5315729
hide timeline on Management pages
paul-tavares Jun 25, 2020
0e63342
adjust managment page view styles
paul-tavares Jun 25, 2020
811e45b
Added additional tests for validating no timeline button on managemen…
paul-tavares Jun 25, 2020
d5cd733
Update PageView jest snapshots
paul-tavares Jun 26, 2020
67500e7
centralize API Path responses and reuse across tests
paul-tavares Jun 26, 2020
918f230
Fix state being reset incorrectly
paul-tavares Jun 26, 2020
a544b5f
Fix policy details tests
paul-tavares Jun 26, 2020
87568ec
Merge remote-tracking branch 'upstream/master' into task/EMT-458-hide…
paul-tavares Jun 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions x-pack/plugins/security_solution/public/common/components/endpoint/page_view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,13 @@ import {
import React, { memo, MouseEventHandler, ReactNode, useMemo } from 'react';
import styled from 'styled-components';
import { EuiTabProps } from '@elastic/eui/src/components/tabs/tab';
import { gutterTimeline } from '../../lib/helpers';

const StyledEuiPage = styled(EuiPage)`
&.endpoint--isListView {
padding: 0 ${gutterTimeline} 0 ${(props) => props.theme.eui.euiSizeL};
padding: 0 ${(props) => props.theme.eui.euiSizeL};

.endpoint-header {
padding: ${(props) => props.theme.eui.euiSizeL} 0;
padding: ${(props) => props.theme.eui.euiSizeL};
margin-bottom: 0;
}
.endpoint-page-content {
Expand All @@ -44,7 +43,7 @@ const StyledEuiPage = styled(EuiPage)`
}
}
.endpoint-navTabs {
margin-left: ${(props) => props.theme.eui.euiSizeL};
margin-left: ${(props) => props.theme.eui.euiSizeM};
}
`;

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/public/common/utils/timeline/use_show_timeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import { useState, useEffect } from 'react';
import { useRouteSpy } from '../route/use_route_spy';

const hideTimelineForRoutes = [`/cases/configure`];
const hideTimelineForRoutes = [`/cases/configure`, '/management'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is easy!


export const useShowTimeline = () => {
const [{ pageName, pathName }] = useRouteSpy();
Expand Down
6 changes: 6 additions & 0 deletions x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ describe('when on the hosts page', () => {
render = () => mockedContext.render(<HostList />);
});

it('should NOT display timeline', async () => {
const renderResult = render();
const timelineFlyout = await renderResult.queryByTestId('flyoutOverlay');
expect(timelineFlyout).toBeNull();
});

it('should show a table', async () => {
const renderResult = render();
const table = await renderResult.findByTestId('hostListTable');
Expand Down
8 changes: 8 additions & 0 deletions x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ describe('Policy Details', () => {
policyView = render(<PolicyDetails />);
});

it('should NOT display timeline', async () => {
expect(policyView.find('flyoutOverlay')).toHaveLength(0);
});

it('should show loader followed by error message', () => {
expect(policyView.find('EuiLoadingSpinner').length).toBe(1);
policyView.update();
Expand Down Expand Up @@ -84,6 +88,10 @@ describe('Policy Details', () => {
policyView = render(<PolicyDetails />);
});

it('should NOT display timeline', async () => {
expect(policyView.find('flyoutOverlay')).toHaveLength(0);
});

it('should display back to list button and policy title', () => {
policyView.update();
const pageHeaderLeft = policyView.find(
Expand Down
6 changes: 6 additions & 0 deletions x-pack/plugins/security_solution/public/management/pages/policy/view/policy_list.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ describe('when on the policies page', () => {
render = () => mockedContext.render(<PolicyList />);
});

it('should NOT display timeline', async () => {
const renderResult = render();
const timelineFlyout = await renderResult.queryByTestId('flyoutOverlay');
expect(timelineFlyout).toBeNull();
});

it('should show the empty state', async () => {
const renderResult = render();
const table = await renderResult.findByTestId('emptyPolicyTable');
Expand Down