[ML] Transforms: Adds functional tests for transform cloning and editing. #69933
Conversation
walterra
added
:ml
test_xpack_functional
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
|
LGTM |
| expect(rows.filter((row) => row.id === transformConfig.id)).to.have.length(1); | ||
| }); | ||
|
|
||
| it('should display details for the update job in the job list', async () => { |
There was a problem hiding this comment.
It isn't clear to me what this test is for from the description, which refers to job and job list. Looks like it is checking each of the fields in the row for the updated transform. In which case, something like should display the updated fields for the transform in the transforms list ?
There was a problem hiding this comment.
Updated in a037c8d. It now says should display the updated job in the job list row cells.
| const testSubjects = getService('testSubjects'); | ||
|
|
||
| return { | ||
| async assertTransfromEditFlyoutExists() { |
There was a problem hiding this comment.
Typo! Should be assertTransformEditFlyoutExists
| await testSubjects.existOrFail('transformEditFlyout'); | ||
| }, | ||
|
|
||
| async assertTransfromEditFlyoutMissing() { |
There was a problem hiding this comment.
Typo! Should be assertTransformEditFlyoutMissing
| ); | ||
| expect(actualValue).to.eql( | ||
| expectedValue, | ||
| `Transform ${input} input text should be '${expectedValue}' (got '${actualValue}')` |
There was a problem hiding this comment.
As well as the suggested edit, should start with should
There was a problem hiding this comment.
@peteharverson I'm not sure I get your suggestion right. How do you think this expectmessage should look like?
We usually have messages in the form of Expected xyz (got abc) (example) or xyz should be ... (got abc) (example).
There was a problem hiding this comment.
Sorry, you're right @pheyos , I was thinking this was one of test descriptions. Agree we should stick with the same format for these expect messages.
Co-authored-by: Robert Oskamp <[email protected]>
Co-authored-by: Robert Oskamp <[email protected]>
Co-authored-by: Robert Oskamp <[email protected]>
…ana into ml-e2e-transform-clone-edit
|
Checked test stability in a flaky test runner CI job -> No failure in 50 runs ✔️ |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
…ing. (elastic#69933) Adds functional tests for transform cloning and editing.
Summary
Adds functional tests for transform cloning and editing.
Checklist