-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new elasticsearch client #69905
Merged
pgayvallet
merged 55 commits into
elastic:master
from
pgayvallet:kbn-35508-add-new-es-client
Jul 8, 2020
+2,216
−204
Merged
Add new elasticsearch client #69905
Changes from 1 commit
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
10f0846
add "@elastic/elasticsearch" to dependencies
pgayvallet e923ce5
first POC of new client
pgayvallet 175e0cb
add logging
pgayvallet f56a506
Merge remote-tracking branch 'upstream/master' into kbn-35508-add-new…
pgayvallet 24ac36b
add generation script for client facade API and implementation
pgayvallet 024f3df
add back keepAlive
pgayvallet cfa547a
Merge remote-tracking branch 'upstream/master' into kbn-35508-add-new…
pgayvallet eecd780
add exports from client
pgayvallet 8c6c9fc
add new client mocks
pgayvallet c7a2cf1
add some doc
pgayvallet 193fecc
fix API usages
pgayvallet b8935d7
rename legacy client to legacy in service
pgayvallet f268e63
rename currently unused config/client observable
pgayvallet 73f68b8
wire new client to service & update mocks
pgayvallet 2c5a489
fix mock type
pgayvallet c7ae6aa
export client types
pgayvallet 93d05ee
add transport.request
pgayvallet 4156411
more doc
pgayvallet 5a3fd9c
migrate version_check to new client
pgayvallet 71a27bb
fix default port logic
pgayvallet e48f3ad
rename legacy client mocks
pgayvallet bdacda3
move legacy client mocks to legacy folder
pgayvallet 152b6dc
start adding tests
pgayvallet b265759
add configure_client tests
pgayvallet 9e356e8
add get_client_facade tests
pgayvallet 353253f
Merge remote-tracking branch 'upstream/master' into kbn-35508-add-new…
pgayvallet 7e49f65
bump client to 7.8
pgayvallet bda204e
add cluster_client tests
pgayvallet 28b8cfc
expose new client on internal contract only
pgayvallet 8cd1ed2
revert using the new client for es version check
pgayvallet 205c100
add service level test for new client
pgayvallet 7819166
update generated API
pgayvallet d1cdb0a
Merge remote-tracking branch 'upstream/master' into kbn-35508-add-new…
pgayvallet 80bfc97
Merge remote-tracking branch 'upstream/master' into kbn-35508-add-new…
pgayvallet bf18e61
Revert "rename legacy client mocks"
pgayvallet 6c4ff93
Merge remote-tracking branch 'upstream/master' into kbn-35508-add-new…
pgayvallet 8a397d0
address some review comments
pgayvallet 533212b
Merge remote-tracking branch 'upstream/master' into kbn-35508-add-new…
pgayvallet 0a09aee
revert ts-expect-error from unowned files
pgayvallet 1a68ea1
move response mocks to mocks.ts
pgayvallet f956fb4
Remove generated facade, use ES Client directly
pgayvallet 56db6c4
log queries even in case of error
pgayvallet d6f1c9d
nits
pgayvallet 83b7246
use direct properties instead of accessors
pgayvallet a764b10
handle async closing of client
pgayvallet 9d272ba
Merge remote-tracking branch 'upstream/master' into kbn-35508-add-new…
pgayvallet 3f1d9bd
Merge remote-tracking branch 'upstream/master' into kbn-35508-add-new…
pgayvallet 88ae350
Merge remote-tracking branch 'upstream/master' into kbn-35508-add-new…
pgayvallet cb242e7
Merge remote-tracking branch 'upstream/master' into kbn-35508-add-new…
pgayvallet 413a97d
review nits
pgayvallet c0d7f3a
ElasticSearchClient -> ElasticsearchClient
pgayvallet 022e4a2
add test for encoded querystring
pgayvallet 0dc69b4
Merge remote-tracking branch 'upstream/master' into kbn-35508-add-new…
pgayvallet 5acfe96
adapt test file
pgayvallet f059964
Merge remote-tracking branch 'upstream/master' into kbn-35508-add-new…
pgayvallet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
log queries even in case of error
- Loading branch information
commit 56db6c43c7105078491240171438a1c707c4d732
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we okay not to log
warnings
anymore?kibana/src/core/server/elasticsearch/legacy/elasticsearch_client_config.ts
Line 195 in 0a09aee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took #69905 (comment) as a 'yes', as warning are per-request and can now be handled by the consumers. but we can decide to log them on our own. I don't really have an opinion on that one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m wondering if the client should log warnings more aggressively, maybe via
process.emitWarning
.This is because I think users will never proactively go and read the
warnings
key. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
process.emitWarning
seems way too aggressive imho. Being able to get them using the event emitter API is fine.