Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM][CASE] Improve Jira's labelling #69892

Merged
merged 2 commits into from
Jun 25, 2020
Merged

[SIEM][CASE] Improve Jira's labelling #69892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f12821
Change labeling
cnasikas Jun 25, 2020
441efa6
Improve word
cnasikas Jun 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/plugins/security_solution/public/common/lib/connectors/jira/flyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const JiraConnectorForm: React.FC<ConnectorFlyoutFormProps<JiraActionConnector>>
fullWidth
error={errors.email}
isInvalid={isEmailInvalid}
label={i18n.EMAIL_LABEL}
label={i18n.JIRA_EMAIL_LABEL}
>
<EuiFieldText
fullWidth
Expand All @@ -85,7 +85,7 @@ const JiraConnectorForm: React.FC<ConnectorFlyoutFormProps<JiraActionConnector>>
fullWidth
error={errors.apiToken}
isInvalid={isApiTokenInvalid}
label={i18n.API_TOKEN_LABEL}
label={i18n.JIRA_API_TOKEN_LABEL}
>
<EuiFieldPassword
fullWidth
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/security_solution/public/common/lib/connectors/jira/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ const validateConnector = (action: JiraActionConnector): ValidationResult => {
}

if (!action.secrets.email) {
errors.email = [...errors.email, i18n.EMAIL_REQUIRED];
errors.email = [...errors.email, i18n.JIRA_EMAIL_REQUIRED];
}

if (!action.secrets.apiToken) {
errors.apiToken = [...errors.apiToken, i18n.API_TOKEN_REQUIRED];
errors.apiToken = [...errors.apiToken, i18n.JIRA_API_TOKEN_REQUIRED];
}

return { errors };
Expand Down
28 changes: 28 additions & 0 deletions x-pack/plugins/security_solution/public/common/lib/connectors/jira/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,34 @@ export const JIRA_PROJECT_KEY_REQUIRED = i18n.translate(
}
);

export const JIRA_EMAIL_LABEL = i18n.translate(
'xpack.securitySolution.case.connectors.jira.emailTextFieldLabel',
{
defaultMessage: 'Email or Username',
}
);

export const JIRA_EMAIL_REQUIRED = i18n.translate(
'xpack.securitySolution.case.connectors.jira.requiredEmailTextField',
{
defaultMessage: 'Email or Username is required',
}
);

export const JIRA_API_TOKEN_LABEL = i18n.translate(
'xpack.securitySolution.case.connectors.jira.apiTokenTextFieldLabel',
{
defaultMessage: 'API token or Password',
}
);

export const JIRA_API_TOKEN_REQUIRED = i18n.translate(
'xpack.securitySolution.case.connectors.jira.requiredApiTokenTextField',
{
defaultMessage: 'API token or Password is required',
}
);

export const MAPPING_FIELD_SUMMARY = i18n.translate(
'xpack.securitySolution.case.configureCases.mappingFieldSummary',
{
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/security_solution/public/common/lib/connectors/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,14 @@ export const PASSWORD_REQUIRED = i18n.translate(
export const API_TOKEN_LABEL = i18n.translate(
'xpack.securitySolution.case.connectors.common.apiTokenTextFieldLabel',
{
defaultMessage: 'Api token',
defaultMessage: 'API token',
}
);

export const API_TOKEN_REQUIRED = i18n.translate(
'xpack.securitySolution.case.connectors.common.requiredApiTokenTextField',
{
defaultMessage: 'Api token is required',
defaultMessage: 'API token is required',
}
);

Expand Down