Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Changes the ML overview empty analytics panel text #69801

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Jun 24, 2020

Summary

This PR changes the ML overview empty analytics panel text to refer to the different DFA types (outlier detection, regression, classification).

ML overview

Checklist

@szabosteve szabosteve added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v7.9.0 labels Jun 24, 2020
@szabosteve szabosteve requested a review from a team as a code owner June 24, 2020 13:45
@szabosteve szabosteve requested a review from lcawl June 24, 2020 13:47
@szabosteve szabosteve added the :ml label Jun 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@szabosteve szabosteve requested a review from peteharverson June 24, 2020 13:57
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be and annotates it with the results or and annotate it with the results !? Otherwise LGTM!

@szabosteve
Copy link
Contributor Author

@lcawl
We are a bit on the fence regarding perform outlier detection, regression, or classification analysis. Should it be and or or? You could do all 3 on your data, in 3 different jobs, so and makes sense. However, the title says Create your first data frame analytics job. In this context, or also makes sense as a single job can only execute one type of analysis.

@lcawl
Copy link
Contributor

lcawl commented Jun 24, 2020

Should it be and or or?
My vote would be for "or" given the wording of the title.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@szabosteve szabosteve merged commit cf96249 into elastic:master Jun 25, 2020
@szabosteve szabosteve deleted the re.ml.ui branch June 25, 2020 09:54
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 25, 2020
* master: (45 commits)
  [QA] Unskip functional tests (elastic#69760)
  [SIEM][Detection Engine] - Update DE to work with new exceptions schema (elastic#69715)
  Fixes elastic#69639: Ignore url.url fields above 2048 characters (elastic#69863)
  PR: Provide limit warnings to user when API limits are reached. (elastic#69590)
  [Maps] Remove broken button (elastic#69853)
  Makes usage collection methods available on start (elastic#69836)
  [SIEM][CASE] Improve Jira's labelling (elastic#69892)
  [Logs UI] Access ML via the programmatic plugin API (elastic#68905)
  [ML] DF Analytics: Creation wizard part 3 (elastic#69456)
  Update Resolver generator script documentation (elastic#69912)
  [ML] Changes View results button text on new job page (elastic#69809)
  Add master branch to backport config (elastic#69893)
  [Ingest Manager] Kibana, not EPR, controls removable packages (elastic#69761)
  unskips 'Events columns' test (elastic#69684)
  [ML] Changes the ML overview empty analytics panel text (elastic#69801)
  [DOCS] Emphasizes where File Data Visualizer is located. (elastic#69812)
  add the `exactRoute` property to app registration (elastic#69772)
  Bump backport to 5.4.6 (elastic#69880)
  [Logs UI] ML log integration splash screen (elastic#69288)
  Clean up TSVB type client code to conform to the schema (elastic#68519)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants