Update KQL/filter bar suggestions to cancel when navigating away #69769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
|
@elasticmachine merge upstream |
alexwizp
approved these changes
Jun 25, 2020
alexwizp
added
release_note:skip
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Jul 1, 2020
…stic#69769) Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
removed
the
backport missing
lukasolson
added a commit
that referenced
this pull request
Jul 7, 2020
) (#70506) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #48797.
Updates the KQL & filter bar to properly cancel value suggestions requests when the input changes or the user navigates away.
Prior to this PR, we were properly cancelling KQL value suggestion requests when the query changed, but not when users navigate away or in filter bar suggestions. This PR adds the remainder of the cancellation functionality.
Release notes
When using KQL or the filter bar, if a request is issued to Elasticsearch for suggestions for a value for a specific field, the request will be cancelled when navigating away as well as when the input is updated (and a new request is issued).