Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds glossary to documentation #69721

Merged
merged 32 commits into from
Jun 30, 2020
Merged

Conversation

gchaps
Copy link
Contributor

@gchaps gchaps commented Jun 23, 2020

Summary

This PR creates a glossary of terms for Kibana.

Preview
https://kibana_69721.docs-preview.app.elstc.co/guide/en/kibana/master/glossary.html

@gchaps gchaps added Team:Docs v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jun 23, 2020
docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Show resolved Hide resolved
docs/glossary.asciidoc Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
@gchaps gchaps requested a review from debadair June 25, 2020 22:49
@gchaps gchaps marked this pull request as ready for review June 25, 2020 22:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will likely take some finessing once we start pulling the defs into the stack glossary, but this is awesome!

A number of these definitions seem to reflect our internal perspective more than a user's perspective. Many of my comments/suggestions are an attempt to turn that around, but I'm also lacking a lot of context, so take them with plenty of salt.

"Refer to" seems oddly formal. I'm used to seeing "See xyz" and "See also xyz" in glossaries. That's the pattern used in the Stack Glossary & I think we should be consistent.

docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comments, otherwise LGTM

[[glossary-app]] app ::
// tag::app-def[]
A top-level {kib} component that is accessed through the side navigation.
Apps include core {kib} components such as Discover and Dashboard,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I saw in the style guide that we bold apps?

Suggested change
Apps include core {kib} components such as Discover and Dashboard,
Apps include core {kib} components such as *Discover* and *Dashboard*,

docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
<<glossary-advanced-settings,Advanced Settings>>.
// end::lucene-def[]

[[glossary-license-management]] License Management ::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License Management

Does this component really need explanation? It seems quite straightforward.

docs/glossary.asciidoc Outdated Show resolved Hide resolved
For example, you might have different spaces for each team, use case, or individual.
// end::space-def[]

[[glossary-feature-space]] Spaces ::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces

In general I don't think we've defined all the "features" in the glossary. Given that you've defined "space", I question whether this entry is useful. If necessary, you can add the xpack-spaces.html link in the "space" definition.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature definitions are kind of awkward--it would be nice if it's possible to make this approach work.

docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
docs/glossary.asciidoc Outdated Show resolved Hide resolved
A custom navigation path between apps. Refer to {kibana-ref}/drilldowns.html[Drilldowns].
A navigation path that retains context (time range and filters)
from the source to the destination, so you can view the data from a new perspective.
For example, a dashboard that shows the overall status of multiple data center
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example here really helps.



[[glossary-TSVB-data]] TSVB ::
// tag::TSVB-def[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// tag::TSVB-def[]
// tag::tsvb-def[]

A time series data visualizer that allows you to combine an
infinite number of aggregations to display complex data.
See {kibana-ref}/TSVB.html[TSVB].
// end::TSVB-def[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// end::TSVB-def[]
// end::tsvb-def[]

@gchaps gchaps merged commit 8978ec8 into elastic:master Jun 30, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 1, 2020
* master:
  [ML] Modifies page title to Create job (elastic#70191)
  [APM] Add API test for service maps (elastic#70185)
  [DOCS] Adds glossary to documentation (elastic#69721)
  [Usage Collection] Report nodes feature usage (elastic#70108)
  chore: improve support for mjs file extension (elastic#70186)
  [ML] Anomaly Detection: ensure  'Category examples' tab in the expanded table row can be seen (elastic#70241)
  [Maps] Add maps telemetry saved object in with mappings disabled (elastic#69995)
  Fix typo in bootstrap command (elastic#69976)
  [code coverage] ingest correct coveredFilePath for mocha (elastic#70215)
  [Dashboard] Add visualization by value to dashboard (elastic#69898)
  updates wording in Cases connectors (elastic#70298)
  [ML] Fix license subscription race condition. (elastic#70074)
  [Logs UI] [Alerting] "Group by" functionality (elastic#68250)
Bamieh pushed a commit to Bamieh/kibana that referenced this pull request Jul 1, 2020
* [DOCS] Adds glossary to documentation

* [DOCS] Fixes build errors

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* [DOCS] Adds more terms to glossary

* [DOCS] Adds more terms to glossary

* Update docs/glossary.asciidoc

Co-authored-by: debadair <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: debadair <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: debadair <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: debadair <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: debadair <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: debadair <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: debadair <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: debadair <[email protected]>

* [DOCS] Incorporates review comments

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* Update docs/glossary.asciidoc

Co-authored-by: Lisa Cawley <[email protected]>

* [DOCS] Incorporates review comments

* [DOCS] Incorporates review comments

Co-authored-by: Lisa Cawley <[email protected]>
Co-authored-by: debadair <[email protected]>
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 69721 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 2, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 69721 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 69721 or prevent reminders by adding the backport:skip label.

@gchaps gchaps removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 6, 2020
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 7, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 69721 or prevent reminders by adding the backport:skip label.

@lcawl lcawl added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants