-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Optimize services overview #69648
Merged
dgieselaar
merged 12 commits into
elastic:master
from
dgieselaar:optimize-services-overview
Jul 3, 2020
Merged
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
43f55a5
[APM] Optimize service overview queries
dgieselaar da21e45
Merge branch 'master' of github.com:elastic/kibana into optimize-serv…
dgieselaar f774b47
Review feedback
dgieselaar 068c170
Use correct indices/filters for service overview metrics
dgieselaar 0546489
Merge branch 'master' of github.com:elastic/kibana into optimize-serv…
dgieselaar 03e40a7
Merge branch 'master' of github.com:elastic/kibana into optimize-serv…
dgieselaar 5e14e42
use join utility function to merge requests
dgieselaar b180c1b
Merge branch 'master' of github.com:elastic/kibana into optimize-serv…
dgieselaar 83326f2
Query transaction indices in getEnvironments()
dgieselaar 1c1d526
Merge branch 'master' of github.com:elastic/kibana into optimize-serv…
dgieselaar a645758
Set size of terms agg on error rate aggregation
dgieselaar daa5abb
Merge branch 'master' into optimize-services-overview
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
x-pack/plugins/apm/common/utils/array_union_to_callable.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
import { ValuesType } from 'utility-types'; | ||
|
||
// work around a TypeScript limitation described in https://stackoverflow.com/posts/49511416 | ||
|
||
export const arrayUnionToCallable = <T extends any[]>( | ||
array: T | ||
): Array<ValuesType<T>> => { | ||
return array; | ||
}; |
267 changes: 217 additions & 50 deletions
267
x-pack/plugins/apm/server/lib/services/__snapshots__/queries.test.ts.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this be changed by your PR for new client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep! there will no longer be a need for
noEvents
.