Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] setup babel for the functional tests #6955

Merged
merged 3 commits into from
Apr 28, 2016

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Apr 17, 2016

It was originally unclear how to setup babel to work with intern, but while trying to speedup the tests I worked out how to make it happen.

Now all of the test files, except for the single index file, are built with babel before being executed by intern. Additionally, no AMD wrappers or requirejs intern/dojo/node!../ prefix is needed to load node modules.

The only down-side to this change is that requiring parts of intern has to be done in a hacky way. Thankfully there are only two items that are ever required from intern, so it was simple to move those into a shared module and do the hacky stuff in two places, one on the intern side of things and another on the node side of things.

There are many benefits to this change though, but I'm most excited about the ability to use async/await. Expect a pr soon transitioning some of the tests.

@spalger spalger force-pushed the implement/babelForFunctionalTests branch 2 times, most recently from a3d3e9d to 0525544 Compare April 18, 2016 01:09
@spalger spalger force-pushed the implement/babelForFunctionalTests branch from 0525544 to 263b553 Compare April 22, 2016 18:04
@LeeDr
Copy link

LeeDr commented Apr 22, 2016

Can I still run an individual test suite for one app? I used to be able to do this;

node_modules/intern/bin/intern-runner.js config=test/intern functionalSuites=test/functional/apps/discover/index

@spalger
Copy link
Contributor Author

spalger commented Apr 22, 2016

No, now that there is a single entry point you will need to use intern's grep option. Even though it requires a change, this has the benefit of having arbitrary granularity

@LeeDr
Copy link

LeeDr commented Apr 27, 2016

LGTM

@LeeDr LeeDr assigned spalger and unassigned LeeDr Apr 27, 2016
@spalger spalger force-pushed the implement/babelForFunctionalTests branch 2 times, most recently from 33bf3f5 to e1762d7 Compare April 28, 2016 04:13
@spalger spalger force-pushed the implement/babelForFunctionalTests branch from e1762d7 to fe260e0 Compare April 28, 2016 04:27
@spalger spalger merged commit f161dc9 into master Apr 28, 2016
@epixa epixa deleted the implement/babelForFunctionalTests branch May 3, 2016 14:29
Ikuni17 pushed a commit that referenced this pull request Jul 27, 2023
## Summary

`[email protected]` ⏩ `[email protected]`

## [`85.0.1`](https://github.com/elastic/eui/tree/v85.0.1)

**Bug fixes**

- Fixed `EuiFilterGroup`'s responsive styles
([#6983](elastic/eui#6983))

## [`85.0.0`](https://github.com/elastic/eui/tree/v85.0.0)

- Updated `EuiThemeProvider` to set an Emotion theme context that
returns the values of `useEuiTheme()`
([#6913](elastic/eui#6913))
- Added `size` prop to `EuiStepsHorizontal`, defaulting to the previous
size of `m` ([#6928](elastic/eui#6928))
- Added new `s` sizing to `EuiStepsHorizontal`
([#6928](elastic/eui#6928))
- Added `at` and `key` icon glyphs.
([#6934](elastic/eui#6934))
- Added a new `cloneElementWithCss` Emotion utility
([#6939](elastic/eui#6939))
- Updated `EuiPopover` to allow consumer control of all `focusTrapProps`
([#6955](elastic/eui#6955))

**Bug fixes**

- Fixed `EuiDataGrid` height calculation bug when browser zoom levels
are not 100% ([#6895](elastic/eui#6895))
- Fixed `EuiTab` not correctly passing selection color state to
`prepend` and `append` children
([#6938](elastic/eui#6938))
- Fixed `EuiInputPopover` to allow consumer control of its focus trap
via `focusTrapProps` ([#6955](elastic/eui#6955))

**Breaking changes**

- `EuiProvider` will no longer render multiple or duplicate nested
instances of itself. If a nested `EuiProvider` is detected, that
instance will return early without further processing, and will warn if
configured to do so via `setEuiDevProviderWarning`. For nested theming,
use `EuiThemeProvider` instead.
([#6949](elastic/eui#6949))
- Removed `onTrapDeactivation` prop from `EuiPopover`. Use
`focusTrapProps.onDeactivation` instead
([#6955](elastic/eui#6955))

**CSS-in-JS conversions**

- Converted `EuiFilterGroup` and `EuiFilterButton` to Emotion; Removed
styles attached to `.euiFilterGroup__popoverPanel`
([#6957](elastic/eui#6957))

---------

Co-authored-by: Cee Chen <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
## Summary

`[email protected]` ⏩ `[email protected]`

## [`85.0.1`](https://github.com/elastic/eui/tree/v85.0.1)

**Bug fixes**

- Fixed `EuiFilterGroup`'s responsive styles
([elastic#6983](elastic/eui#6983))

## [`85.0.0`](https://github.com/elastic/eui/tree/v85.0.0)

- Updated `EuiThemeProvider` to set an Emotion theme context that
returns the values of `useEuiTheme()`
([elastic#6913](elastic/eui#6913))
- Added `size` prop to `EuiStepsHorizontal`, defaulting to the previous
size of `m` ([elastic#6928](elastic/eui#6928))
- Added new `s` sizing to `EuiStepsHorizontal`
([elastic#6928](elastic/eui#6928))
- Added `at` and `key` icon glyphs.
([elastic#6934](elastic/eui#6934))
- Added a new `cloneElementWithCss` Emotion utility
([elastic#6939](elastic/eui#6939))
- Updated `EuiPopover` to allow consumer control of all `focusTrapProps`
([elastic#6955](elastic/eui#6955))

**Bug fixes**

- Fixed `EuiDataGrid` height calculation bug when browser zoom levels
are not 100% ([elastic#6895](elastic/eui#6895))
- Fixed `EuiTab` not correctly passing selection color state to
`prepend` and `append` children
([elastic#6938](elastic/eui#6938))
- Fixed `EuiInputPopover` to allow consumer control of its focus trap
via `focusTrapProps` ([elastic#6955](elastic/eui#6955))

**Breaking changes**

- `EuiProvider` will no longer render multiple or duplicate nested
instances of itself. If a nested `EuiProvider` is detected, that
instance will return early without further processing, and will warn if
configured to do so via `setEuiDevProviderWarning`. For nested theming,
use `EuiThemeProvider` instead.
([elastic#6949](elastic/eui#6949))
- Removed `onTrapDeactivation` prop from `EuiPopover`. Use
`focusTrapProps.onDeactivation` instead
([elastic#6955](elastic/eui#6955))

**CSS-in-JS conversions**

- Converted `EuiFilterGroup` and `EuiFilterButton` to Emotion; Removed
styles attached to `.euiFilterGroup__popoverPanel`
([elastic#6957](elastic/eui#6957))

---------

Co-authored-by: Cee Chen <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants