Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageObjects.common.isChromeVisible should work for KP apps #69488

Merged
merged 3 commits into from
Jun 24, 2020
Merged

PageObjects.common.isChromeVisible should work for KP apps #69488

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d4fceb
remove top-nav. it is not rendered in KP
mshustov Jun 18, 2020
9a8b142
Merge branch 'master' into fix-page-object-is-chrome-visible
elasticmachine Jun 23, 2020
7ab082e
Merge branch 'master' into fix-page-object-is-chrome-visible
elasticmachine Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions test/functional/page_objects/common_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,14 +378,12 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo

async isChromeVisible() {
const globalNavShown = await globalNav.exists();
const topNavShown = await testSubjects.exists('top-nav');
return globalNavShown && topNavShown;
return globalNavShown;
}

async isChromeHidden() {
const globalNavShown = await globalNav.exists();
const topNavShown = await testSubjects.exists('top-nav');
return !globalNavShown && !topNavShown;
return !globalNavShown;
}

async waitForTopNavToBeVisible() {
Expand Down