Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.8] [kbn/optimizer] share all plugin bundles (#68986) #69239

Merged
merged 6 commits into from
Jun 17, 2020
Merged

[7.8] [kbn/optimizer] share all plugin bundles (#68986) #69239

merged 6 commits into from
Jun 17, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jun 16, 2020 •
edited
Loading

Backports the following commits to 7.8:

Spencer and others added 6 commits June 16, 2020 15:35
@spalger
[kbn/optimizer] use execa to fork workers (elastic#67730)
0beaa50 
Co-authored-by: spalger <[email protected]>
(cherry picked from commit 6288096)
@spalger
[kbn/optimizer] share all plugin bundles (elastic#68986)
8e991f0 
Co-authored-by: spalger <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 7e32841)
@spalger
[kbn/optimizer] fix windows compatibility (elastic#69304)
5eb4573 
Co-authored-by: spalger <[email protected]>
(cherry picked from commit db1df7b)
@spalger
[BundleRefPlugin] resolve imports to files too (elastic#69241)
8cf7dfa 
Co-authored-by: spalger <[email protected]>
(cherry picked from commit e03f242)
@spalger
Merge branch '7.8' of github.com:elastic/kibana into backport/7.8/pr-…
ff27325 
…68986
@spalger
add 7.8-specific extraPublicDirs to kibana.json files
53d3d66
@spalger spalger force-pushed the backport/7.8/pr-68986 branch from 9a18e16 to 53d3d66 Compare June 16, 2020 23:03
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
advancedSettings 40 +1 39
apm_oss 6 +1 5
bfetch 20 +1 19
charts 261 +1 260
console 154 -45 199
core 417 +1 416
dashboard 164 -217 381
data 452 -104 556
devTools 13 +1 12
discover 40 -73 113
embeddable 61 -94 155
esUiShared 129 +66 63
expressions 103 -168 271
indexPatternManagement 12 +1 11
inputControlVis 38 +1 37
inspector 51 +2 49
kibanaLegacy 41 +1 40
kibanaReact 257 +1 256
kibanaUtils 193 -13 206
management 21 -55 76
mapsLegacy 104 -256 360
navigation 20 +1 19
newsfeed 17 +1 16
savedObjects 41 +1 40
savedObjectsManagement 59 -55 114
share 33 +1 32
statusPage 4 +1 3
telemetry 23 +1 22
telemetryManagementSection 8 -37 45
uiActions 26 +1 25
usageCollection 17 +1 16
visTypeMarkdown 246 -27 273
visTypeMetric 248 -46 294
visTypeTable 266 -65 331
visTypeTagcloud 251 -26 277
visTypeTimelion 270 +1 269
visTypeTimeseries 526 -283 809
visTypeVega 286 -125 411
visTypeVislib 439 -35 474
visTypeXy 4 +1 3
visualizations 78 -221 299
visualize 278 -453 731
advancedUiActions 35 -170 205
alerting 25 +2 23
apm 928 -2346 3274
canvas 1093 -1658 2751
cloud 6 +1 5
crossClusterReplication 172 -397 569
dashboardEnhanced 26 -435 461
dataEnhanced 20 -135 155
drilldowns 26 -203 229
embeddableEnhanced 10 -203 213
endpoint 384 -197 581
features 9 +1 8
fileUpload 26 +1 25
graph 159 -123 282
grokdebugger 37 -55 92
indexLifecycleManagement 178 -367 545
indexManagement 382 -67 449
infra 1025 -2249 3274
ingestManager 509 -20 529
ingestPipelines 55 -73 128
lens 180 -596 776
licenseManagement 148 -62 210
licensing 10 +1 9
logstash 194 -55 249
maps 713 -488 1201
mapsLegacyLicensing 4 +1 3
ml 1089 -496 1585
monitoring 375 -109 484
observability 29 +1 28
painlessLab 38 -54 92
remoteClusters 154 +1 153
reporting 45 -202 247
rollup 250 -77 327
searchprofiler 73 -54 127
security 405 -221 626
siem 1467 -1356 2823
snapshotRestore 146 +1 145
spaces 117 -111 228
transform 163 -345 508
triggers_actions_ui 149 -14 163
upgradeAssistant 56 +1 55
uptime 489 -1303 1792
watcher 166 -58 224
total - -16598 -

page load asset size

beta
id value diff baseline
/bundles/core/core.entry.js 1014.7KB +706.0B 1014.1KB
/bundles/plugin/advancedSettings/advancedSettings.plugin.js 943.2KB +677.0B 942.5KB
/bundles/plugin/advancedUiActions/advancedUiActions.plugin.js 80.1KB -546.6KB 626.7KB
/bundles/plugin/alerting/alerting.plugin.js 90.7KB +2.2KB 88.5KB
/bundles/plugin/apm/apm.plugin.js 292.7KB -584.5KB 877.2KB
/bundles/plugin/apm_oss/apm_oss.plugin.js 4.4KB +489.0B 3.9KB
/bundles/plugin/bfetch/bfetch.plugin.js 29.8KB +647.0B 29.1KB
/bundles/plugin/canvas/canvas.plugin.js 2.0MB -1.3MB 3.3MB
/bundles/plugin/charts/charts.plugin.js 894.7KB +968.0B 893.7KB
/bundles/plugin/cloud/cloud.plugin.js 5.9KB +483.0B 5.4KB
/bundles/plugin/console/console.plugin.js 28.1KB -18.6KB 46.7KB
/bundles/plugin/crossClusterReplication/crossClusterReplication.plugin.js 154.7KB +1.1KB 153.6KB
/bundles/plugin/dashboard/dashboard.plugin.js 618.3KB -499.5KB 1.1MB
/bundles/plugin/dashboardEnhanced/dashboardEnhanced.plugin.js 149.6KB -1.1MB 1.3MB
/bundles/plugin/data/data.plugin.js 1.4MB -243.8KB 1.6MB
/bundles/plugin/dataEnhanced/dataEnhanced.plugin.js 141.4KB -345.9KB 487.2KB
/bundles/plugin/devTools/devTools.plugin.js 120.4KB +493.0B 120.0KB
/bundles/plugin/discover/discover.plugin.js 164.1KB -154.5KB 318.6KB
/bundles/plugin/drilldowns/drilldowns.plugin.js 48.2KB -623.5KB 671.7KB
/bundles/plugin/embeddable/embeddable.plugin.js 272.0KB -253.0KB 525.0KB
/bundles/plugin/embeddableEnhanced/embeddableEnhanced.plugin.js 26.6KB -623.9KB 650.4KB
/bundles/plugin/esUiShared/esUiShared.plugin.js 914.7KB +128.1KB 786.6KB
/bundles/plugin/expressions/expressions.plugin.js 317.6KB -394.7KB 712.3KB
/bundles/plugin/features/features.plugin.js 13.8KB +562.0B 13.3KB
/bundles/plugin/fileUpload/fileUpload.plugin.js 688.3KB +499.0B 687.8KB
/bundles/plugin/graph/graph.plugin.js 15.4KB -191.8KB 207.2KB
/bundles/plugin/grokdebugger/grokdebugger.plugin.js 11.9KB -18.9KB 30.8KB
/bundles/plugin/home/home.plugin.js 25.2KB +887.0B 24.3KB
/bundles/plugin/indexLifecycleManagement/indexLifecycleManagement.plugin.js 183.0KB +635.0B 182.3KB
/bundles/plugin/indexManagement/indexManagement.plugin.js 718.5KB -132.6KB 851.2KB
/bundles/plugin/indexPatternManagement/indexPatternManagement.plugin.js 21.2KB +535.0B 20.7KB
/bundles/plugin/infra/infra.plugin.js 977.2KB -109.1KB 1.1MB
/bundles/plugin/ingestPipelines/ingestPipelines.plugin.js 30.2KB -237.7KB 267.9KB
/bundles/plugin/inputControlVis/inputControlVis.plugin.js 257.7KB +994.0B 256.7KB
/bundles/plugin/inspector/inspector.plugin.js 239.7KB +1.1KB 238.6KB
/bundles/plugin/kibanaLegacy/kibanaLegacy.plugin.js 177.2KB +913.0B 176.3KB
/bundles/plugin/kibanaReact/kibanaReact.plugin.js 567.9KB +663.0B 567.2KB
/bundles/plugin/kibanaUtils/kibanaUtils.plugin.js 434.3KB -44.3KB 478.6KB
/bundles/plugin/lens/lens.plugin.js 753.9KB -1.1MB 1.8MB
/bundles/plugin/licenseManagement/licenseManagement.plugin.js 26.2KB +1.1KB 25.1KB
/bundles/plugin/licensing/licensing.plugin.js 20.7KB +656.0B 20.1KB
/bundles/plugin/logstash/logstash.plugin.js 145.6KB -19.1KB 164.7KB
/bundles/plugin/management/management.plugin.js 152.3KB -21.5KB 173.7KB
/bundles/plugin/maps/maps.plugin.js 210.7KB -17.6KB 228.3KB
/bundles/plugin/mapsLegacy/mapsLegacy.plugin.js 741.8KB -788.3KB 1.5MB
/bundles/plugin/mapsLegacyLicensing/mapsLegacyLicensing.plugin.js 4.1KB +525.0B 3.6KB
/bundles/plugin/ml/ml.plugin.js 1.1MB -345.3KB 1.4MB
/bundles/plugin/monitoring/monitoring.plugin.js 22.6KB -17.5KB 40.1KB
/bundles/plugin/navigation/navigation.plugin.js 123.9KB +499.0B 123.4KB
/bundles/plugin/newsfeed/newsfeed.plugin.js 31.1KB +493.0B 30.7KB
/bundles/plugin/observability/observability.plugin.js 96.5KB +773.0B 95.7KB
/bundles/plugin/painlessLab/painlessLab.plugin.js 159.6KB -18.9KB 178.5KB
/bundles/plugin/remoteClusters/remoteClusters.plugin.js 38.6KB +511.0B 38.1KB
/bundles/plugin/reporting/reporting.plugin.js 266.1KB -441.0KB 707.2KB
/bundles/plugin/rollup/rollup.plugin.js 196.4KB -70.5KB 266.9KB
/bundles/plugin/savedObjects/savedObjects.plugin.js 195.5KB +825.0B 194.7KB
/bundles/plugin/savedObjectsManagement/savedObjectsManagement.plugin.js 181.0KB +137.4KB 43.7KB
/bundles/plugin/searchprofiler/searchprofiler.plugin.js 42.5KB -19.0KB 61.5KB
/bundles/plugin/security/security.plugin.js 250.2KB -18.0KB 268.2KB
/bundles/plugin/share/share.plugin.js 75.0KB +644.0B 74.3KB
/bundles/plugin/siem/siem.plugin.js 261.0KB -16.5KB 277.5KB
/bundles/plugin/snapshotRestore/snapshotRestore.plugin.js 60.4KB +674.0B 59.7KB
/bundles/plugin/spaces/spaces.plugin.js 363.3KB -91.7KB 455.0KB
/bundles/plugin/statusPage/statusPage.plugin.js 3.8KB +498.0B 3.3KB
/bundles/plugin/telemetry/telemetry.plugin.js 78.0KB +897.0B 77.1KB
/bundles/plugin/telemetryManagementSection/telemetryManagementSection.plugin.js 26.6KB +17.9KB 8.8KB
/bundles/plugin/transform/transform.plugin.js 22.7KB -16.5KB 39.2KB
/bundles/plugin/triggers_actions_ui/triggers_actions_ui.plugin.js 661.0KB -11.5KB 672.5KB
/bundles/plugin/uiActions/uiActions.plugin.js 159.3KB +656.0B 158.6KB
/bundles/plugin/upgradeAssistant/upgradeAssistant.plugin.js 46.4KB +517.0B 45.9KB
/bundles/plugin/uptime/uptime.plugin.js 1.3MB -1.1MB 2.4MB
/bundles/plugin/usageCollection/usageCollection.plugin.js 28.7KB +674.0B 28.0KB
/bundles/plugin/visTypeMarkdown/visTypeMarkdown.plugin.js 564.3KB +1.0KB 563.3KB
/bundles/plugin/visTypeMetric/visTypeMetric.plugin.js 587.5KB -374.2KB 961.6KB
/bundles/plugin/visTypeTable/visTypeTable.plugin.js 621.3KB -421.7KB 1.0MB
/bundles/plugin/visTypeTagcloud/visTypeTagcloud.plugin.js 848.8KB -113.6KB 962.4KB
/bundles/plugin/visTypeTimelion/visTypeTimelion.plugin.js 727.8KB +995.0B 726.8KB
/bundles/plugin/visTypeTimeseries/visTypeTimeseries.plugin.js 218.6KB +1.0KB 217.5KB
/bundles/plugin/visTypeVega/visTypeVega.plugin.js 656.2KB -983.7KB 1.6MB
/bundles/plugin/visTypeVislib/visTypeVislib.plugin.js 1.3MB -158.3KB 1.5MB
/bundles/plugin/visualizations/visualizations.plugin.js 344.8KB -527.1KB 871.9KB
/bundles/plugin/visualize/visualize.plugin.js 17.7KB -17.4KB 35.0KB
/bundles/plugin/watcher/watcher.plugin.js 34.4KB -18.4KB 52.8KB
total - -13.6MB -

History

  • 💔 Build #54494 failed 9a18e16bf599798011984a4951967d4db0c3c0cf
  • 💔 Build #54273 failed 2bb6ac1a796c6b8661d9ca6c33bef9e23d7a0764

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger marked this pull request as ready for review June 17, 2020 01:36
@spalger spalger merged commit 4cdbdfe into elastic:7.8 Jun 17, 2020
@spalger spalger deleted the backport/7.8/pr-68986 branch June 17, 2020 01:37
spalger added a commit that referenced this pull request Jun 17, 2020
@spalger
Revert "[7.8] [kbn/optimizer] share all plugin bundles (#68986) (#69239…
767439e 
…)"

This reverts commit 4cdbdfe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spalger @kibanamachine