Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manger] Return promise from plugin#start #69089

Closed
wants to merge 100 commits into from

Commits on Jun 12, 2020

  1. WIP. Pushing for CI

    John Schulz committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    e30cfb2 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2020

  1. Don't throw. Use Promise.reject

    John Schulz committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    911ded9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8e8f42f View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. Configuration menu
    Copy the full SHA
    4ce3702 View commit details
    Browse the repository at this point in the history
  2. [Observability] Create context container to enable Observability plug…

    …in registry function (elastic#68642)
    
    * creating observability context registry
    
    * adding registryContext
    
    * addressing PR comments
    
    * addressing PR comments
    
    * adding context to registry provider
    
    * adding obs own registry
    
    * refactoring
    
    * refactoring
    
    * fixing types
    
    * removing apm code
    
    Co-authored-by: Elastic Machine <[email protected]>
    cauemarcondes and elasticmachine authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    437f9f6 View commit details
    Browse the repository at this point in the history
  3. [Search][BUG] Call wrong search strategy recursively in async search (e…

    …lastic#69116)
    
    * Call sync search recursively
    
    * Fix test
    
    * Fix search mock to avoid resetting it
    
    * delete empty line
    
    * fix tests
    lizozom authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    efe6ba4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0c34bd7 View commit details
    Browse the repository at this point in the history
  5. Reject with an Error; not a string

    John Schulz committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    afe7767 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    533046f View commit details
    Browse the repository at this point in the history
  7. [Console] Scrub the lead and trailing brackets from ipv6 host names (e…

    …lastic#68991)
    
    * scrub the lead and trailing brackets from ipv6 host names
    
    * Update comment
    
    * refactor: scrub -> sanitize
    
    Co-authored-by: Elastic Machine <[email protected]>
    jloleysens and elasticmachine authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    99a868a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4e86426 View commit details
    Browse the repository at this point in the history
  9. [SECURITY] rename server plugin to siem (elastic#69044)

    * rename server plugin to siem to avoid privilege issue
    
    * review from alerting
    
    * missing change with rename
    
    * fix tests
    
    * missing api integration test
    
    * fix api integration spaces
    XavierM authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    46ed40e View commit details
    Browse the repository at this point in the history
  10. Type safe browser.executeAsync (elastic#69018)

    * make browserAsync type safe
    
    * adopt tests
    
    * prefer unknown over any
    
    * simplify signature
    mshustov authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    2a9fc23 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    80ab0d9 View commit details
    Browse the repository at this point in the history
  12. Embed dashboard by value example & some embeddable clean up (elastic#…

    …67783)
    
    Added example for using dashboard container by value
    1.1 Refactored embeddable explorer e2e test to use new example, removed not needed kbn_tp_embeddable_explorer plugin.
    For embeddable explorer examples went away from using getFactoryById() to improve type checks
    There is new component a replacement for EmbeddableFactoryRenderer with slightly more flexible api: EmbeddableRenderer.
    3.1 We can improve it going forward to support more use case
    Dosant authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    3d0552e View commit details
    Browse the repository at this point in the history
  13. [Endpoint] Adding alerts route (elastic#68183)

    * Adding alerts route
    
    * Adding related alerts generator changes, tests, and script updates
    
    * Fixing missed parameter
    
    * Aligning the AlertEvent and ResolverEvent definition
    
    * Fixing type errors
    
    * Fixing import error
    
    Co-authored-by: Elastic Machine <[email protected]>
    jonathan-buttner and elasticmachine authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    fcfc0b1 View commit details
    Browse the repository at this point in the history
  14. [Monitoring] Ensure we use existing Elasticsearch config (elastic#68389)

    * Ensure we use existing Elasticsearch config
    
    * Use separate type for this to ensure custom properties work
    
    * PR suggestions
    
    * PR feedback
    
    * PR feedback
    
    * Fix type issues
    
    * PR feedback
    chrisronline authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    e6cf4b3 View commit details
    Browse the repository at this point in the history
  15. [APM] Changes to duration formatting (elastic#69039)

    * [APM] Changes to duration formatting
    
    * Change the threshold for showing microseconds to 1 millisecond instead of 10. This means you now get "900 µs/1.3 ms/20.0 ms" instead of "900 µs/1300 µs/20 ms."
    * Change milliseconds formatted with `asDuration` to be `asDecimal` instead of `asInteger`. That means you get "0.0 ms/2.5 ms/3.0 ms" instead of "0 ms/2 ms/3 ms."
    * Tables were all using their own module-scoped functions that called `asDuration` to format things as decimal milliseconds. Extract this to an `asMillisecondDuration` function exported from the duration helpers and use it in all the tables.
    * Change `getResponseTimeseries` in chart selectors to use `asDuration` to make all chart timeseries units consistent.
    * Don't export `convertTo` from the duration helpers as it's now not used anywhere. Always use a more specific exported function for more consistency.
    * Change ">=" to "≥" in the ML flyout text.
    
    * Update e2e snapshot
    
    Co-authored-by: Elastic Machine <[email protected]>
    smith and elasticmachine authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    eef8dc7 View commit details
    Browse the repository at this point in the history
  16. [SECURITY SOLUTION] Task/endpoint details to fleet (elastic#68710)

    [SECURITYSOLUTION][INGEST] Fixes endpoint link, adds link from endpoint details to fleet
    
    Co-authored-by: Elastic Machine <[email protected]>
    parkiino and elasticmachine authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    52c8e96 View commit details
    Browse the repository at this point in the history
  17. Set wrap to the errorLink so it doesn't go outside of box (elastic#67797

    )
    
    * set wrap to the errorLink so it doesnt go outside of box
    
    * updating
    
    * set wrap to the errorLink so it doesnt go outside of box
    
    * updating
    
    * Show full message on hover
    
    Co-authored-by: Nathan L Smith <[email protected]>
    brittanyjoiner15 and smith authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    570be32 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    1b9ba5d View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    c09b228 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    169cc24 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    b57149c View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    9ddaebc View commit details
    Browse the repository at this point in the history
  23. Don't use filter to get default config & output (elastic#69088)

    * Don't use filter to get default config & output
    
    the KQL parsing takes up a lot of CPU time. Avoid it with a search string
    
    Also add a `refresh: false` as suggested by @bkobel
    
    * Does restoring await fix CI?
    
    * Remove 'refresh: false' from agent enroll
    
    Does this this fix the failing test? It does keep the PR more focused
    
    Co-authored-by: Elastic Machine <[email protected]>
    John Schulz and elasticmachine authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    0ce2970 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    e3ba5e5 View commit details
    Browse the repository at this point in the history
  25. [Endpoint] Remove dependency on ingest for the index patterns (elasti…

    …c#69058)
    
    * Remove dependency on ingest for the index patterns
    
    * Fixing the tests
    
    * Fixing test
    
    * Use variable instead of class
    jonathan-buttner authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    dc5f448 View commit details
    Browse the repository at this point in the history
  26. Updates the Release Notes content in CONTRIBUTING (elastic#69032)

    * Updates the Release Notes content in CONTRIBUTING
    
    * Release Notes guidelines
    
    * Fixes bulleted list indentation
    KOTungseth authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    4d02eab View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    a7900d0 View commit details
    Browse the repository at this point in the history
  28. [Ingest Manager] Add ability to copy an agent config (elastic#68737)

    * Add copy agent config endpoint, schema types, and request hook
    
    * Add copy config to context menu and modal
    
    * Change data sources to be copied via bulk instead of singles in parallel
    
    * Add copy endpoint to openapi spec file
    
    * Add api integration tests
    
    Co-authored-by: Elastic Machine <[email protected]>
    jen-huang and elasticmachine authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    07241d1 View commit details
    Browse the repository at this point in the history
  29. [ML] Allow editing of model_snapshot_retention_days (elastic#69003)

    * [ML] Allow editing of model_snapshot_retention_days
    
    * removing commented code
    
    * flooring number input
    
    * adding daily_model_snapshot_retention_after_days
    
    * updating default values
    
    Co-authored-by: Elastic Machine <[email protected]>
    jgowdyelastic and elasticmachine authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    b540ada View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    ecd3c9b View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    4f5e279 View commit details
    Browse the repository at this point in the history
  32. [Endpoint] [ES Archiver] Allowing create option to be passed through …

    …the cli for es archiver (elastic#69191)
    
    * Allowing create option to be passed through the cli
    
    * Using kebab casing
    jonathan-buttner authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    646a212 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    f7398f0 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    41e801f View commit details
    Browse the repository at this point in the history
  35. [Reporting/Server] register plugin routes synchronously (elastic#68976)

    * register routes synchronously
    
    * back out some refactoring
    
    * comment fix
    
    * fix tests
    
    * register route handler context provider
    
    * Add function level comments in core methods
    
    * fix tests
    
    * revert editor help
    
    * route context is the ReportingStart contract
    
    * Fix reporting job route tests
    
    * Fix generation tests
    
    Co-authored-by: Joel Griffith <[email protected]>
    Co-authored-by: Elastic Machine <[email protected]>
    3 people authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    7e2ab7f View commit details
    Browse the repository at this point in the history
  36. [release-notes] add script to generate release notes from PRs (elasti…

    …c#68816)
    
    Co-authored-by: spalger <[email protected]>
    Co-authored-by: Elastic Machine <[email protected]>
    3 people authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    cc1758d View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Configuration menu
    Copy the full SHA
    d110e65 View commit details
    Browse the repository at this point in the history
  2. [kbn/optimizer] share all plugin bundles (elastic#68986)

    Co-authored-by: spalger <[email protected]>
    Co-authored-by: Elastic Machine <[email protected]>
    3 people authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    7e32841 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    88eed98 View commit details
    Browse the repository at this point in the history
  4. [Alerting] Adds API for executing actions immediately (elastic#68897)

    This PR adds an API to the AlertsClient which allows users to execute actions immediately, rather than via TaskManager.
    
    This also moves the TaskManager based execution to a new api on ActionsClient along side the immediate execution.
    gmmorris authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    833ce08 View commit details
    Browse the repository at this point in the history
  5. stabilize flaky embeddables/adding_children take 2 (elastic#68873)

    * wait for loading indicator to be deleted
    
    * improve with retry
    
    * Update test/examples/embeddables/adding_children.ts
    
    Co-authored-by: Spencer <[email protected]>
    
    Co-authored-by: Spencer <[email protected]>
    Co-authored-by: Elastic Machine <[email protected]>
    3 people authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    7211257 View commit details
    Browse the repository at this point in the history
  6. Update vega version (elastic#68639)

    * update vega version
    
    * a11y skip test
    
    * a11y skip test attempt 2
    
    * adding back all a11y tests
    
    * fix failed karma test
    
    * remove extra  0BSD license
    
    * coalesce yarn.lock versions a little
    
    * update kbn/pm dist
    
    * fix CI
    
    * fix Vega View for ML
    
    Co-authored-by: Michail Yasonik <[email protected]>
    Co-authored-by: spalger <[email protected]>
    Co-authored-by: Elastic Machine <[email protected]>
    4 people authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    c98845c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d12208c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    83370a1 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6350683 View commit details
    Browse the repository at this point in the history
  10. [ML] Model snapshot management (elastic#68182)

    * [ML] Model snapshot management
    
    * more updates
    
    * adding calendar range
    
    * updating layout
    
    * multiple calendars
    
    * moving calendar creator
    
    * fixing chart issues
    
    * fixing chart issues
    
    * improving calendar rendering
    
    * adding capabilities checks
    
    * code clean up
    
    * fixing end time argument type
    
    * fix translations
    
    * code clean up
    
    * comments based on review
    
    * changes based on review
    
    * fixing include
    
    * adding useMemo to theme function
    jgowdyelastic authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    7a60f18 View commit details
    Browse the repository at this point in the history
  11. [Maps] Security layer wizards (elastic#68290)

    * [Maps] security layer wizard
    
    * index pattern select
    
    * use IndexPattern
    
    * destination layer
    
    * source layer
    
    * cache security index patterns
    
    * line layer
    
    * use top hits
    
    * tslint
    
    * unit test
    
    * fix loading speed and i18n
    
    * handle case where ui setting siem:defaultIndex does not exist
    
    * tslint
    
    * review feedback
    
    * extract lazy load bundle from map embeddables
    
    * expose createSecurityLayers via plugin start
    
    * tslint
    
    * export MapsPluginStart
    
    * fix path move
    
    * review feedback
    
    * fix import
    
    Co-authored-by: Elastic Machine <[email protected]>
    nreese and elasticmachine authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    dd1f64d View commit details
    Browse the repository at this point in the history
  12. [Ingest Node Pipelines] Pipeline Processors Editor (elastic#66021)

    * initial plugin setup
    
    * add smoke test
    
    * fix license check
    
    * refactor plugin setup
    
    * Server-side create/update ingest pipelines (elastic#62744)
    
    * List pipelines (elastic#62785)
    
    * First iteration of ingest table
    
    * Add action placeholders
    
    * Refactor list and address PR feedback
    
    Refactored the list into smaller pieces and assemble in main.tsx
    
    Also addressed feedback on copy, removed unused notifications dep
    
    * WiP on flyout
    
    Showing name in title
    
    * Add reload button
    
    * Finish first version of flyout
    
    * Slight update to copy
    
    * `delete` -> `edit`
    
    * Address PR feedback
    
    Copy and a11y updates
    
    * Add on failure JSON to flyout if it is available
    
    * Add details json block file and remove ununsed import
    
    Co-authored-by: Elastic Machine <[email protected]>
    
    * [Ingest pipelines] Create pipeline UI (elastic#63017)
    
    * First vertical slice of pipeline editor component
    
    * Made a space for common parameters
    
    * [Ingest pipelines] Edit pipeline page (elastic#63522)
    
    * First iteration of CRUD functionality working
    
    * WiP on moving the pipeline editor to pipeline processor editor
    
    * Finish refactor to work with passing state out
    
    * Refactor and fix tests
    
    * [Ingest pipelines] Polish details panel and empty list (elastic#63926)
    
    * Address some early feedback and use FormDataProvider
    
    FormDataProvider gives a more declarative way to listen to form
    state updates.
    
    Also refactored the state reader mechanism.
    
    * [Ingest pipelines] Delete pipeline (elastic#63635)
    
    * [Ingest Node Pipelines] Clone Pipeline (elastic#64049)
    
    * First iteration of clone functionality
    
    Wired up for both the list table and the details flyout in the
    list section.
    
    * satisfy eslint
    
    * Turn on sorting for the list table
    
    * Clean up const declarations
    
    * Address PR feedback
    
    Sentence-casify and update some other copy.
    
    * Mark edit and delete as primary actions in list table
    
    * Handle URI encoded chars in pipeline name when cloning
    
    * Update to using the more flexible controlled component pattern
    
    To make this component and mappings editor more consistent, both
    will expose a more traditional controlled component interface to
    consumers.
    
    In the current implementation this requires that consumers use
    `useCallback` for `onUpdate` handlers to avoid an infinite
    rendering cycle and to avoid staleness bugs in their `onUpdate`
    handlers they need to think about what might make the handler
    stale.
    
    This approach comes with the benefits and flexibility of
    controlled components at the cost of slightly more complex
    consumption of the components.
    
    In future, we can explore adding the uncontrolled component
    interface too so that consumers have the option to more simply
    render and pull data out only when needed
    
    * Handle sub-form validity
    
    The pipelines processor editor not emits overall validity to
    consumers
    
    * Fix Jest test
    
    * Refactor some names
    
    prepareDataOut -> serialize
    prepareDataIn -> deserialize
    EditorProcessor -> ProcessorInternal
    
    * Mark as private
    
    * Major WiP
    
    Started working on the drag-and-drop-tree and updated some
    typings stuff
    
    * [Ingest node pipelines] Privileges (elastic#63850)
    
    * Create privileges check for ingest pipelines app
    
    Also moved the public side logic for checking and rendering
    privilege related messages to es_ui_shared/public following the
    new __packages_do_not_import__ convention.
    
    * Add ,
    
    * Fix import paths
    
    * Address PR feedback
    
    Fix i18n strings (remove reference to snapshot and restore) and
    fix copy referencing snapshot and restore - all copy-pasta errors.
    
    Also remove unused field from missing privileges object.
    
    * Fix issue from resolving merge conflicts
    
    * Add missing app privilege
    
    * Use non-deprecated privilige name
    
    * First iteration of drag and drop tree on feature parity
    
    * First steps toward add on failure handler
    
    Updated reducer logic to create the next copy value using immer.
    
    * First iteration of nested tree with add on failure working
    
    * Refactor and some UI layout updates
    
    - Remove the "id" field on processors for now
    - Implement the nested remove and update functionality again
    
    * Remove immer (not call stack safe)
    
    Refac to remove immer and reimplemented the immutable set and
    get functions.
    
    * [Ingest Node Pipelines] More lenient treatment of on-failure value (elastic#64411)
    
    * Move file to components folder
    
    * [Ingest pipelines] Simulate pipeline (elastic#64223)
    
    * Updated tree rendering
    
    - turn off dropzones for children
    - fixed up some padding and margins
    - fixed integration with pipeline_form.tsx
    
    The current implementation still has a lot of jank stemming from
    the UX with DnD. Unfortunately the nesting has opened a number
    of issues here.
    
    * [Ingest Node Pipelines] Show flyout after editing or creating a pipeline (elastic#64409)
    
    * Show flyout after editing or creating a pipeline
    
    * JSX comment
    
    * Show not found flyout
    
    Copied from CCR
    
    * update not found flyout and fix behavior when viewing details from table
    
    * Reset pipeline name in URI when closing flyout
    
    * Remove encodeURI
    
    Already using encodingURIComponent for unsafe string.
    
    Co-authored-by: Alison Goryachev <[email protected]>
    
    * Clarification of terms
    
    - addProcessor -> addTopLevelProcessor (same in editor modes)
    - Expanded comment on ProcessorSelector
    
    * Implement move between lists functionality
    
    Added tests to the reducer for moving in and out of a recusrsive
    structure.
    
    * fix TS
    
    * Prevent nesting a parent inside of its own child
    
    * Add comment
    
    * [Ingest pipelines] Cleanup (elastic#64794)
    
    * address review feedback
    
    * remove unused import
    
    * Big refactor to tree rendering structure
    
    DnD tree now converts the nested tree to a flat one and only
    consists of _1_ droppable area with a flat array of draggables
    that can be combined.
    
    Using the existing logic in the reducer combined with translating
    the flat structure changes to a format the nested reducer can
    understand looks like a really promising avenue.
    
    There still seems to be a bug with a longer list where items do
    not interact properly.
    
    * Remove unused component
    
    * A number of NB changes
    
    - Fixed a subtle serialisation bug with on_failure in options
    - Fixed a performance bug by using useRef in pipeline form
    - Memoized the drag and drop tree
    - Removed use of "isValid" from form lib... I think this should
    be removed entirely.
    
    * fix bad conflict resolution
    
    * Implemented a slightly better destination resolution algo.
    
    Also added tests.
    
    * Fix subtle staleness bug, whitelist keys for setValue
    
    * NB styling fix!!
    
    Due to a parent's setting of overflow: hidden the drag and drop
    tree had a dead zone that would equal the page overflow limit,
    unsetting on the component itself (overflow: auto) relaxes this
    limitation.
    
    * Fix stale delete bug too
    
    * Update naming of editor modes and update comments
    
    * Use field types combo box
    
    * Add delete confirmation modal
    
    * Refactor delete modal component file name
    
    * Better visual integration with existing form
    
    * Update layout and styling of form
    
    - added some padding around the new processors editor field
    - Updated use of flex box in the pipeline form fields
    
    * Move pipeline processor copy into pipeline processor component
    
    The test button is also now inside of the pipeline processor
    editor. Eventually all of this functionality should be moved
    into the pipeline processor editor.
    
    * First step of refactor to moving between trees
    
    * First iteration of x-tree drag and drop
    
    * Remove unused import
    
    * Fix jest test types
    
    * Fix up minor i18n issues and fix up layout of on failure
    
    * Remove unnecessary prop
    
    * Update spacing above add processor button to make it more center
    
    * Fix destination resolution algo
    
    * Update dragging resolver unit tests and add a lot more comments
    
    * Use one sorting algo (removed use of euiReorder for now)
    
    * Add placeholder tests and update comments
    
    * Quite a big refactor
    
    - Remove DraggableLocation entirely, only use ProcessorSelector
    this simplifies mapping back to reducer instructions quite a lot
    - Add tests for special case dragging behaviour
    
    * Fix off by one bug in tests and implementation 🤦🏼‍♂
    
    - Also move processor reducer to it's own folder
    
    * Update behaviour for dragging up across trees and add tests
    
    * Fix combine instruction
    
    * Fix test and i18n issues
    
    * Remove background color
    
    * Fix selector after selector refactor
    
    * A major performance
    
    - Do not re-render the entire tree when editing settings
    
    * Fix component smoke test
    
    * Fix reading value from processor state using processor selector
    
    * [Ingest pipelines] Custom processor form (elastic#66022)
    
    * Re add background color and refactor name of processor item
    
    * Fix file naming and refactor 🚜 dnd tree rendering
    
    - deserialze and serialize were backwards, fixed
    - the dnd tree was rendering a flat tree which needed to be
    mapped back to the nested tree for updates. This is still the
    case but we do use recursive rendering. This enables tree nodes
    to better hold local state like whether they are collapsed or not.
    
    * Fix getting of initial on failure processors value
    
    * Update padding styles for containers
    
    * A lot of styling updates to get closer to look of mockup
    
    * A WiP version of th click-tree an alternative to dnd
    
    As a response to really long pipelines we may pivot away from
    dnd.
    
    * Remove dnd tree
    
    * clean up reamining dnd tree references
    
    * Clean up and refactor of tree component
    
    To simplify the logic of the tree component processor id's
    were added. Also had to update the jest spec to support this
    
    * Added the ability to duplicate a processor
    
    * Fix types in test
    
    * Added duplicate functionality to ui
    
    * Memoize tree components
    
    * address es lint issues
    
    * remove unused import
    
    * Fix editing of custom json
    
    * Address form performance issues
    
    * Add all known missing processors
    
    * Add ability to cancel move
    
    * Fix staleness in test and view request flyouts
    
    * fix type issue
    
    * Remove unused translations and skip funcitonal test for now
    
    * add todo comment
    
    * Fix type issues
    
    * remove poc styles
    
    * disable other move buttons if we have a selected processor
    
    * Refactor drop zone pin to button and add some styling
    
    * Refactor processor editor item
    
    * Update styling and use icon for cancel move action too
    
    * fix nasty integration bug
    
    * some minor optimizations
    
    * prevent parent from being placed in own on failure handler
    
    * Re-add cancel button
    
    * Re-introduce failure processors toggle
    
    * Fix typo
    
    * Add Handler types for processor editor item
    
    * Fix staleness bug for type, refactor classname and fix duplicate
    bug not immutably copying values
    
    * Experimenting with padels (revert this to undo if no further
    changes have been made)
    
    * Add description and unique ids
    
    * Share links via component-wide context rather than props
    
    * Virtualized list and back to outline dropzones
    
    * Refactor id getter to a service and make it an incrementing number
    
    * Temporary fix for double rendering issue.
    
    This means the pipeline processors component is not controllable
    but fixes the double rendering even when processors have not
    changed. This is a problem coming from the ingest pipelines
    plugin form system outside of this component
    
    * add todo comment
    
    * remove euicode element
    
    * properly handle duplicate flow
    
    * attempt to fix i18n
    
    * split private_tree into it's own component and add comments
    
    * refactor 🚜. rename Tree to ProcessorsTree and move things around
    
    * do not delete the top level arrays for processors and onfailures
    
    * fix typescript error
    
    * Move duplicate, addOnFailure and delete actions into ctx menu
    
    * remove unused import
    
    * add support for pressing esc key to cancel move
    
    * Add outside click listener
    
    * always prompt before deleting a processor
    
    * refactor remove distinction between adding top level and on fail
    
    * add processor button to tree
    
    * Hide the add on failure context menu item for processors with
    failure handlers
    
    * Reinstated x-tree moving and highlight and disable for buttons
    on move and on edit
    
    * removing ids step 1: remove idGenerator
    
    * remove ids step 2: added inline text input
    
    Also refactored a lot of the tree actions away. Now using
    context and the processors editor tree item component for
    dispatching actions. The tree item has access to the dispatch
    and to the selector which makes it a well positioned component.
    
    Also saves on some props drilling.
    
    * Slight improvement to styling of text input (border)
    
    * Re-implement missing failure toggle test
    
    * address type todo
    
    * Address many type issues and fix yarn.lock
    
    * re-enable create pipeline functional test
    
    * prevent multiple flyouts from opening
    
    * change flyout title when editing an on-failure processor
    
    * absolutely position the failure handlers label
    
    when we render a dropzone on the label, then we move the label
    up without affecting overall component height
    
    * fix description behaviour not removing tag if empty
    
    * some minor clean up
    
    * add onflyoutopen cb to tests
    
    * refactor processors editor item to multiple files
    
    also refactored i18n into it's own file. would be good to come
    up with a pttaern for doing this more broadly.
    
    * fix add on-failure handler in context menu after refactor
    
    * tag -> new description field
    
    Co-authored-by: Alison Goryachev <[email protected]>
    Co-authored-by: Elastic Machine <[email protected]>
    Co-authored-by: Alison Goryachev <[email protected]>
    4 people authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    7511a6e View commit details
    Browse the repository at this point in the history
  13. [ML] DF Analytics Results: do not hide query bar and table on query s…

    …yntax error (elastic#69196)
    
    * do not hide query bar and table if query syntax error
    
    * check for query error in analytics exploration
    alvarezmelissa87 authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    2ebe35f View commit details
    Browse the repository at this point in the history
  14. [Ingest Manager] Use search param vs KQL for events count (elastic#69209

    )
    
    * Replace filter with search in events count
    
    Co-authored-by: Elastic Machine <[email protected]>
    John Schulz and elasticmachine authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    798c520 View commit details
    Browse the repository at this point in the history
  15. [Ingest Manager] Use search param vs KQL to find default agent (elast…

    …ic#69211)
    
    * Remove another instance of filter for is_default
    
    Co-authored-by: Elastic Machine <[email protected]>
    John Schulz and elasticmachine authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    7beabd2 View commit details
    Browse the repository at this point in the history
  16. [SIEM][Detection Engine] Fixes a stale view/query within the signals …

    …table when re-opening/closing signals
    
    ## Summary
    
    Fixes a one liner bug where we were not using waitFor and could have stale views of data from the timeline. This removes that by adding a `waitFor` when setting the signals to be closed, open, in-progress, etc...
    
    This also adds a new `waitFor` for the end to end tests and fixes other tests to use that rather than doing a wait for 5 seconds. This should keep the end to end backend tests fast. 
    
    Before this you could sometimes try to re-open 3 signals like below and it would not change the signals to being open but rather re-query the stale view and show the same signals as being closed when they are not closed:
    ![crop_bug](https://user-images.githubusercontent.com/1151048/84713572-8b5e7f00-af28-11ea-80b6-2ad67f16b7df.gif)
    
    Now with this PR, those signals will show as being re-opened and the closed signals will update correctly within the same UI on the same tab.
    
    ### Checklist
    
    - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
    FrankHassanabad authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    461d44d View commit details
    Browse the repository at this point in the history
  17. [Observability] Update landing page copy and content (elastic#69247)

    * removing try it section
    
    * removing try it section
    cauemarcondes authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    b42defa View commit details
    Browse the repository at this point in the history
  18. feat: instrument navigation changes using RUM agent (elastic#67633)

    * feat: instrument navigation changes using RUM agent
    
    * chore: rebase and change application contract
    
    * chore: fix type tests
    
    * docs: update public.md doc
    
    * chore: remove internal application export
    vigneshshanmugam authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    f43d51d View commit details
    Browse the repository at this point in the history
  19. [Uptime] Monitor availability reporting (elastic#67790)

    Co-authored-by: Elastic Machine <[email protected]>
    shahzad31 and elasticmachine authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    a9d73e8 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    9c88144 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    fb97d91 View commit details
    Browse the repository at this point in the history
  22. [kbn/es] only make one attempt in tests to avoid timeout (elastic#69197)

    Co-authored-by: spalger <[email protected]>
    Co-authored-by: Elastic Machine <[email protected]>
    3 people authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    62f2550 View commit details
    Browse the repository at this point in the history
  23. Resolve security cloud test failures (elastic#68935)

    Co-authored-by: Joe Portner <[email protected]>
    Co-authored-by: Elastic Machine <[email protected]>
    3 people authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    3de9350 View commit details
    Browse the repository at this point in the history
  24. SIEM] Moves validation up to the common section

    ## Summary
    
    Moves validation up to the common section so it can be used by others in common for API boundary validation.
    FrankHassanabad authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    d5785a0 View commit details
    Browse the repository at this point in the history
  25. [QA] Code coverage: fix flaky tests (elastic#69272)

    * skip test
    
    * [page_objects/common_page] update closing toast
    dmlemeshko authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    9f7620b View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    efbb4cc View commit details
    Browse the repository at this point in the history
  27. [kbn/optimizer] fix windows compatibility (elastic#69304)

    Co-authored-by: spalger <[email protected]>
    Spencer and spalger authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    db1df7b View commit details
    Browse the repository at this point in the history
  28. [Search service] Refactor the way server-side search strategies are r…

    …egistered (elastic#68452)
    
    * [search] Refactor the way search strategies are registered/retrieved on the server
    
    * Fix types and tests and update docs
    
    * Fix failing test
    
    * Fix build of example plugin
    
    * Fix functional test
    
    * Make server strategies sync
    
    Co-authored-by: Liza K <[email protected]>
    lukasolson and Liza K authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    ade4c8d View commit details
    Browse the repository at this point in the history
  29. [ci/getCheckoutInfo] retry fetching upstream changes to calculate mer…

    …geBase (elastic#69320)
    
    Co-authored-by: spalger <[email protected]>
    Spencer and spalger authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    5c327a1 View commit details
    Browse the repository at this point in the history
  30. [QA] [Code Coverage] Doc update (elastic#69204)

    Co-authored-by: Elastic Machine <[email protected]>
    wayneseymour and elasticmachine authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    885a42c View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    beb0da1 View commit details
    Browse the repository at this point in the history
  32. [kbn/pm] only count cached project (elastic#69113)

    Co-authored-by: spalger <[email protected]>
    Co-authored-by: Elastic Machine <[email protected]>
    3 people authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    8b0efca View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    8bc8837 View commit details
    Browse the repository at this point in the history
  34. [APM] Fix service maps not loading when there are no APM ML jobs (ela…

    …stic#69240)
    
    * Closes elastic#69238 by handling 404 thrown error from the query for APM ML jobs.
    
    * Improved coded readability
    
    * moved anomaly job fetch to new function getApmAnomalyDetectionJobs for
    improved readability and only handle a 404 status code response else throw
    ogupte authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    5c87a27 View commit details
    Browse the repository at this point in the history
  35. [BundleRefPlugin] resolve imports to files too (elastic#69241)

    Co-authored-by: spalger <[email protected]>
    Spencer and spalger authored Jun 16, 2020
    Configuration menu
    Copy the full SHA
    e03f242 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Configuration menu
    Copy the full SHA
    ca9a162 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a34a3a7 View commit details
    Browse the repository at this point in the history
  3. [SIEM] Adds example unit test to convert KQL using a nested query

    ## Summary
    
    Adds example unit test to convert KQL using a nested query
    
    ### Checklist
    
    - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
    FrankHassanabad authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    effd504 View commit details
    Browse the repository at this point in the history
  4. Explore underlying data (elastic#68496)

    * feat: 🎸 stub discover_enhanced plugin
    
    * feat: 🎸 improve view in discover action
    
    * feat: 🎸 add URL generator to "View in Discover" action
    
    * feat: 🎸 implement navigation and getHref in view raw logs actio
    
    * fix: 🐛 disable action in "edit" mode
    
    * refactor: 💡 renamce context menu view in discover action
    
    * feat: 🎸 rename action to "explore data"
    
    * fix: 🐛 correctly generate action path
    
    * feat: 🎸 add internationalization to "explore action"
    
    * fix: 🐛 correctly parse generated Discover URL path
    
    * test: 💍 setup basic functional tests
    
    * refactor: 💡 modularize url generation logic
    
    * feat: 🎸 export CommonlyUsed type
    
    * test: 💍 add test subjects to panel custom time range modal
    
    * test: 💍 add index patterna and time range functional tests
    
    * refactor: 💡 rename action file
    
    * refactor: 💡 use URL generator from Discover plugin's contract
    
    * test: 💍 add "Explore raw data" action unit tests
    
    * fix: 🐛 import share plugin to check if it is enabled
    
    * Update x-pack/plugins/discover_enhanced/public/actions/view_in_discover/explore_data_context_menu_action.ts
    
    Co-authored-by: Matthias Wilhelm <[email protected]>
    
    * chore: 🤖 add discover_enhanced to KibanaApp codeowners
    
    * test: 💍 improve "Explore underlying data" functional tests
    
    * test: 💍 improve <a> link assertion
    
    Co-authored-by: Elastic Machine <[email protected]>
    Co-authored-by: Matthias Wilhelm <[email protected]>
    3 people authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    3ee0bf2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8a6aab3 View commit details
    Browse the repository at this point in the history
  6. Replaces the Custom Color Picker on TSVB with the EuiColorPicker (ela…

    …stic#68888)
    
    * Replace the Custom Color Picker on TSVB with the EuiColorPicker
    
    * Remove the custom picker sass
    
    * Remove private modules of eui and the custom color swatches
    
    * Clear the color
    
    * changes in test implementation
    
    Co-authored-by: Elastic Machine <[email protected]>
    stratoula and elasticmachine authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    ab1270e View commit details
    Browse the repository at this point in the history
  7. [SIEM][Timeline] Persist timeline to localStorage (elastic#67156)

    Co-authored-by: Elastic Machine <[email protected]>
    Co-authored-by: Xavier Mouligneau <[email protected]>
    3 people authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    47e50f8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3ea717a View commit details
    Browse the repository at this point in the history
  9. [ML] Functional tests - add more recognize and setup module API tests (

    …elastic#69251)
    
    This PR adds a couple recognize module and setup module API integration tests.
    pheyos authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    55260dd View commit details
    Browse the repository at this point in the history
  10. [ML] Functional tests - Reduce DFA job model memory (elastic#69295)

    With the improvements in the model memory estimation for DFA jobs, the required memory limit could be reduced, which allows execution in a low-memory environment (like the 1GB ML node in a cloud trial).
    pheyos authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    f8ba929 View commit details
    Browse the repository at this point in the history
  11. Update dependency @elastic/charts to v19.5.2 (elastic#69126)

    Update @elastic/charts to 19.5.2
    
    Co-authored-by: nickofthyme <[email protected]>
    markov00 and nickofthyme authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    f9f1158 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    208b580 View commit details
    Browse the repository at this point in the history
  13. [DOCS] Updates titles in Maps docs (elastic#68703)

    * [DOCS] Updates titles in Maps docs
    
    * [DOCS] Changes Elastic Maps to Maps to match the UI
    
    * [DOCS] Fixes titles
    
    Co-authored-by: Elastic Machine <[email protected]>
    gchaps and elasticmachine authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    e04624a View commit details
    Browse the repository at this point in the history
  14. [Ingest Manager][Endpoint] Add Endpoint Create Policy flow with Ingest (

    elastic#68955)
    
    * Ingest: add data-test-subj prop support to Ingest components
    * Ingest: Add Context Provider to bridge History from Kibana to Hash router
    * Ingest: Added support for route state in Create Datasource page
    * Endpoint: Add Create button to Polices List header
    * Endpoint: Added support for passing of state from endpoint to ingest on policy
    * Endpoint: additional functional test cases
    paul-tavares authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    abdc0f1 View commit details
    Browse the repository at this point in the history
  15. [APM] Replace ML index queries with searching via mlAnomalySearch API (

    …elastic#69099)
    
    * Closes elastic#69092 by replacing direct queries on ml indices with seaching
    via the `mlAnomalySearch` client API + job_id filters. Also removes
    `getMlIndex` since it is no longer relevant.
    
    * Use the mlCapabilities API to ensure the required license is active for ml queries
    
    Co-authored-by: Elastic Machine <[email protected]>
    ogupte and elasticmachine authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    0ed7597 View commit details
    Browse the repository at this point in the history
  16. Drilldown docs 2 (elastic#69375)

    * docs: ✏️ add drilldown user docs link to REAMDE
    
    * feat: 🎸 wire drilldown docs link into <HelloBar> component
    
    * feat: 🎸 set new page attributes on drilldown docs link
    
    * feat: 🎸 add external prop to link to show icon
    
    * fix: 🐛 remove rel= attribute
    
    * fix: 🐛 add TypeScript type for drilldown docLink
    streamich authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    b8e6b54 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    1cef65e View commit details
    Browse the repository at this point in the history
  18. [Ingest Pipelines] Add doc links to processor types (elastic#69279)

    * added doc links to processor types
    
    * Bring doc links in line with mappings editor
    
    Also refactor the processors type map
    
    * remove helpText prop from Custom field
    
    * fix i18n
    
    * rename doc button and refactor type map const name
    
    Co-authored-by: Elastic Machine <[email protected]>
    jloleysens and elasticmachine authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    a077fde View commit details
    Browse the repository at this point in the history
  19. Removing flaky axe rule (elastic#69418)

    Michail Yasonik authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    bb03b75 View commit details
    Browse the repository at this point in the history
  20. [Ingest Manager] Replace datasources with inputs when generating …

    …agent config (elastic#69226)
    
    * Adjust agent config generation, change `datasources` to `inputs`
    
    * Add dataset.type
    
    * Remove dead code
    
    * Revert "Add dataset.type"
    
    This reverts commit fbcf50c.
    
    * Update endpoint policy test assertion
    jen-huang authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    052dfe9 View commit details
    Browse the repository at this point in the history
  21. [ML] Add Anomaly Swimlane Embeddable to the dashboard from the Anomal…

    …y Explorer page (elastic#68784)
    
    * [ML] WIP attach swimlane embeddable to dashboard from the explorer page
    
    * [ML] fix deps
    
    * [ML] getDefaultPanelTitle
    
    * [ML] fix TS issue
    
    * [ML] DashboardService
    
    * [ML] unit tests
    
    * [ML] redirect to the dashboard
    
    * [ML] swimlane_panel
    
    * [ML] Anomaly Timeline panel
    
    * [ML] swimlane container
    
    * [ML] fix ts
    
    * [ML] Add multiple swimlanes
    
    * [ML] fix SwimlaneType usage
    
    * [ML] disable edit button on update
    
    * [ML] fix i18n translation key
    
    * [ML] use ViewMode enum
    
    * [ML] use navigateToUrl
    
    * [ML] TODO for edit dashboard
    
    * [ML] check kibana dashboard capabilities
    
    * [ML] mlApiServicesProvider
    
    * [ML] mlResultsServiceProvider
    
    * [ML] fix alignment
    
    * [ML] labels and tooltips
    
    * [ML] fix ts issue for proxyHttpStart
    
    * [ML] canEditDashboards check
    
    * [ML] fix TS
    
    * [ML] update add_to_dashboard_control.tsx
    
    * [ML] add form label, disable control on empty swimlanes selection
    
    * [ML] resolve PR review comments
    
    * [ML] e2e test
    
    * [ML] increase panel padding
    
    * [ML] position in row
    
    * [ML] update e2e
    
    * [ML] add data-test-subj for search box
    
    * [ML] PR remarks
    darnautov authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    1dd5db2 View commit details
    Browse the repository at this point in the history
  22. WIP. Pushing for CI

    John Schulz committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    f594be3 View commit details
    Browse the repository at this point in the history
  23. Don't throw. Use Promise.reject

    John Schulz committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    2c29cd7 View commit details
    Browse the repository at this point in the history
  24. Reject with an Error; not a string

    John Schulz committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    e61e7ec View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. Merge branch 'no-await-setup-return-promise' of github.com:jfsiii/kib…

    …ana into no-await-setup-return-promise
    John Schulz committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    ab0217e View commit details
    Browse the repository at this point in the history
  2. Add Ingest setup to Endpoint FTR tests.

    Refactor start method
    John Schulz committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    e10df84 View commit details
    Browse the repository at this point in the history