Remove regex flags parameter from terms and significant terms aggs #6875

ycombinator · 2016-04-12T18:51:07Z

jbudz · 2016-04-13T17:34:12Z

LGTM in Kibana. Does this need to be removed from Console autocomplete too?

ycombinator · 2016-04-13T20:29:41Z

Thanks for catching that @jbudz. Yup, Console needs to be updated too. Marking this PR as WIP so I can include Console changes too.

ycombinator · 2016-04-13T21:55:30Z

@jbudz Actually, Console is an included plugin in Kibana only as of 5.0. So there are two things that need to happen, IMO:

fix for ES 2.0 APIs needs to go into the old Sense repo. I've created an issue for that here: Update include+exclude syntax for Terms/Significant terms aggs sense#129
Console (as an included plugin in Kibana) needs to start supporting ES 5.x APIs. Currently it only has support for ES 1.x and 2.x APIs. I've created an issue for that here: Console needs to support Elasticsearch 5.x APIs #6913

I don't think the change in this PR ought to be blocked on either of those issues. What do you think?

jbudz · 2016-04-13T22:05:53Z

👍 works for me. LGTM.

ycombinator added 3 commits April 12, 2016 11:33

Removing regex flags from regex agg parameter type

e17dde0

Removing regex flags CSS declarations

8bf5f10

Removing docs about regex flags

a62c627

ycombinator added the review label Apr 12, 2016

ycombinator assigned rashidkpc and jbudz and unassigned rashidkpc Apr 12, 2016

jbudz assigned ycombinator and unassigned jbudz Apr 13, 2016

ycombinator removed the review label Apr 13, 2016

ycombinator merged commit 14f4b1a into elastic:master Apr 13, 2016

ycombinator deleted the gh-6714 branch April 13, 2016 22:09

ycombinator added v5.0.0 v5.0.0-alpha1 v5.0.0-alpha2 and removed v5.0.0-alpha1 labels Apr 13, 2016

Bargs mentioned this pull request Jun 10, 2016

Backport Request - Remove regex flags parameter from terms and significant terms aggs #7408

Closed

Provide feedback