Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [SIEM][Exceptions] - ExceptionsViewer UI component part 2 (#68294) #68729

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

yctercero
Copy link
Contributor

Backports the following commits to 7.x:

)

### Summary 

This PR is a follow up to elastic#68027 . It brings it all together to complete the exceptions viewer component. This component is meant to display all exception items and allow a user to create, edit, delete, and search these exception items.

- Moves ExceptionItem (from part 1) into its own folder
- Adds exceptions_viewer_header component that includes the search, list toggle, and add exception buttons
- Adds actual ExceptionViewer component
- Updates the useExceptionList hook refresh function logic. Noticed that the previous version was creating some issues
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/fleet/enrollment_api_keys/crud·ts.apis Fleet Endpoints fleet_enrollment_api_keys_crud GET /fleet/enrollment-api-keys should list existing api keys

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/61027

[00:00:00]       │
[00:00:00]         └-: apis
[00:00:00]           └-> "before all" hook
[00:08:33]           └-: Fleet Endpoints
[00:08:33]             └-> "before all" hook
[00:09:04]             └-: fleet_enrollment_api_keys_crud
[00:09:04]               └-> "before all" hook
[00:09:04]               └-> "before all" hook
[00:09:04]                 │ info [fleet/agents] Loading "mappings.json"
[00:09:04]                 │ info [fleet/agents] Loading "data.json"
[00:09:04]                 │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1591753172592735621] [.kibana_1/I7d4QHKrTv-6Tjl0oq7Q6w] deleting index
[00:09:04]                 │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1591753172592735621] [.kibana_2/BJWtBd3ZRH-JEN3peR2vzw] deleting index
[00:09:05]                 │ info [fleet/agents] Deleted existing index [".kibana_2",".kibana_1"]
[00:09:05]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1591753172592735621] [.kibana_1] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:09:05]                 │ info [fleet/agents] Created index ".kibana_1"
[00:09:05]                 │ debg [fleet/agents] ".kibana_1" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:09:05]                 │ info [fleet/agents] Indexed 12 docs into ".kibana"
[00:09:05]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1591753172592735621] [.kibana_1/A3_uNOyRRrevCsza5iwxdA] update_mapping [_doc]
[00:09:05]                 │ debg Migrating saved objects
[00:09:06]                 │ proc [kibana]   log   [02:44:36.839] [info][savedobjects-service] Creating index .kibana_2.
[00:09:06]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1591753172592735621] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:09:06]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1591753172592735621] updating number_of_replicas to [0] for indices [.kibana_2]
[00:09:06]                 │ proc [kibana]   log   [02:44:36.943] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:09:06]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1591753172592735621] [.kibana_2/ZdOVW4D7TY2TXXJi3JZ68Q] update_mapping [_doc]
[00:09:06]                 │ proc [kibana]   log   [02:44:37.024] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:09:06]                 │ proc [kibana]   log   [02:44:37.086] [info][savedobjects-service] Finished in 249ms.
[00:09:06]               └-> "before all" hook
[00:09:06]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1591753172592735621] [.kibana_2/ZdOVW4D7TY2TXXJi3JZ68Q] update_mapping [_doc]
[00:09:06]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1591753172592735621] [.kibana_2/ZdOVW4D7TY2TXXJi3JZ68Q] update_mapping [_doc]
[00:09:06]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1591753172592735621] [.kibana_2/ZdOVW4D7TY2TXXJi3JZ68Q] update_mapping [_doc]
[00:09:06]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xl-1591753172592735621] [.kibana_2/ZdOVW4D7TY2TXXJi3JZ68Q] update_mapping [_doc]
[00:09:07]                 │ proc [kibana]   log   [02:44:38.452] [error][ingestManager][plugins] Error connecting to package registry at https://epr.elastic.co/package/system/0.1.0: Error connecting to package registry at https://epr.elastic.co/package/system/0.1.0: Backend unavailable, connection timeout
[00:09:09]               └-: GET /fleet/enrollment-api-keys
[00:09:09]                 └-> "before all" hook
[00:09:09]                 └-> should list existing api keys
[00:09:09]                   └-> "before each" hook: global before each
[00:09:09]                   │ proc [kibana]  error  [02:44:38.499]  Error: Internal Server Error
[00:09:09]                   │ proc [kibana]     at HapiResponseAdapter.toError (/dev/shm/workspace/install/kibana-7/src/core/server/http/router/response_adapter.js:132:19)
[00:09:09]                   │ proc [kibana]     at HapiResponseAdapter.toHapiResponse (/dev/shm/workspace/install/kibana-7/src/core/server/http/router/response_adapter.js:86:19)
[00:09:09]                   │ proc [kibana]     at HapiResponseAdapter.handle (/dev/shm/workspace/install/kibana-7/src/core/server/http/router/response_adapter.js:81:17)
[00:09:09]                   │ proc [kibana]     at Router.handle (/dev/shm/workspace/install/kibana-7/src/core/server/http/router/router.js:160:34)
[00:09:09]                   │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:68:7)
[00:09:09]                   └- ✖ fail: "apis Fleet Endpoints fleet_enrollment_api_keys_crud GET /fleet/enrollment-api-keys should list existing api keys"
[00:09:09]                   │

Stack Trace

Error: expected 1 to equal 2
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:227:8)
    at Assertion.be (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:69:22)
    at Context.it (test/api_integration/apis/fleet/enrollment_api_keys/crud.ts:35:38)

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero merged commit e2acb2a into elastic:7.x Jun 10, 2020
@yctercero yctercero deleted the backport/7.x/pr-68294 branch October 14, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants