-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Adds breaking changes for 7.8 #68588
Conversation
Pinging @elastic/kibana-docs (Team:Docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the collapsed view for the plugin breaking changes section, but I think the end user section should be left expanded, so it's easier to see what changed at a glance.
docs/migration/migrate_7_8.asciidoc
Outdated
==== | ||
|
||
[[breaking_78_bump_less_version]] | ||
.The less version in TSVB was updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Less version updated in TSVB Markdown visualization
docs/migration/migrate_7_8.asciidoc
Outdated
|
||
|
||
[[breaking_78_metrics_alerts]] | ||
.Action messaging was refactored to report on the no data state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metrics alerts action messaging was refactored to report on the no data state.
docs/migration/migrate_7_8.asciidoc
Outdated
=== Breaking changes for users | ||
|
||
[[breaking_78_actions_api]] | ||
.The actions API endpoint changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this belongs in the user-facing section. Confirming with Yulia and Bill.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YulNaumenko can you please comment on whether this content belongs in the user-facing section or the plugin developer section of the breaking changes doc? See here for a preview of the doc:
https://kibana_68588.docs-preview.app.elstc.co/guide/en/kibana/7.x/breaking-changes-7.8.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it should be a plugin developer section of the breaking changes doc.
This fixes the Back button when navigating between dashboards using drilldowns. | ||
|
||
*via {pull}62415[#62415]* | ||
==== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a user facing breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@streamich Can you please comment on whether this content should be moved to the user-facing section of the breaking changes doc? See here for a preview of the doc:
https://kibana_68588.docs-preview.app.elstc.co/guide/en/kibana/7.x/breaking-changes-7.8.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me it feels like (if it is a breaking change) it is, both, user and plugin developer facing breaking change. The change is basically that in a long Kibana URL like
http://kibana:5620/dashboard/xxx#...&panels={...}
The panels={ ... }
variable is no longer present, like this
http://kibana:5620/dashboard/xxx#...
This change is technically in KibanaApp team's codebase, so I'll ping them to comment on how they see it: @timroes @ThomThomson @ppisljar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to me like more of a user facing change because it affects view mode. I agree that it does apply to both plugin devs and users, but moving it up to the user facing section will give it a little bit more weight visually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [DOCS] Adds breaking changes for 7.8 * [DOCS] Adds more breaking changes * [DOCS] Reformats breaking changes * [DOCS] Incorporates edits * [DOCS] Incorporates review comments * [DOCS] Fixes links so they work in Install doc
Summary
This PR creates the breaking changes for 7.8.
This doc uses a new format for breaking changes, which includes collapsible sections. You can preview the new format here:
Preview
https://kibana_68588.docs-preview.app.elstc.co/guide/en/kibana/7.x/breaking-changes-7.8.html
To compare this format with previous versions of breaking changes, see the 7.7 breaking changes doc.