[Discover] Unskip context navigation test #68490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
commented
Jun 8, 2020
| /** | ||
| * the provides a quicker way to set the timepicker to the default range, saves a few seconds | ||
| */ | ||
| async setDefaultAbsoluteRangeViaUiSettings() { |
There was a problem hiding this comment.
This should speed go the before section of the test, since there is no interaction necessary to set the time range, however it seems it can't be measured in the jenkins stats of a single test run.
kertal
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jun 12, 2020
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jun 12, 2020
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jun 12, 2020
# Conflicts: # test/functional/apps/context/_discover_navigation.js # test/functional/page_objects/time_picker.ts
kertal
added a commit
that referenced
this pull request
Jun 12, 2020
kertal
added a commit
that referenced
this pull request
Jun 12, 2020
kertal
added a commit
that referenced
this pull request
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improved code testing the navigation between discover and discover context to be no longer flaky.
Here's a run just unskipping the test, 1 of 42 runs was a failure
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/522/testReport/Chrome%20UI%20Functional%20Tests/
Here's the improved code version, 42 runs, no failure
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/524/testReport/Chrome%20UI%20Functional%20Tests/
Fixes #53308
Checklist