Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] DF Analytics: Creation wizard part 2 #68462

Merged
merged 5 commits into from
Jun 9, 2020
Merged

[ML] DF Analytics: Creation wizard part 2 #68462

merged 5 commits into from
Jun 9, 2020

Conversation

alvarezmelissa87
Copy link
Contributor

Summary

Related meta issue: #66661

This is a follow up PR for switching over to the new creation wizard.

This PR ensures job cloning works with the new wizard and removes deprecated code for old creation flyout.

Upcoming follow-ups:

  • hyper parameter validation via explain API
    • disable continue if there is invalid input in the Hyper parameters form

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 requested review from a team as code owners June 6, 2020 00:45
@alvarezmelissa87 alvarezmelissa87 self-assigned this Jun 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

walterra
walterra reviewed Jun 8, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just added two small comments. I'll also do a local test and will report back :)

...n/data_frame_analytics/pages/analytics_management/components/analytics_list/action_clone.tsx
Comment on lines +404 to +406
window.location.href = `ml#/data_frame_analytics/new_job?index=${encodeURIComponent(
sourceIndexId
)}&jobId=${item.config.id}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can useHistory and history.push() here?

...ion/data_frame_analytics/pages/analytics_management/hooks/use_create_analytics_form/state.ts Outdated
@@ -328,6 +322,14 @@ export const getJobConfigFromFormState = (
return jobConfig;
};

function getCamelCase(property: string): string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitty Nit: Maybe toCamelCase is a better name.

@pheyos
Copy link
Member

pheyos commented Jun 8, 2020 •
edited by alvarezmelissa87
Loading

I think it would be good to re-enable and adjust the functional DFA cloning tests as part of this PR (clone tests have been disabled in DFA wizard part 1 #67564).

@pheyos - They will be updated in a follow-up 👍

@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-dfanalytics-wizard-part-two branch from 60bdc72 to ffadb39 Compare June 8, 2020 13:37
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Jun 8, 2020
Closed
60 tasks
peteharverson
peteharverson approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@alvarezmelissa87
Copy link
Contributor Author

retest

@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-dfanalytics-wizard-part-two branch from 6b126ab to 75335c1 Compare June 9, 2020 18:31
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/fleet/setup·ts.apis Fleet Endpoints fleet_setup should create a fleet_enroll user and role

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/68568

[00:00:00]       │
[00:00:00]         └-: apis
[00:00:00]           └-> "before all" hook
[00:08:28]           └-: Fleet Endpoints
[00:08:28]             └-> "before all" hook
[00:09:27]             └-: fleet_setup
[00:09:27]               └-> "before all" hook
[00:09:27]               └-> should create a fleet_enroll user and role
[00:09:27]                 └-> "before each" hook: global before each
[00:09:27]                 └-> "before each" hook
[00:09:28]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591727645254168337] [.kibana_2/TOLKe6V3TBaEktO5BcN_yw] update_mapping [_doc]
[00:09:28]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591727645254168337] [.kibana_2/TOLKe6V3TBaEktO5BcN_yw] update_mapping [_doc]
[00:09:28]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591727645254168337] [.kibana_2/TOLKe6V3TBaEktO5BcN_yw] update_mapping [_doc]
[00:09:28]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591727645254168337] [.kibana_2/TOLKe6V3TBaEktO5BcN_yw] update_mapping [_doc]
[00:09:28]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591727645254168337] [.kibana_2/TOLKe6V3TBaEktO5BcN_yw] update_mapping [_doc]
[00:09:29]                 └- ✖ fail: "apis Fleet Endpoints fleet_setup should create a fleet_enroll user and role"
[00:09:29]                 │

Stack Trace

Error: expected 200 "OK", got 500 "Internal Server Error"
    at Test._assertStatus (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:268:12)
    at Test._assertFunction (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:283:11)
    at Test.assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:173:18)
    at assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:131:12)
    at /dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:128:5
    at Test.Request.callback (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/index.js:718:3)
    at parser (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/index.js:906:18)
    at IncomingMessage.res.on (/dev/shm/workspace/kibana/node_modules/superagent/lib/node/parsers/json.js:19:7)
    at endReadableNT (_stream_readable.js:1145:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

History

  • 💔 Build #52798 failed 6b126abcb8561d93f8225591bddff42a07ddb9aa
  • 💔 Build #52730 failed 6b126abcb8561d93f8225591bddff42a07ddb9aa
  • 💔 Build #52389 failed ffadb395c77a6a3b88d13e5b81da93b40a3ba9d2
  • 💔 Build #52208 failed 60bdc72b892c3e1a7d20a30c8879a9431f4afc9f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alvarezmelissa87 alvarezmelissa87 merged commit 696d71e into elastic:master Jun 9, 2020
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Jun 9, 2020
Merged
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Jun 9, 2020
@alvarezmelissa87
[ML] DF Analytics: Creation wizard part 2 (elastic#68462)
e19aacd 
* Add ability to clone job

* remove deprecated creation form code

* ensure excludes cloned correctly and update clone action jest test

* remove unused translations

* update helper function name
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfanalytics-wizard-part-two branch June 9, 2020 20:39
alvarezmelissa87 added a commit that referenced this pull request Jun 9, 2020
@alvarezmelissa87
[ML] DF Analytics: Creation wizard part 2 (#68462) (#68707)
9a695e5 
* Add ability to clone job

* remove deprecated creation form code

* ensure excludes cloned correctly and update clone action jest test

* remove unused translations

* update helper function name
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 10, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
86f7d73 
* master: (22 commits)
  Partial revert of "Sync Kerberos + Anonymous access tests with the latest `security/_authenticate` API (user roles now include roles of anonymous user)." (elastic#68624)
  adapt some snapshot test (elastic#68489)
  [APM] Service maps - Fix missing ML status for services with jobs but no anomalies (elastic#68486)
  [skip test] apis Kerberos security Kerberos authentication finishing SPNEGO should properly set cookie and authenticate user
  [SIEM][Exceptions] - ExceptionsViewer UI component part 2 (elastic#68294)
  Surface data streams in Index Management. (elastic#67806)
  Fix edit datasource not working following changes in elastic#67234 (elastic#68583)
  [Logs + Metrics UI] Clean up async plugin initialization (elastic#67654)
  APM Storybook fixes (elastic#68671)
  Upgrade EUI to v24.1.0 (elastic#68141)
  [ML] DF Analytics: Creation wizard part 2 (elastic#68462)
  [Uptime] Fix race on overview page query (elastic#67843)
  Prefer using npm_execpath when spawning Yarn (elastic#68673)
  [Security] [Cases] Attach timeline to existing case (elastic#68580)
  Use Search API in Vega (elastic#68257)
  [Component templates] Table view (elastic#68031)
  [Uptime] Added relative date info in cert status column (elastic#67612)
  [Endpoint] Re-enable Functional test case for Endpoint related pages (elastic#68445)
  run page_load_metrics tests in visual regresssion jobs (elastic#68570)
  Enable exhaustive-deps; correct any lint warnings (elastic#68453)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra walterra approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:Data Frame Analytics ML data frame analytics features :ml release_note:enhancement v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alvarezmelissa87 @elasticmachine @pheyos @kibanamachine @walterra @peteharverson