Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] change eventLog ILM requests to absolute URLs #68331

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

pmuellr
Copy link
Member

@pmuellr pmuellr commented Jun 4, 2020

resolves #68265

This changes the ILM requests made by the eventLog from relative to absolute
URLs. These requests test the existence of and create ILM policies, and are
made with a cluster client using transport.request. Relative URLs work fine
locally and in CI, however do not work on the cloud.

resolves elastic#68265

This changes the ILM requests made by the eventLog from relative to absolute
URLs.  These requests test the existence of and create ILM policies, and are
made with a cluster client using `transport.request`.  Relative URLs work fine
locally and in CI, however do not work on the cloud.
@pmuellr pmuellr requested a review from a team as a code owner June 4, 2020 23:20
@pmuellr pmuellr added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 labels Jun 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@pmuellr pmuellr added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 labels Jun 4, 2020
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@pmuellr pmuellr merged commit e57f925 into elastic:master Jun 5, 2020
pmuellr added a commit to pmuellr/kibana that referenced this pull request Jun 5, 2020
resolves elastic#68265

This changes the ILM requests made by the eventLog from relative to absolute
URLs.  These requests test the existence of and create ILM policies, and are
made with a cluster client using `transport.request`.  Relative URLs work fine
locally and in CI, however do not work on the cloud.
pmuellr added a commit to pmuellr/kibana that referenced this pull request Jun 5, 2020
resolves elastic#68265

This changes the ILM requests made by the eventLog from relative to absolute
URLs.  These requests test the existence of and create ILM policies, and are
made with a cluster client using `transport.request`.  Relative URLs work fine
locally and in CI, however do not work on the cloud.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 8, 2020
* master: (57 commits)
  Add app arch team as owner of datemath package (elastic#66880)
  [Observability] Landing page for Observability (elastic#67467)
  [SIEM] Fix timeline buildGlobalQuery (elastic#68320)
  Optimize saved objects getScopedClient and HTTP API (elastic#68221)
  [Maps] Fix mb-style interpolate style rule (elastic#68413)
  update script to always download node (elastic#68421)
  [SECURITY SOLEIL] Fix selection of event type when no siem index signal created (elastic#68291)
  [DOCS] Adds note about configuring File Data Visualizer (elastic#68407)
  [DOCS] Adds link from remote clusters to index patterns (elastic#68406)
  [QA] slack notify on failure (elastic#68126)
  upgrade eslint-plugin-react-hooks from 2.3.0 to 4.0.4 (elastic#68295)
  moving to jira to a gold license (elastic#67178)
  [DOCS] Revises doc on adding data (elastic#68038)
  [APM] Add ThemeProvider to support dark mode (elastic#68242)
  Make welcome screen disabling first action in loginIfPrompted (elastic#68238)
  [QA] Code coverage: unskip tests, collect tests results, exclude bundles from report (elastic#64477)
  [ML] Functional tests - disable flaky regression and classification creation test
  [Alerting] change eventLog ILM requests to absolute URLs (elastic#68331)
  Report page load asset size (elastic#66224)
  [SIEM][CASE] Change SIEM to Security (elastic#68365)
  ...
pmuellr added a commit that referenced this pull request Jun 9, 2020
…8391)

resolves #68265

This changes the ILM requests made by the eventLog from relative to absolute
URLs.  These requests test the existence of and create ILM policies, and are
made with a cluster client using `transport.request`.  Relative URLs work fine
locally and in CI, however do not work on the cloud.
pmuellr added a commit that referenced this pull request Jun 9, 2020
…8390)

resolves #68265

This changes the ILM requests made by the eventLog from relative to absolute
URLs.  These requests test the existence of and create ILM policies, and are
made with a cluster client using `transport.request`.  Relative URLs work fine
locally and in CI, however do not work on the cloud.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Alerting] 7.8 cloud returning 500 response for event log queries
5 participants