Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Make footer messaging sticky to bottom of page #68327

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

jen-huang
Copy link
Contributor

Summary

Resolves #68163. Make footer messaging sticky to bottom of page by making our main layout container a flexbox and wrapping header+content in a new div to avoid page width issues we had before.

image

@jen-huang jen-huang added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:beta1 labels Jun 4, 2020
@jen-huang jen-huang requested a review from a team June 4, 2020 22:18
@jen-huang jen-huang self-assigned this Jun 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jen-huang
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jen-huang jen-huang merged commit b39234c into elastic:master Jun 8, 2020
@jen-huang jen-huang deleted the ingest/fix/footer-messaging branch June 8, 2020 22:20
jen-huang added a commit to jen-huang/kibana that referenced this pull request Jun 8, 2020
jen-huang added a commit that referenced this pull request Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ingest Manager] Improve Experimental copy footer UX
4 participants