[Lens] Add description property and check duplicate title on save

[flash1293]

Fixes #64979

This PR uses the checkForDuplicateTitle helper function from the saved_objects plugin to make sure a Lens saved object is not saved with the same title as another existing saved object.

As this helper was tied to the SavedObject type (which is not used by Lens), the type had to be adjusted slightly (src/plugins/saved_objects/public/saved_object/helpers/check_for_duplicate_title.ts and src/plugins/saved_objects/public/saved_object/helpers/display_duplicate_title_confirm_modal.ts)

While working on this, I discovered there is a textarea for the description in the save modal, but Lens saved objects don't include a description at all. This PR also passes the description through the various layers so it's saved and shown correctly

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[lukeelmers]

Updated app arch typings LGTM

[wylieconlon]

Tested in Safari. LGTM, although I would be happy to have another way of organizing saved visualizations.

[wylieconlon]

This is weird, because I can definitely search the description when I type a unique string, but I think this is supposed to be:

Suggested change

	searchFields: ['title^3'],
	searchFields: ['title^3', 'description'],

[mbondyra]

@wylieconlon you got me curious about this one – I investigated a bit.

Turns out that the request doesn't use this param from here, but takes it from:
https://github.com/elastic/kibana/blob/master/src/plugins/visualizations/public/saved_visualizations/find_list_items.ts#L55

We search through both lens and visualize so I think it's good . Example of request:
http://localhost:5603/clb/api/saved_objects/_find?default_search_operator=AND&page=1&per_page=1000&search=lens_vis*&search_fields=title%5E3&search_fields=description&type=lens&type=visualization

[mbondyra]

@elasticmachine merge upstream

[mbondyra]

Tested in Safari. LGTM, although I would be happy to have another way of organizing saved visualizations.

@wylieconlon what do you have in mind?

[mbondyra]

Tested on FF, both functionality and code looks good to me 🆗

[wylieconlon]

@mbondyra There is some longer-term effort to add tagging or folders to saved objects, for example: #16484

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: e03f866

History

• 💚 Build #52676 succeeded 5def83e
• 💚 Build #51735 succeeded 59154d6
• 💔 Build #51672 failed d1f2765

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream