[Ingest Manager] Change agent config YAML view to flyout #67918
Conversation
…nfig->yaml service
jen-huang
added
v8.0.0
release_note:skip
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
| const body = configToYaml(fullAgentConfig); | ||
| const headers: ResponseHeaders = { | ||
| 'content-type': 'text/x-yaml', | ||
| 'content-disposition': `attachment; filename="elastic-agent-config-${fullAgentConfig.id}.yml"`, |
There was a problem hiding this comment.
The default config that is picked up by the agent is called elastic-agent.yml: https://github.com/elastic/beats/blob/master/x-pack/elastic-agent/elastic-agent.yml Taking this name would make it very easy to copy / paste. Having the id inside makes it nice for tracking but not sure we need it at the moment?
💚 Build SucceededTo update your PR or re-run it, just comment with: |
| : undefined | ||
| } | ||
| items={[ | ||
| <EuiContextMenuItem |
There was a problem hiding this comment.
Would you be ok if we had a URL param in the route that would trigger this flyout? Does not have to be part of this PR.
One of the integration tests I have been thinking about for Endpoint "policy" data is to ensure that data (when created/edited) lands in the right place in the YAML file, which should give us an assurance that it will make it to the Endpoint exe as intended. Having a route to get this panel would make it easier to build up that integration test.
Like I said - does not have to be part of this PR, but was wondering if you would be ok with such a change in the future when we get around to implementing that integration test 😃
There was a problem hiding this comment.
Yes, I'm ok with any url params to trigger any of our flyouts :)
|
@nchaulet I'll work on a test in a subsequent PR. |
* Consolidate context menu/row action components and usage, and some export/imports * Missed export * Move agent config yaml tab to flyout, add and consolidate agent config action menus * Fix i18n * Add download config YAML endpoint and link from flyout, add common config->yaml service * Actually remove the tab lol * Fix i18n
…8034) * Consolidate context menu/row action components and usage, and some export/imports * Missed export * Move agent config yaml tab to flyout, add and consolidate agent config action menus * Fix i18n * Add download config YAML endpoint and link from flyout, add common config->yaml service * Actually remove the tab lol * Fix i18n
Resolves #62313
Summary
This PR moves the agent config YAML tab to be a flyout instead and address some tech debt.
/api/ingest_manager/agent_configs/{agentConfigId}/downloadelastic-agent-config-{agentConfigId}.ymlScreenshots