Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up doc title when navigating away from Snapshot Restore. #67906

Merged

Conversation

cjcenizal
Copy link
Contributor

Release note

Navigating to Snapshot Restore changes the browser tab label. Now navigating away correctly changes the tab label back to "Elastic".

@cjcenizal cjcenizal added release_note:fix v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI v7.8.0 v7.9.0 labels Jun 1, 2020
@cjcenizal cjcenizal requested a review from yuliacech June 1, 2020 21:31
@cjcenizal cjcenizal requested a review from a team as a code owner June 1, 2020 21:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@yuliacech
Copy link
Contributor

Hi @cjcenizal
The changes look good to me, tested locally and the tab title is correctly reset after leaving Snapshot and Restore.

@cjcenizal
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cjcenizal cjcenizal merged commit f190fd2 into elastic:master Jun 3, 2020
@cjcenizal cjcenizal deleted the bug/snapshot-restore-doc-title-reset branch June 3, 2020 17:08
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jun 3, 2020
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jun 3, 2020
cjcenizal added a commit that referenced this pull request Jun 3, 2020
cjcenizal added a commit that referenced this pull request Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants