Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc updates for 5.0alpha #6753

Closed
wants to merge 5 commits into from
Closed

Doc updates for 5.0alpha #6753

wants to merge 5 commits into from

Conversation

palecur
Copy link

@palecur palecur commented Apr 2, 2016

Several changes throughout:

  • Images updated to match new layout and navigation UI
  • Release notes updated
  • Doc changes to support releasenoted additions (see release notes for full list), notably changed doc to match UI when terminology changed, added documentation for feature enhancements and new features
  • Some cleanup targets of opportunity

@palecur palecur mentioned this pull request Apr 2, 2016
Closed
7 tasks
@tbragin
Copy link
Contributor

tbragin commented Apr 2, 2016

@palecur do you have the docs built and posted anywhere, by chance?

@epixa epixa added the v5.0.0 label Apr 2, 2016
@palecur
Copy link
Author

palecur commented Apr 2, 2016

Rendered docs can be inspected at kibana.firebaseapp.com.

epixa
epixa reviewed Apr 4, 2016
View reviewed changes
docs/autorefresh.asciidoc

image::images/autorefresh-intervals.png[]

// Autorefresh only displays when the time picker is open, is that on purpose?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that is intentional.

@epixa
Copy link
Contributor

epixa commented Apr 4, 2016

The repositories page has {branch} in the url:
screen shot 2016-04-04 at 4 31 25 pm

@epixa
Copy link
Contributor

epixa commented Apr 4, 2016

Just updating this PR with that we talked about: @palecur is going to open another PR to the alpha1 branch with these changes. He's then going to go through this PR and add new commits that clean up some of the alpha-specific version stuff so it is master-appropriate again.

@epixa
Copy link
Contributor

epixa commented Apr 4, 2016

@palecur Go ahead and remove "Support for this functionality will be removed entirely in the next major Kibana release." from the setup.html doc. We no longer have a specific timeline to remove that feature, though it is still deprecated.

epixa
epixa reviewed Apr 4, 2016
View reviewed changes
docs/plugins.asciidoc
@@ -1,7 +1,7 @@
[[kibana-plugins]]
== Kibana Plugins added[4.2]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long do we keep this "added in previous version" stuff around? Is a major version the right time remove it?

@palecur palecur mentioned this pull request Apr 4, 2016
Merged
@palecur
Copy link
Author

palecur commented Apr 4, 2016

Should be #6777, which is in the right branch.

@palecur
Copy link
Author

palecur commented Apr 5, 2016

new doc render for master is at https://kibamaster.firebaseio.com

@epixa
Copy link
Contributor

epixa commented Apr 5, 2016

No idea what's up with this CLA checker.

@epixa
Copy link
Contributor

epixa commented Apr 5, 2016

Will it let you push directly to master?

@palecur
Copy link
Author

palecur commented Apr 5, 2016

I can probably do it from the commandline just fine, yeah

@elasticsearch-bot
Copy link

Paul Echeverri merged this into the following branches!

Branch Commits
master 800a5ab, 511124c, 9f70670, eafd79e, 265e00c

elasticsearch-bot pushed a commit that referenced this pull request Apr 5, 2016
Updates timepicker images
511124c 
Fixes #6753
elasticsearch-bot pushed a commit that referenced this pull request Apr 5, 2016
Feedback on new docs implemented
9f70670 
Fixes #6753
elasticsearch-bot pushed a commit that referenced this pull request Apr 5, 2016
Backs out 5.0.0-alpha1-specific changes
eafd79e 
Fixes #6753
elasticsearch-bot pushed a commit that referenced this pull request Apr 5, 2016
fixes bad markup
265e00c 
Fixes #6753
jbudz pushed a commit that referenced this pull request May 15, 2023
@cee-chen @kibanamachine
Upgrade EUI to v79.0.1 (#156925)
b9ea4ce 
## Summary

`[email protected]` ⏩ `[email protected]`

🦴 The primary changes in this upgrade are around the deprecated
`EuiLoadingContent` being removed in favor of `EuiSkeletonText`.
- Most instances have been a [direct swap of
usage](327626a),
but [some replacements were a bit more
opinionated](e6ceb36)
as I saw them as potential to take advantage of `EuiSkeletonText`'s
syntactical sugar and screen reader announcements for when state
switches to loaded.

---

## [`79.0.1`](https://github.com/elastic/eui/tree/v79.0.1)

**Bug fixes**

- Fixed broken push `EuiFlyout` behavior
([#6764](elastic/eui#6764))


## [`79.0.0`](https://github.com/elastic/eui/tree/v79.0.0)

- Updated all `EuiSkeleton` components with new props that allow for
more control over screen reader live announcements:
`announceLoadingStatus`, `announceLoadedStatus`, and `ariaLiveProps`
([#6752](elastic/eui#6752))
- Improved keyboard accessibility in `EuiPageHeader` by ensuring the
right side menu items come into focus from left to right.
([#6753](elastic/eui#6753))

**Breaking changes**

- Removed deprecated `EuiLoadingContent`. Use the `EuiSkeleton`
components instead. ([#6754](elastic/eui#6754))


## [`78.0.0`](https://github.com/elastic/eui/tree/v78.0.0)

- Improved the contrast ratio of `EuiCheckbox`, `EuiRadio`, and
`EuiSwitch` in their unchecked states to meet WCAG AA guidelines.
([#6729](elastic/eui#6729))
- Added React Testing Library `*ByTestSubject` custom commands to
`within()`. RTL utilities can be imported from
`@elastic/eui/lib/test/rtl`.
([#6737](elastic/eui#6737))
- Updated `EuiAvatar` to support a new letter `casing` prop that allow
customizing text capitalization
([#6739](elastic/eui#6739))
- Updated `EuiFocusTrap` to support the `gapMode` prop configuration
(now defaults to `padding`)
([#6744](elastic/eui#6744))

**Bug fixes**

- Fixed inconsistency in `EuiSearchBar`'s AND/OR semantics between DSL
and query string generation
([#6717](elastic/eui#6717))
- Fixed `EuiFieldNumber`'s native browser validity detection causing
extra unnecessary rerenders
([#6741](elastic/eui#6741))
- Fixed the `scrollLock` property on `EuiFocusTrap` (and other
components using `EuiFocusTrap`, such as `EuiFlyout` and `EuiModal`) to
no longer block scrolling on nested portalled content, such as combobox
dropdowns ([#6744](elastic/eui#6744))

**Breaking changes**

- `EuiAvatar`s with the default `user` type will now default to
capitalizing all initials in uppercase
([#6739](elastic/eui#6739))

---------

Co-authored-by: Kibana Machine <[email protected]>
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
@cee-chen @kibanamachine @jasonrhodes
Upgrade EUI to v79.0.1 (#156925)
14c8acc 
## Summary

`[email protected]` ⏩ `[email protected]`

🦴 The primary changes in this upgrade are around the deprecated
`EuiLoadingContent` being removed in favor of `EuiSkeletonText`.
- Most instances have been a [direct swap of
usage](327626a),
but [some replacements were a bit more
opinionated](e6ceb36)
as I saw them as potential to take advantage of `EuiSkeletonText`'s
syntactical sugar and screen reader announcements for when state
switches to loaded.

---

## [`79.0.1`](https://github.com/elastic/eui/tree/v79.0.1)

**Bug fixes**

- Fixed broken push `EuiFlyout` behavior
([#6764](elastic/eui#6764))


## [`79.0.0`](https://github.com/elastic/eui/tree/v79.0.0)

- Updated all `EuiSkeleton` components with new props that allow for
more control over screen reader live announcements:
`announceLoadingStatus`, `announceLoadedStatus`, and `ariaLiveProps`
([#6752](elastic/eui#6752))
- Improved keyboard accessibility in `EuiPageHeader` by ensuring the
right side menu items come into focus from left to right.
([#6753](elastic/eui#6753))

**Breaking changes**

- Removed deprecated `EuiLoadingContent`. Use the `EuiSkeleton`
components instead. ([#6754](elastic/eui#6754))


## [`78.0.0`](https://github.com/elastic/eui/tree/v78.0.0)

- Improved the contrast ratio of `EuiCheckbox`, `EuiRadio`, and
`EuiSwitch` in their unchecked states to meet WCAG AA guidelines.
([#6729](elastic/eui#6729))
- Added React Testing Library `*ByTestSubject` custom commands to
`within()`. RTL utilities can be imported from
`@elastic/eui/lib/test/rtl`.
([#6737](elastic/eui#6737))
- Updated `EuiAvatar` to support a new letter `casing` prop that allow
customizing text capitalization
([#6739](elastic/eui#6739))
- Updated `EuiFocusTrap` to support the `gapMode` prop configuration
(now defaults to `padding`)
([#6744](elastic/eui#6744))

**Bug fixes**

- Fixed inconsistency in `EuiSearchBar`'s AND/OR semantics between DSL
and query string generation
([#6717](elastic/eui#6717))
- Fixed `EuiFieldNumber`'s native browser validity detection causing
extra unnecessary rerenders
([#6741](elastic/eui#6741))
- Fixed the `scrollLock` property on `EuiFocusTrap` (and other
components using `EuiFocusTrap`, such as `EuiFlyout` and `EuiModal`) to
no longer block scrolling on nested portalled content, such as combobox
dropdowns ([#6744](elastic/eui#6744))

**Breaking changes**

- `EuiAvatar`s with the default `user` type will now default to
capitalizing all initials in uppercase
([#6739](elastic/eui#6739))

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epixa epixa

Labels
review Team:Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@palecur @tbragin @epixa @elasticsearch-bot