Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Improve a11y test when switching to context #67363

Conversation

kertal
Copy link
Member

@kertal kertal commented May 26, 2020

Summary

Seems PR #66959 didn't solve all flakiness of Discover's a11y tests, trying to switch to the context view. So I'm adding also the click to expand a row of the data table in Discover to the retry section, since the failure screens show an unexpanded table of records.

Checklist

@kertal kertal added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 labels May 26, 2020
@kertal kertal self-assigned this May 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal requested a review from spalger May 26, 2020 16:02
@spalger
Copy link
Contributor

spalger commented May 26, 2020

Would you please unskip the tests as they were skipped in #62497. We should also get some flaky test runs on this once it's updated with master/unskips.

@mistic
Copy link
Member

mistic commented May 28, 2020

@elasticmachine merge upstream

@kertal
Copy link
Member Author

kertal commented May 28, 2020

@mistic
Copy link
Member

mistic commented May 28, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants