Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Functional tests - directory names cleanup #67312

Merged
merged 3 commits into from
May 27, 2020
Merged

[ML] Functional tests - directory names cleanup #67312

merged 3 commits into from
May 27, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented May 26, 2020

Summary

This PR renames some ML and Transform functional test directories in order to make them consistent with other parts of the code.

Details

All of the following changes are made inside x-pack/test/functional/:

Functional ML test files

  • Renamed apps/machine_learning/ to apps/ml/

Functional ML services

  • Renamed services/machine_learning/ to services/ml/
  • Removed services/ml.ts
    • Content taken over to the moved services/ml/index.ts

Functional Transform services

  • Renamed services/transform_ui/ to services/transform/
  • Removed services/transform.ts
    • Content taken over to the moved services/transform/index.ts

@pheyos pheyos requested a review from a team as a code owner May 26, 2020 11:04
@pheyos pheyos self-assigned this May 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

jgowdyelastic
jgowdyelastic approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos
Copy link
Member Author

pheyos commented May 26, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

walterra
walterra approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@pheyos pheyos merged commit 4fb057f into elastic:master May 27, 2020
@pheyos pheyos deleted the directory_names_cleanup branch May 27, 2020 08:42
@pheyos pheyos mentioned this pull request May 27, 2020
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request May 27, 2020
@pheyos
[ML] Functional tests - directory names cleanup (elastic#67312)
6229d8f 
This PR renames some ML and Transform functional test directories in order to make them consistent with other parts of the code.
pheyos added a commit that referenced this pull request May 27, 2020
@pheyos
[ML] Functional tests - directory names cleanup (#67312) (#67443)
5c794ec 
This PR renames some ML and Transform functional test directories in order to make them consistent with other parts of the code.
@pheyos pheyos mentioned this pull request May 28, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@walterra walterra walterra approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@pheyos pheyos

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional test-api-integration v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pheyos @elasticmachine @kibanamachine @walterra @jgowdyelastic