Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Unskip a11y test #66959

Merged
merged 2 commits into from
May 20, 2020
Merged

[Discover] Unskip a11y test #66959

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ca2071
Improve a11y context view test
kertal May 19, 2020
eda50a2
Merge branch 'master' into kertal-pr-2020-05-19-discover-unskip-funct…
elasticmachine May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions test/accessibility/apps/discover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { FtrProviderContext } from '../ftr_provider_context';

export default function({ getService, getPageObjects }: FtrProviderContext) {
const PageObjects = getPageObjects(['common', 'discover', 'header', 'share', 'timePicker']);
const retry = getService('retry');
const a11y = getService('a11y');
const esArchiver = getService('esArchiver');
const kibanaServer = getService('kibanaServer');
Expand All @@ -33,8 +34,7 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
['geo.src', 'IN'],
];

// FLAKY: https://github.com/elastic/kibana/issues/62497
describe.skip('Discover', () => {
describe('Discover', () => {
before(async () => {
await esArchiver.load('discover');
await esArchiver.loadIfNeeded('logstash_functional');
Expand Down Expand Up @@ -133,7 +133,14 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
// Context view test
it('should open context view on a doc', async () => {
await docTable.clickRowToggle();
await (await docTable.getRowActions())[0].click();
// click the open action
await retry.try(async () => {
const rowActions = await docTable.getRowActions();
if (!rowActions.length) {
throw new Error('row actions empty, trying again');
}
await rowActions[0].click();
});
await a11y.testAppSnapshot();
});

Expand Down