-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics UI] Add support for multiple groupings to Metrics Explorer (and Alerts) #66503
[Metrics UI] Add support for multiple groupings to Metrics Explorer (and Alerts) #66503
Conversation
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
4bd0684
to
483a394
Compare
483a394
to
de390dd
Compare
…ultiple-group-bys
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx
Outdated
Show resolved
Hide resolved
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
…and Alerts) (elastic#66503) * [Metrics UI] Adding support for multiple groupings to Metrics Explorer * Adding keys to title parts * removing commented line Co-authored-by: Elastic Machine <[email protected]>
…and Alerts) (#66503) (#67065) * [Metrics UI] Adding support for multiple groupings to Metrics Explorer * Adding keys to title parts * removing commented line Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
* master: (33 commits) [Saved Objects] adds support for including hidden types in saved objects client (elastic#66879) [Discover] Deangularize timechart header (elastic#66532) [Discover] Improve and unskip a11y context view test (elastic#66959) [SIEM] Refactor Timeline.timelineType draft to Timeline.status draft (elastic#66864) docs: update RUM documentation link (elastic#67042) [QA] fixup coverage ingestion tests. (elastic#66905) [Metrics UI] Add support for multiple groupings to Metrics Explorer (and Alerts) (elastic#66503) [Metrics UI] Add sorting for name and value to Inventory View (elastic#66644) [Metrics UI] Change Metric Threshold Alert charts to use bar charts (elastic#66672) [Uptime] Use React.lazy for alert type registration (elastic#66829) [Reporting] Consolidate API Integration Test configs (elastic#66637) Allow histogram fields in average and sum aggregations (elastic#66891) Fix saved object share link (elastic#66771) move role reset into the top level after clause (elastic#66971) Automate the labels for any PRs affecting files for the Ingest Management team (elastic#67022) [SIEMDPOINT] Move endpoint to siem (elastic#66907) server.uuid so is not used (elastic#66963) Revert "[ci/stats] fix git metadata collection (elastic#66840)" [Uptime] Unmount uptime app properly (elastic#66950) [Visualize] Bar chart: Show missing values on chart setting (elastic#66375) ...
closes: #65119 |
not sure if the problem is misconfiguration or perhaps a cache problem, but since upgrading when i visualize the wrong graphs i get the correct results. I can open a separate ticket if required - not sure exactly what is wrong, but seems as though it is showing the max value of all charts on all charts - but only from the point at which i upgraded elastic stack and indexes. |
Summary
This PR closed 65127 by adding multiple groupings to Metrics Explorer. This also adds multiple groupings support to the Metric Threshold Alerts.
Multiple Groupings in Metrics Explorer
Multiple Groupings in Metric Threshold Alerts
Testing Checklist
average of system.filesystem.used.pct
grouped byhost.name
andsystem.filesystem.device_name
master
. Check out this PR, restart Kibana, and load the saved view to ensure it still works.master
. Check out this PR, restart Kibana, ensure the alert still fires successfully.Checklist
Delete any items that are not applicable to this PR.