Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] Add support for multiple groupings to Metrics Explorer (and Alerts) #66503

Merged

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented May 13, 2020

Summary

This PR closed 65127 by adding multiple groupings to Metrics Explorer. This also adds multiple groupings support to the Metric Threshold Alerts.

Multiple Groupings in Metrics Explorer

image

Multiple Groupings in Metric Threshold Alerts

image

Testing Checklist

  • Visualize average of system.filesystem.used.pct grouped by host.name and system.filesystem.device_name
  • Create an alert that uses multiple groupings
  • Open a chart in Visualize to ensure the filters are set correctly
  • Create a saved view using the code in master. Check out this PR, restart Kibana, and load the saved view to ensure it still works.
  • Create an alert using the code from master. Check out this PR, restart Kibana, ensure the alert still fires successfully.

Checklist

Delete any items that are not applicable to this PR.

@simianhacker simianhacker added release_note:enhancement Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 labels May 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@simianhacker simianhacker force-pushed the issue-65127-multiple-group-bys branch from 4bd0684 to 483a394 Compare May 14, 2020 15:01
@simianhacker simianhacker force-pushed the issue-65127-multiple-group-bys branch from 483a394 to de390dd Compare May 14, 2020 15:02
@simianhacker simianhacker marked this pull request as ready for review May 14, 2020 17:53
@simianhacker simianhacker requested a review from a team as a code owner May 14, 2020 17:53
@simianhacker
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker merged commit 59ae529 into elastic:master May 19, 2020
simianhacker added a commit to simianhacker/kibana that referenced this pull request May 19, 2020
…and Alerts) (elastic#66503)

* [Metrics UI] Adding support for multiple groupings to Metrics Explorer

* Adding keys to title parts

* removing commented line

Co-authored-by: Elastic Machine <[email protected]>
simianhacker added a commit that referenced this pull request May 19, 2020
…and Alerts) (#66503) (#67065)

* [Metrics UI] Adding support for multiple groupings to Metrics Explorer

* Adding keys to title parts

* removing commented line

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 20, 2020
* master: (33 commits)
  [Saved Objects] adds support for including hidden types in saved objects client (elastic#66879)
  [Discover] Deangularize timechart header (elastic#66532)
  [Discover] Improve and unskip a11y context view test (elastic#66959)
  [SIEM] Refactor Timeline.timelineType draft to Timeline.status draft (elastic#66864)
  docs: update RUM documentation link (elastic#67042)
  [QA] fixup coverage ingestion tests. (elastic#66905)
  [Metrics UI] Add support for multiple groupings to Metrics Explorer (and Alerts) (elastic#66503)
  [Metrics UI] Add sorting for name and value to Inventory View (elastic#66644)
  [Metrics UI] Change Metric Threshold Alert charts to use bar charts (elastic#66672)
  [Uptime] Use React.lazy for alert type registration (elastic#66829)
  [Reporting] Consolidate API Integration Test configs (elastic#66637)
  Allow histogram fields in average and sum aggregations (elastic#66891)
  Fix saved object share link (elastic#66771)
  move role reset into the top level after clause (elastic#66971)
  Automate the labels for any PRs affecting files for the Ingest Management team (elastic#67022)
  [SIEMDPOINT] Move endpoint to siem (elastic#66907)
  server.uuid so is not used (elastic#66963)
  Revert "[ci/stats] fix git metadata collection (elastic#66840)"
  [Uptime] Unmount uptime app properly (elastic#66950)
  [Visualize] Bar chart: Show missing values on chart setting (elastic#66375)
  ...
@sorantis
Copy link

sorantis commented May 26, 2020

closes: #65119

@phlax
Copy link

phlax commented Jun 23, 2020

not sure if the problem is misconfiguration or perhaps a cache problem, but since upgrading 7.8 to 7.9 i am getting wierd/incorrect results in metric explorer when separating eg by agent.name or agent.hostname

when i visualize the wrong graphs i get the correct results.

I can open a separate ticket if required - not sure exactly what is wrong, but seems as though it is showing the max value of all charts on all charts - but only from the point at which i upgraded elastic stack and indexes.

@simianhacker simianhacker deleted the issue-65127-multiple-group-bys branch April 17, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants