Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualize] Bar chart: Show missing values on chart setting #66375

Merged
merged 7 commits into from
May 19, 2020
Merged

[Visualize] Bar chart: Show missing values on chart setting #66375

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4aecde4
Show missing switch button
sulemanof May 13, 2020
1440f06
Merge remote-tracking branch 'upstream/master' into fix/bar_chart_values
sulemanof May 14, 2020
6fce690
Merge remote-tracking branch 'upstream/master' into fix/bar_chart_values
sulemanof May 18, 2020
dcc5a86
Merge branch 'master' into fix/bar_chart_values
elasticmachine May 19, 2020
98dc1b1
Add functional tests
sulemanof May 19, 2020
6be3720
Merge remote-tracking branch 'upstream/master' into fix/bar_chart_values
sulemanof May 19, 2020
36faac5
Merge branch 'fix/bar_chart_values' of github.com:sulemanof/kibana in…
sulemanof May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/plugins/vis_type_vislib/public/components/options/point_series/point_series.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import { BasicOptions, SwitchOption } from '../../../../../charts/public';
import { GridPanel } from './grid_panel';
import { ThresholdPanel } from './threshold_panel';
import { BasicVislibParams } from '../../../types';
import { ChartTypes } from '../../../utils/collections';

function PointSeriesOptions(props: ValidationVisOptionsProps<BasicVislibParams>) {
const { stateParams, setValue, vis } = props;
Expand Down Expand Up @@ -67,7 +68,7 @@ function PointSeriesOptions(props: ValidationVisOptionsProps<BasicVislibParams>)
/>
)}

{vis.type.type === 'histogram' && (
{vis.type.name === ChartTypes.HISTOGRAM && (
<SwitchOption
label={i18n.translate('visTypeVislib.editors.pointSeries.showLabels', {
defaultMessage: 'Show values on chart',
Expand Down