Improve dashboard loading error handling #66372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majagrubic
reviewed
May 13, 2020
| @@ -230,7 +222,9 @@ export function initDashboardApp(app, deps) { | |||
| ); | |||
| return new Promise(() => {}); | |||
| } else { | |||
| throw error; | |||
| // E.g. a corrupt dashboard was detected (e.g. with invalid JSON properties) | |||
There was a problem hiding this comment.
I'm just wondering if there are any implications of eliminating throwing an error here.
There was a problem hiding this comment.
The error we were discussing was throw this way, and that's why we got an empty dashboard. By changing this, the user is redirected to the listing page, and an error message is displayed. Of course we've to check for a case that requires an error thrown this way, but I do think this is legacy
majagrubic
approved these changes
May 13, 2020
|
Jenkins, test this |
…-13-dashboard-show-error-message-when-invalid-saved-object-was-loaded
…-13-dashboard-show-error-message-when-invalid-saved-object-was-loaded
kertal
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
May 15, 2020
kertal
added a commit
to kertal/kibana
that referenced
this pull request
May 15, 2020
* Improve dashboard loading error handling, prevent a white screen without error msg * Remove redirectWhenMissing, since it's not needed anymore
kertal
added a commit
to kertal/kibana
that referenced
this pull request
May 15, 2020
* Improve dashboard loading error handling, prevent a white screen without error msg * Remove redirectWhenMissing, since it's not needed anymore # Conflicts: # src/plugins/dashboard/public/application/legacy_app.js
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 15, 2020
…ent/add-support-in-url-for-hidden-toggle * 'master' of github.com:elastic/kibana: (34 commits) [SIEM][CASE] Fix bug when connector is deleted. (elastic#65876) [SIEM][CASE] Improve layout (elastic#66232) [Index Management] Support Hidden Indices (elastic#66422) Add Login Selector functional tests. (elastic#65705) Lens drilldowns (elastic#65675) [ML] Custom template for apiDoc markdown (elastic#66567) Don't bootstrap core type emits (elastic#66377) [Dashboard] Improve loading error handling (elastic#66372) [APM] Minor style fixes for the node strokes (elastic#66574) [Ingest Manager] Fix create data source from integration (elastic#66626) [Metrics UI] Fix default metric alert interval for new conditions (elastic#66610) [Metrics UI] Fix alignment and allow clearing metric value (elastic#66589) Don't return package name for non-package data streams (elastic#66606) [Ingest Manager] Consolidate routing and add breadcrumbs to all pages (elastic#66475) [Docs/Reporting] Have the docs about granular timeout match Cloud docs (elastic#66267) Don't automatically add license header to code inside plugins dir. (elastic#66601) [APM] Don't trigger map layout if no elements (elastic#66625) [Logs UI] Validate ML job setup time ranges (elastic#66426) Fix pagination bugs in CCR and Remote Clusters (elastic#65931) Add cloud icon for supported settings and embed single-sourced getting started (elastic#65610) ... # Conflicts: # x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js # x-pack/plugins/index_management/server/lib/fetch_indices.ts
kertal
added a commit
that referenced
this pull request
May 15, 2020
kertal
added a commit
that referenced
this pull request
May 15, 2020
kertal
deleted the
kertal-pr-2020-05-13-dashboard-show-error-message-when-invalid-saved-object-was-loaded
branch
|
Try to open the Dashboard with Firefox. I have a large amount of data, and I have visualized 8 tables. This method works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An invalid dashboard with another error reason than
InvalidJSONPropertyled to an empty screen in Kibana. This PR takes care of this case, so the user is redirected to the dashboards list view and an error message is displayed:Before this PR, the following screen was displayed
Here's an invalid dashboard that can be used for testing:
invalid_dashboard.ndjson.zip