Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prefer_v2_templates query string parameter #66316

Merged

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented May 12, 2020

?prefer_v2_templates is no longer an accepted query parameter. V2 templates are now preferred by default.

elastic/elasticsearch#56546

prefer_v2_templates is no longer an accepted query parameter. V2
templates are now preferred by default.

Signed-off-by: Tyler Smalley <[email protected]>
@tylersmalley tylersmalley added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels May 12, 2020
@tylersmalley tylersmalley requested review from a team as code owners May 12, 2020 21:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley tylersmalley changed the title Remove prefer v2 templates Remove prefer v2 templates query parameter May 12, 2020
@tylersmalley tylersmalley changed the title Remove prefer v2 templates query parameter Remove prefer_v2_templates query string parameter May 12, 2020
@tylersmalley tylersmalley force-pushed the remove_prefer_v2_templates branch from 2c2f6b3 to d13dbe8 Compare May 12, 2020 23:52
@tylersmalley
Copy link
Contributor Author

Previous success was testing with the current unverified snapshot.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💚 Build #47495 succeeded 2c2f6b3361464a436bc6d493b3f7c57953f217f7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley merged commit 3cbb849 into elastic:master May 13, 2020
@tylersmalley
Copy link
Contributor Author

Merging prior to CODEOWNERS review as this is blocking the promotion of the ES snapshots. Please raise any concerns if there are any.

tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request May 13, 2020
prefer_v2_templates is no longer an accepted query parameter. V2 templates are now preferred by default.

Signed-off-by: Tyler Smalley <[email protected]>
# Conflicts:
#	x-pack/test/functional/es_archives/endpoint/resolver_tree/api_feature/mappings.json
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request May 13, 2020
prefer_v2_templates is no longer an accepted query parameter. V2 templates are now preferred by default.

Signed-off-by: Tyler Smalley <[email protected]>
# Conflicts:
#	x-pack/test/functional/es_archives/endpoint/resolver_tree/api_feature/mappings.json
v1v added a commit to v1v/kibana that referenced this pull request May 13, 2020
* upstream/master: (223 commits)
  [Ingest] Support root level yaml variables in agent stream template (elastic#66120)
  [Snapshot Restore] Fix error when deleting snapshots behind reverse proxy (elastic#66147)
  [Lens] fix empty state for pie (elastic#66206)
  [APM] Improve e2e tests (elastic#66373)
  [ML] Data Frame Analytics: Fix steps to be named phases. (elastic#65855)
  [Discover] Encode context link filter part (elastic#63831)
  [APM] Scope APM alert creation to environment (elastic#65681)
  Move Kibana Usage collectors outside the telemetry plugin (elastic#65663)
  [ML] Data Frame Analytics: Fix confusion matrix data grid width. (elastic#65818)
  Switch to core application service (elastic#63443)
  Removes use of prefer_v2_templates (elastic#66316)
  [Maps] handle case where fit to bounds does not match any documents (elastic#66307)
  log error instead of throw (elastic#66254)
  [plugin-helpers] remove outdated postinstall task (elastic#66324)
  Spaces - migrate default space and enter space view to KP (elastic#66098)
  [APM] Change plugin id for `apm_oss` to `apmOss` (elastic#66164)
  [Maps] convert map_selectors to TS (elastic#65905)
  [uptime/usage-collector] add missing await (elastic#66079)
  [Ingest] Add additional attributes to the Datasources Saved Object (elastic#66127)
  [Endpoint]EMT-339: add new policy response schema (elastic#66264)
  ...
tylersmalley pushed a commit that referenced this pull request May 13, 2020
prefer_v2_templates is no longer an accepted query parameter. V2 templates are now preferred by default.

Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley pushed a commit that referenced this pull request May 13, 2020
prefer_v2_templates is no longer an accepted query parameter. V2 templates are now preferred by default.

Signed-off-by: Tyler Smalley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants