use individual route for each KP app #65977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
Feature:New Platform
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
pgayvallet
added
v7.9.0
v8.0.0
release_note:skip
joshdover
approved these changes
May 11, 2020
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
May 13, 2020
* use individual route for each KP app * cleanup
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
that referenced
this pull request
May 13, 2020
This was referenced Jun 2, 2020
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Jun 3, 2020
* use individual route for each KP app * cleanup
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Jun 3, 2020
* use individual route for each KP app * cleanup # Conflicts: # src/core/public/application/ui/app_container.test.tsx # src/core/public/application/ui/app_router.tsx
pgayvallet
added a commit
that referenced
this pull request
Jun 3, 2020
pgayvallet
added a commit
that referenced
this pull request
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #59190
<Route>for each KP app instead of relying on the/app/appIdcatch-all route to remove the distinction between apps having a custom appRoute and the others.appRoutenot being properly handled when kibana was using an empty basePath and when the custom route was prefixed by/app/{id}/This will also ease legacy cleanup as we should be able to just remove the catch-all handler and use a 'dumb' default 404 route/component instead.
Checklist