Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed viz tests to leave all visualizations. New dashboard tests. #6576

Closed
wants to merge 2 commits into from

Conversation

LeeDr
Copy link

@LeeDr LeeDr commented Mar 18, 2016

Prior to this change, each visualization test started by loading an empty kibana index. Now that only happens in once for all visualize tests in the before method of /test/apps/visualize/index.js.
This saves the time to create the default index pattern each time so the whole test run is faster.
This also leaves the saved visualizations so they can be used in the dashboard tests.
Yes, I know that makes the dashboard tests dependent on the visualization tests. But I think there's some advantage to using visualizations that were created in this version vs. loading a previously saved kibana index with saved visualizations (that could be an upgrade test).

Still TODO: Check Save Time checkbox on saving dashboard and then verify it.

LeeDr added 2 commits March 18, 2016 10:59
revert accidental commit for port changes
@LeeDr LeeDr added the test label Mar 18, 2016
@LeeDr
Copy link
Author

LeeDr commented Mar 18, 2016

@acs FYI, this isn't quite ready for review yet, but there are passing dashboard tests that add multiple visualizations, save the dashboard, get the titles of all the panels, check the location attributes, etc.
You could look through them, try running them, ask questions here, etc.
I started working on a resize method for a visualization on a dashboard but haven't gotten that working yet.

@LeeDr LeeDr closed this May 20, 2016
@LeeDr LeeDr deleted the dashboard branch May 20, 2016 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant