Changed viz tests to leave all visualizations. New dashboard tests. #6576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, each visualization test started by loading an empty kibana index. Now that only happens in once for all visualize tests in the before method of /test/apps/visualize/index.js.
This saves the time to create the default index pattern each time so the whole test run is faster.
This also leaves the saved visualizations so they can be used in the dashboard tests.
Yes, I know that makes the dashboard tests dependent on the visualization tests. But I think there's some advantage to using visualizations that were created in this version vs. loading a previously saved kibana index with saved visualizations (that could be an upgrade test).
Still TODO: Check Save Time checkbox on saving dashboard and then verify it.