don't register any features in LP. #65611
Conversation
mshustov
added
chore
Team:Core
|
Pinging @elastic/kibana-gis (Team:Geo) |
|
Pinging @elastic/kibana-platform (Team:Platform) |
| } | ||
|
|
||
| class NamespaceAgnosticTypePlugin implements Plugin { | ||
| setup(core: CoreSetup, plugins: SetupDeps) { |
There was a problem hiding this comment.
@elastic/kibana-platform that's another big thing to get rid of LP: to make all tests KP-compatible. we should have done it as a part of the plugin migration effort 😅
There was a problem hiding this comment.
I agree. Even if they are small, there is a lot of test legacy plugins we will still need to migrate to get rid of legacy...
| } | ||
|
|
||
| class NamespaceAgnosticTypePlugin implements Plugin { | ||
| setup(core: CoreSetup, plugins: SetupDeps) { |
There was a problem hiding this comment.
I agree. Even if they are small, there is a lot of test legacy plugins we will still need to migrate to get rid of legacy...
| type: string; | ||
| ignore_above?: number; |
There was a problem hiding this comment.
This seems to be only used in a test plugin and could probably be removed from the mapping instead (even if I did not try to launch the test suite with the mapping modified). But I guess it doesn't hurt to still add it.
| const { registerFeature, getFeatures } = server.newPlatform.setup.plugins.features; | ||
| server.expose('registerFeature', registerFeature); | ||
| const { getFeatures } = server.newPlatform.setup.plugins.features; | ||
| server.expose('getFeatures', getFeatures); |
There was a problem hiding this comment.
Are 3rd party plugins meant to be used with a licensed version of Kibana supposed to be able to use x-pack features/apis?
If so, should we add a dev doc or anything to warn that registerFeature is no longer usable from legacy plugins?
There was a problem hiding this comment.
ok, I will do. just in case
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* don't register any features in LP. breaks features value reading in KP * move test plugin to NP * fix mappings * update docs * migrate another test * use contstants file for BWC with original code Co-authored-by: Elastic Machine <[email protected]>
* don't register any features in LP. breaks features value reading in KP * move test plugin to NP * fix mappings * update docs * migrate another test * use contstants file for BWC with original code Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Summary
Fixes #65461
It blocks security plugin migration. A list of features is locked on the first reading, which means that maps LP plugin cannot register a feature after the Security plugin reads the value in KP.