[Lens] Use rules of hooks with linting #65593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wylieconlon
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
commented
May 6, 2020
| @@ -127,7 +127,7 @@ export function BucketNestingEditor({ | |||
| defaultMessage: 'Entire data set', | |||
| }), | |||
| }, | |||
| ...aggColumns, | |||
| ...aggColumns.map(({ value, text }) => ({ value, text })), | |||
There was a problem hiding this comment.
This actually fixes a console error that @cchaos found, it's not directly related
💚 Build SucceededTo update your PR or re-run it, just comment with: |
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
May 7, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 7, 2020
* master: [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494) [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595) [Lens] Use rules of hooks with linting (elastic#65593) [ML] Migrate server side Mocha tests to Jest. (elastic#65651) Fixes the client to setup SSL with the CA certificates for testing (elastic#65598) reduce uptime plugin initial bundle size (elastic#65257) [ML] Consolidating shared types and util functions (elastic#65247) [Drilldowns] Preserve state when selecting different action factory (elastic#65074) Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 7, 2020
…ponents * alerting/lazy-load-actions: align and style loading indicator [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494) [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595) [Lens] Use rules of hooks with linting (elastic#65593) [ML] Migrate server side Mocha tests to Jest. (elastic#65651) Fixes the client to setup SSL with the CA certificates for testing (elastic#65598) reduce uptime plugin initial bundle size (elastic#65257) [ML] Consolidating shared types and util functions (elastic#65247) [Drilldowns] Preserve state when selecting different action factory (elastic#65074) Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491)
wylieconlon
pushed a commit
that referenced
this pull request
May 7, 2020
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lens has been breaking one of the rules of hooks, which is that all hooks must execute in each render cycle. This change enables the linting rule and moves some hook registration code and conditional logic to account for this.
Related to #49564