-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[services/remote] set download folder with auto-saving #65476
Merged
dmlemeshko
merged 5 commits into
elastic:master
from
dmlemeshko:ftr/set-browser-download-folder
May 6, 2020
Merged
[services/remote] set download folder with auto-saving #65476
dmlemeshko
merged 5 commits into
elastic:master
from
dmlemeshko:ftr/set-browser-download-folder
May 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
added
v7.8.0
v8.0.0
v7.7.1
release_note:skip
Skip the PR/issue when compiling release notes
Feature:Functional Testing
labels
May 6, 2020
1 task
spalger
approved these changes
May 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couple nits.
Co-authored-by: Spencer <[email protected]>
…ko/kibana into ftr/set-browser-download-folder
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
May 6, 2020
* [services/remote] set download folder with auto-saving * Update test/functional/services/remote/webdriver.ts * use REPO_ROOT per review suggestion
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
May 6, 2020
* [services/remote] set download folder with auto-saving * Update test/functional/services/remote/webdriver.ts * use REPO_ROOT per review suggestion
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
May 6, 2020
* [services/remote] set download folder with auto-saving * Update test/functional/services/remote/webdriver.ts * use REPO_ROOT per review suggestion
dmlemeshko
added a commit
that referenced
this pull request
May 6, 2020
dmlemeshko
added a commit
that referenced
this pull request
May 6, 2020
dmlemeshko
added a commit
that referenced
this pull request
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Functional Testing
release_note:skip
Skip the PR/issue when compiling release notes
v7.7.1
v7.8.0
v7.9.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR sets Chome browser preferences (Edge and Firefox as well) the way files are downloaded automatically in
/target/functional-tests/downloads
path.I know that there is a plan to add reporting tests that will download CSV
Tested on MacOS 10.14.6 Chrome 81, Edge 81, Firefox 75 (all with head)