Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[services/remote] set download folder with auto-saving #65476

Merged

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented May 6, 2020

Summary

This PR sets Chome browser preferences (Edge and Firefox as well) the way files are downloaded automatically in /target/functional-tests/downloads path.

I know that there is a plan to add reporting tests that will download CSV

kibana 2020-05-06 13-30-51

Tested on MacOS 10.14.6 Chrome 81, Edge 81, Firefox 75 (all with head)

@dmlemeshko dmlemeshko marked this pull request as ready for review May 6, 2020 15:24
@dmlemeshko dmlemeshko requested a review from spalger May 6, 2020 15:24
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple nits.

test/functional/services/remote/webdriver.ts Outdated Show resolved Hide resolved
test/functional/services/remote/webdriver.ts Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko merged commit 38c26ff into elastic:master May 6, 2020
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request May 6, 2020
* [services/remote] set download folder with auto-saving

* Update test/functional/services/remote/webdriver.ts

* use REPO_ROOT per review suggestion
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request May 6, 2020
* [services/remote] set download folder with auto-saving

* Update test/functional/services/remote/webdriver.ts

* use REPO_ROOT per review suggestion
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request May 6, 2020
* [services/remote] set download folder with auto-saving

* Update test/functional/services/remote/webdriver.ts

* use REPO_ROOT per review suggestion
dmlemeshko added a commit that referenced this pull request May 6, 2020
* [services/remote] set download folder with auto-saving

* Update test/functional/services/remote/webdriver.ts

* use REPO_ROOT per review suggestion
dmlemeshko added a commit that referenced this pull request May 6, 2020
* [services/remote] set download folder with auto-saving

* Update test/functional/services/remote/webdriver.ts

* use REPO_ROOT per review suggestion
dmlemeshko added a commit that referenced this pull request May 6, 2020
* [services/remote] set download folder with auto-saving

* Update test/functional/services/remote/webdriver.ts

* use REPO_ROOT per review suggestion
@dmlemeshko dmlemeshko deleted the ftr/set-browser-download-folder branch January 31, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants