-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM] Import timeline fix #65448
Merged
Merged
[SIEM] Import timeline fix #65448
Changes from 85 commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
67e7406
fix import timeline and clean up
angorayc f30c970
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc f5893e5
add unit tests
angorayc 9ee6cc0
clean up common libs
angorayc 1668031
rename variables
angorayc 6aff660
add unit tests
angorayc 10880fa
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc 2b8a694
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc d69bfb5
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc c49b7d4
fix types
angorayc 09b03e0
Merge branch 'master' of github.com:elastic/kibana into import-timeli…
patrykkopycinski 18f98a8
Fix imports
patrykkopycinski af21224
rename file
angorayc 5cf93cd
poc
patrykkopycinski 2ec6f0c
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc e76d860
fix unit test
angorayc e6263f3
review
angorayc 11b5599
Merge branch 'master' of github.com:elastic/kibana into import-timeli…
patrykkopycinski 98160b9
cleanup fallback values
patrykkopycinski a3ef3e4
cleanup
patrykkopycinski 90658bb
check if title exists
angorayc 826fcb8
Merge branch 'import-timeline-fix' of github.com:angorayc/kibana into…
angorayc 330fe75
fix unit test
angorayc 71e66da
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc 4872d9b
add unit test
angorayc 132b538
lint error
angorayc 3d9ea8f
put the flag for disableTemplate into common
angorayc 06ceb29
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc 073ff08
add immutiable
angorayc adc0c76
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc a87ad1c
fix unit
angorayc 5293e32
check templateTimelineVersion only when update via import
angorayc f84b540
update template timeline via import with response
XavierM 017846c
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc 7039cd9
add template filter
angorayc fe2525e
add filter count
angorayc d5a62e3
add filter numbers
angorayc e296a2a
rename
angorayc 75f3d46
enable pin events and note under active status
angorayc c151765
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc 72d8b03
disable comment and pinnedEvents for template timelines
angorayc 427e8f7
add timelineType for openTimeline
angorayc 98e4376
enable note icon for template
angorayc 333c47e
add timeline type for propertyLeft
angorayc 5c68f19
fix types
angorayc 3b97fae
duplicate elastic template
angorayc 0f81b33
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc 83d37bc
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc 3dae9a9
update schema
angorayc ae4bcc1
Merge branch 'master' of github.com:elastic/kibana into import-timeli…
angorayc 64404ed
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc 9126d58
fix status check
angorayc be5665c
fix import
angorayc cae2e69
add templateTimelineType
angorayc 67b525d
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc 0d61f94
disable note for immutable timeline
angorayc 0020c39
fix unit
angorayc a8b8fce
fix error message
angorayc 3063fb3
fix update
angorayc fc6511a
fix types
angorayc 2662c96
rollback change
angorayc 77378d3
rollback change
angorayc 3e788b9
fix create template timeline
angorayc f29afc3
add i18n for error message
angorayc d84a57a
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc 0bd39d2
fix unit test
angorayc acd2477
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc aea522e
fix wording and disable delete btn for immutable timeline
angorayc 8ff5593
fix unit test provider
angorayc f9b961f
fix types
angorayc bdf62d6
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc 200aacc
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc 1d1791f
fix toaster
angorayc 1fd2639
fix notes and pins
angorayc 51455e6
add i18n
angorayc 0ad6538
fix selected items
angorayc 82cc49c
set disableTemplateto true
angorayc 635a6e5
move templateInfo to helper
angorayc 07222f2
Merge branch 'master' of github.com:elastic/kibana into pr/65448
XavierM f5c68e2
review + imporvement
XavierM 94f2a7d
fix review
angorayc cd0bde5
fix types
angorayc c1127aa
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc 005c8d4
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc c917ce8
fix types
angorayc 0e3003d
Merge branch 'master' of github.com:elastic/kibana into import-timeli…
patrykkopycinski 71aeed2
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc 3db3ffc
Merge branch 'import-timeline-fix' of github.com:angorayc/kibana into…
angorayc fed80c3
Merge remote-tracking branch 'upstream/master' into import-timeline-fix
angorayc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we still need the flag. Maybe, we can create another PR later on to remove this flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, in another PR sounds good.