Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Reformats settings tables #64844

Merged
merged 4 commits into from
May 4, 2020
Merged

[DOCS] Reformats settings tables #64844

merged 4 commits into from
May 4, 2020

Conversation

KOTungseth
Copy link
Contributor

Summary

This PR:

  • Reformats the settings definition lists into tables.
  • Corrected some minor grammatical errors.

Checklist

  • Documentation was added for features that require explanation or tutorials

@KOTungseth KOTungseth added Team:Docs release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v7.7.0 v7.6.0 v7.8.0 labels Apr 29, 2020
@KOTungseth KOTungseth requested a review from gchaps April 29, 2020 21:37
@KOTungseth KOTungseth self-assigned this Apr 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@gchaps
Copy link
Contributor

gchaps commented Apr 30, 2020

Overall, I like the looks of this. The APM doc looks really nice.

Where it doesn't look as good is where the setting names are really long (as in Reporting) or when there are separate tables with different column widths (Alerts and ML). However, I don't have a suggestion to get around this.

i18n settings needs the new treatment.

gchaps
gchaps approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KOTungseth KOTungseth merged commit 3ba268d into elastic:master May 4, 2020
@KOTungseth KOTungseth deleted the docs/settings/tables branch May 4, 2020 15:22
@KOTungseth KOTungseth mentioned this pull request May 4, 2020
Merged
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request May 4, 2020
@KOTungseth
[DOCS] Reformats settings tables (elastic#64844)
97fcfdf 
* Formats settings into tables

* Formatting

* Formatting
# Conflicts:
#	docs/settings/general-infra-logs-ui-settings.asciidoc
#	docs/settings/telemetry-settings.asciidoc
#	docs/setup/settings.asciidoc
@KOTungseth KOTungseth mentioned this pull request May 4, 2020
Merged
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request May 4, 2020
@KOTungseth
[DOCS] Reformats settings tables (elastic#64844)
fa7d995 
* Formats settings into tables

* Formatting

* Formatting
# Conflicts:
#	docs/settings/general-infra-logs-ui-settings.asciidoc
#	docs/settings/ml-settings.asciidoc
#	docs/settings/telemetry-settings.asciidoc
#	docs/setup/settings.asciidoc
@KOTungseth KOTungseth mentioned this pull request May 4, 2020
Merged
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request May 4, 2020
@KOTungseth
[DOCS] Reformats settings tables (elastic#64844)
e251b20 
* Formats settings into tables

* Formatting

* Formatting
# Conflicts:
#	docs/settings/alert-action-settings.asciidoc
#	docs/settings/apm-settings.asciidoc
#	docs/settings/general-infra-logs-ui-settings.asciidoc
#	docs/settings/ml-settings.asciidoc
#	docs/settings/monitoring-settings.asciidoc
#	docs/settings/reporting-settings.asciidoc
#	docs/settings/telemetry-settings.asciidoc
#	docs/setup/settings.asciidoc
KOTungseth added a commit that referenced this pull request May 4, 2020
@KOTungseth
[DOCS] Reformats settings tables (#64844) (#65094)
4cdd065 
* Formats settings into tables

* Formatting

* Formatting
# Conflicts:
#	docs/settings/general-infra-logs-ui-settings.asciidoc
#	docs/settings/telemetry-settings.asciidoc
#	docs/setup/settings.asciidoc
KOTungseth added a commit that referenced this pull request May 4, 2020
@KOTungseth
[DOCS] Reformats settings tables (#64844) (#65096)
b45ddd2 
* Formats settings into tables

* Formatting

* Formatting
# Conflicts:
#	docs/settings/general-infra-logs-ui-settings.asciidoc
#	docs/settings/ml-settings.asciidoc
#	docs/settings/telemetry-settings.asciidoc
#	docs/setup/settings.asciidoc
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 6, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

KOTungseth added a commit to KOTungseth/kibana that referenced this pull request May 7, 2020
@KOTungseth
[DOCS] Reformats settings tables (elastic#64844)
e10bd9e 
* Formats settings into tables

* Formatting

* Formatting
# Conflicts:
#	docs/settings/alert-action-settings.asciidoc
#	docs/settings/apm-settings.asciidoc
#	docs/settings/general-infra-logs-ui-settings.asciidoc
#	docs/settings/ml-settings.asciidoc
#	docs/settings/monitoring-settings.asciidoc
#	docs/settings/reporting-settings.asciidoc
#	docs/settings/security-settings.asciidoc
#	docs/settings/telemetry-settings.asciidoc
#	docs/setup/settings.asciidoc
@KOTungseth KOTungseth mentioned this pull request May 7, 2020
Merged
KOTungseth added a commit that referenced this pull request May 7, 2020
@KOTungseth
[DOCS] Reformats settings tables (#64844) (#65097)
b65052d 
* Formats settings into tables

* Formatting

* Formatting
# Conflicts:
#	docs/settings/alert-action-settings.asciidoc
#	docs/settings/apm-settings.asciidoc
#	docs/settings/general-infra-logs-ui-settings.asciidoc
#	docs/settings/ml-settings.asciidoc
#	docs/settings/monitoring-settings.asciidoc
#	docs/settings/reporting-settings.asciidoc
#	docs/settings/telemetry-settings.asciidoc
#	docs/setup/settings.asciidoc
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

KOTungseth added a commit that referenced this pull request May 11, 2020
@KOTungseth @elasticmachine
[DOCS] Reformats settings tables (#64844) (#65704)
b6488fc 
* Formats settings into tables

* Formatting

* Formatting
# Conflicts:
#	docs/settings/alert-action-settings.asciidoc
#	docs/settings/apm-settings.asciidoc
#	docs/settings/general-infra-logs-ui-settings.asciidoc
#	docs/settings/ml-settings.asciidoc
#	docs/settings/monitoring-settings.asciidoc
#	docs/settings/reporting-settings.asciidoc
#	docs/settings/security-settings.asciidoc
#	docs/settings/telemetry-settings.asciidoc
#	docs/setup/settings.asciidoc

Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps approved these changes

Assignees

@KOTungseth KOTungseth

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.5.0 v7.6.0 v7.7.0 v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KOTungseth @elasticmachine @gchaps @kibanamachine