[data.search.aggs] Remove legacy aggs APIs. #64719

lukeelmers · 2020-04-28T23:38:01Z

Summary

This is a follow up step to clean up some legacy aggs APIs which were not removed when aggs were moved over to the new platform.

APIs removed here were primarily used by the default vis editor.

In most cases I have simply removed unused items. The main change that took place here was to pull AggTypeFilters and AggTypeFieldFilters out of the data plugin and into vis_default_editor, as the display of the various agg types/fields is more of a UI concern.

Dev Docs

The following legacy aggs APIs from the data plugin's search service have been removed as they are no longer in use:

data.search.__LEGACY.AggConfig;
data.search.__LEGACY.AggType;
data.search.__LEGACY.aggTypeFieldFilters;
data.search.__LEGACY.FieldParamType;
data.search.__LEGACY.MetricAggType;
data.search.__LEGACY.parentPipelineAggHelper;
data.search.__LEGACY.siblingPipelineAggHelper;

Additionally, the following unused static exports have been removed:

AggTypeFieldFilters,
AggTypeFilters,
IAggGroupNames, // renamed to AggGroupName
DateRangeKey,
IpRangeKey,
OptionedParamEditorProps, // moved to vis_default_editor
search.aggs.AggConfigs;
search.aggs.aggGroupNamesMap, // renamed to AggGroupLabels
search.aggs.aggTypeFilters,
search.aggs.convertDateRangeToString,
search.aggs.convertIPRangeToString,

elasticmachine · 2020-04-28T23:38:04Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

src/plugins/data/public/search/aggs/utils/prop_filter.ts

src/plugins/vis_default_editor/public/agg_filters/agg_type_field_filters.ts

src/plugins/vis_default_editor/public/components/agg_group.tsx

src/plugins/vis_default_editor/public/components/agg_param_props.ts

src/plugins/vis_default_editor/public/components/agg_params_helper.test.ts

x-pack/plugins/rollup/public/plugin.ts

lukeelmers · 2020-04-29T00:01:40Z

@elastic/kibana-platform I believe you are only pinged here for a small change to a snapshot test 😄

@elastic/es-ui You were pinged for a couple changes to rollups plugin -- just removing old code.

cjcenizal

Rollup code change LGTM. Haven't tested locally. :)

pgayvallet

LGTM for SOM plugin changes

ppisljar

code LGTM

lukeelmers · 2020-04-29T16:46:19Z

@elasticmachine merge upstream

sulemanof

Thanks @lukeelmers for this clean up, I think this is what we wanted to implement in response to agg types and agg type fields filtering.
Checked in the default editor in variety of visualizations (area, region map, pie) through a basic and rollup index patterns, everything works as expected, didn't notice any exceptions ✅ .
I just left a comment about how we are trying to deal with x-pack code in oss below, so would be great if you could make these changes.

src/plugins/vis_default_editor/public/agg_filters/agg_type_filters.ts

lukeelmers · 2020-04-30T14:36:16Z

@elasticmachine merge upstream

sulemanof

LGTM, didn't test the second time.

lukeelmers · 2020-04-30T21:11:13Z

@elasticmachine merge upstream

kibanamachine · 2020-04-30T23:03:48Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 51339f5

History

💔 Build #44579 failed ad626e9
💔 Build #44527 failed c473699
💚 Build #44457 succeeded fedbaf7
💚 Build #44144 succeeded 6f3bd67
💔 Build #44089 failed a2255f7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Co-authored-by: Elastic Machine <[email protected]>

* upstream/master: (315 commits) [APM] Fix failing `ApmIndices` test (elastic#64965) [APM] Fix paths for ts optimization script (elastic#65012) Use HDR for percentiles (elastic#64758) [EPM] fix updates available filter (elastic#64957) [Uptime] Certificates page (elastic#64059) load lens app lazily (elastic#64769) [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954) Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742) [data.search.aggs] Remove legacy aggs APIs. (elastic#64719) Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927) [Discover] Show doc viewer action buttons on focus (elastic#64912) [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932) [Metrics UI] Add inventory metric threshold alerts (elastic#64292) [Canvas] Adds edit menu (elastic#64738) [Canvas] Adds refresh and autoplay options to view menu (elastic#64375) [Lens] Trigger a filter action on click in datatable visualization (elastic#63840) [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450) [APM] Client new platform migration (elastic#64046) [Monitoring] NP Migration complete client cutover (elastic#62908) Ingest Node Pipelines UI (elastic#62321) ...

…or-part-mvp-2 * 'master' of github.com:elastic/kibana: (51 commits) [APM] Fix failing `ApmIndices` test (elastic#64965) [APM] Fix paths for ts optimization script (elastic#65012) Use HDR for percentiles (elastic#64758) [EPM] fix updates available filter (elastic#64957) [Uptime] Certificates page (elastic#64059) load lens app lazily (elastic#64769) [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954) Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742) [data.search.aggs] Remove legacy aggs APIs. (elastic#64719) Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927) [Discover] Show doc viewer action buttons on focus (elastic#64912) [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932) [Metrics UI] Add inventory metric threshold alerts (elastic#64292) [Canvas] Adds edit menu (elastic#64738) [Canvas] Adds refresh and autoplay options to view menu (elastic#64375) [Lens] Trigger a filter action on click in datatable visualization (elastic#63840) [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450) [APM] Client new platform migration (elastic#64046) [Monitoring] NP Migration complete client cutover (elastic#62908) Ingest Node Pipelines UI (elastic#62321) ... # Conflicts: # x-pack/plugins/ingest_pipelines/common/types.ts # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx # x-pack/plugins/ingest_pipelines/public/shared_imports.ts

* master: (44 commits) onEvent prop for expression component (elastic#64995) [APM] Fix failing `ApmIndices` test (elastic#64965) [APM] Fix paths for ts optimization script (elastic#65012) Use HDR for percentiles (elastic#64758) [EPM] fix updates available filter (elastic#64957) [Uptime] Certificates page (elastic#64059) load lens app lazily (elastic#64769) [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954) Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742) [data.search.aggs] Remove legacy aggs APIs. (elastic#64719) Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927) [Discover] Show doc viewer action buttons on focus (elastic#64912) [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932) [Metrics UI] Add inventory metric threshold alerts (elastic#64292) [Canvas] Adds edit menu (elastic#64738) [Canvas] Adds refresh and autoplay options to view menu (elastic#64375) [Lens] Trigger a filter action on click in datatable visualization (elastic#63840) [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450) [APM] Client new platform migration (elastic#64046) [Monitoring] NP Migration complete client cutover (elastic#62908) ...

lukeelmers added 8 commits April 28, 2020 17:33

Remove unused legacy runtime APIs.

513388b

Remove unused static code and types.

e7bea5c

Rename IAggGroupNames to AggGroupName for clarity.

af3df49

Move OptionedParamEditorProps interface to default editor.

afb0687

Rename aggGroupNamesMap to AggGroupLabels for clarity.

49aa6b0

Move AggTypeFilters and AggTypeFieldFilters to default editor.

df2f858

Remove data plugin as a dependency of rollups.

7cea3f9

Update docs.

01a08a2

lukeelmers added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 Team:AppArch Feature:NP Migration v7.8.0 labels Apr 28, 2020

lukeelmers self-assigned this Apr 28, 2020

lukeelmers changed the title ~~Fix/aggs cleanup~~ [data.search.aggs] Remove legacy aggs APIs. Apr 28, 2020

lukeelmers commented Apr 28, 2020

View reviewed changes

lukeelmers mentioned this pull request Apr 28, 2020

[Meta] Aggregations Roadmap #60126

Closed

82 tasks

lukeelmers requested review from sulemanof, flash1293 and ppisljar April 28, 2020 23:58

lukeelmers marked this pull request as ready for review April 28, 2020 23:59

lukeelmers requested review from a team as code owners April 28, 2020 23:59

cjcenizal approved these changes Apr 29, 2020

View reviewed changes

pgayvallet approved these changes Apr 29, 2020

View reviewed changes

Revert accidental removal of dateHistogramInterval.

a2255f7

ppisljar approved these changes Apr 29, 2020

View reviewed changes

Update docs again.

e52016c

Merge branch 'master' into fix/aggs-cleanup

6f3bd67

sulemanof reviewed Apr 30, 2020

View reviewed changes

src/plugins/vis_default_editor/public/agg_filters/agg_type_filters.ts Outdated Show resolved Hide resolved

elasticmachine and others added 3 commits April 30, 2020 10:36

Merge branch 'master' into fix/aggs-cleanup

fedbaf7

Remove mentions of rollups and use getAggregationRestrictions instead.

406c6a7

Remove unintentionally exported function.

c473699

sulemanof approved these changes Apr 30, 2020

View reviewed changes

Fix failing jest test.

ad626e9

Merge branch 'master' into fix/aggs-cleanup

51339f5

lukeelmers merged commit 7f8f765 into elastic:master May 1, 2020

lukeelmers deleted the fix/aggs-cleanup branch May 1, 2020 01:40

lukeelmers mentioned this pull request May 1, 2020

[7.x] [data.search.aggs] Remove legacy aggs APIs. (#64719) #64987

Merged

lukeelmers added a commit to lukeelmers/kibana that referenced this pull request May 1, 2020

[data.search.aggs] Remove legacy aggs APIs. (elastic#64719)

b643822

lukeelmers added a commit that referenced this pull request May 1, 2020

[data.search.aggs] Remove legacy aggs APIs. (#64719) (#64987)

35ba965

Co-authored-by: Elastic Machine <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[data.search.aggs] Remove legacy aggs APIs. #64719

[data.search.aggs] Remove legacy aggs APIs. #64719

lukeelmers commented Apr 28, 2020 •

edited

Loading

elasticmachine commented Apr 28, 2020

lukeelmers commented Apr 29, 2020

cjcenizal left a comment

pgayvallet left a comment

ppisljar left a comment

lukeelmers commented Apr 29, 2020

sulemanof left a comment

lukeelmers commented Apr 30, 2020

sulemanof left a comment •

edited

Loading

lukeelmers commented Apr 30, 2020

kibanamachine commented Apr 30, 2020

[data.search.aggs] Remove legacy aggs APIs. #64719

[data.search.aggs] Remove legacy aggs APIs. #64719

Conversation

lukeelmers commented Apr 28, 2020 • edited Loading

Summary

Dev Docs

elasticmachine commented Apr 28, 2020

lukeelmers commented Apr 29, 2020

cjcenizal left a comment

Choose a reason for hiding this comment

pgayvallet left a comment

Choose a reason for hiding this comment

ppisljar left a comment

Choose a reason for hiding this comment

lukeelmers commented Apr 29, 2020

sulemanof left a comment

Choose a reason for hiding this comment

lukeelmers commented Apr 30, 2020

sulemanof left a comment • edited Loading

Choose a reason for hiding this comment

lukeelmers commented Apr 30, 2020

kibanamachine commented Apr 30, 2020

💚 Build Succeeded

History

lukeelmers commented Apr 28, 2020 •

edited

Loading

sulemanof left a comment •

edited

Loading