-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve alpha messaging #64692
Improve alpha messaging #64692
Conversation
Pinging @elastic/ingest-management (Feature:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions, mostly i18n key naming, otherwise LGTM
x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_flyout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_flyout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_flyout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_messaging.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/overview/index.tsx
Outdated
Show resolved
Hide resolved
Hey. Small one here. I think we've traditionally used two types of labels for new features. I'd suggest one or the other to keep similar to our other messaging throughout the app. The big different between the two is that experimental features might be removed, where beta features will continue to be developed. Using an @gchaps might be able to help here. |
Thanks @snide @ruflin @mostlyjason So it sounds like we don't use "Alpha" in Kibana when we introduce new products/feature/plugins. Internally we've been calling this "Alpha 1", I think mainly as a way to prevent confusion about our milestones. I don't think it matters to the user whether something is "Alpha" vs "Beta", so long as we provide information that helps set expectations (which this PR does). I'm in favor of just calling this "Beta" so we don't need to update it again for our next milestone. |
…er/components/alpha_flyout.tsx Co-Authored-By: Jen Huang <[email protected]>
…er/components/alpha_flyout.tsx Co-Authored-By: Jen Huang <[email protected]>
…er/components/alpha_flyout.tsx Co-Authored-By: Jen Huang <[email protected]>
…er/sections/overview/index.tsx Co-Authored-By: Jen Huang <[email protected]>
Yes, beta seems correct here. Also, the content in the beta tooltip above is the standard content we use in the UI and docs. |
@elasticmachine merge upstream |
Text looks good. Please add a period (.) at the end of the sentence. |
… into improve-alpha-messaging
I expect for a beta that there is a migration path forward from one beta to an other or even to GA. This is not the case here. I'm good with experimental instead of alpha. For me the difference is an experimental feature might go away, and alpha feature doesn't, it is just not as stable yet as a beta feature. |
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* use fixed table layout * add alpha messaging flyout * Added alpha badge + data streams link * Update x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_flyout.tsx Co-Authored-By: Jen Huang <[email protected]> * Update x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_flyout.tsx Co-Authored-By: Jen Huang <[email protected]> * Update x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_flyout.tsx Co-Authored-By: Jen Huang <[email protected]> * Update x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/overview/index.tsx Co-Authored-By: Jen Huang <[email protected]> * remove small tags * change messaging from alpha to experimental * add period * remove unused imports * fixed i18n ids Co-authored-by: Jen Huang <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
* master: (42 commits) [Ingest] Allow aggent to send metadata compliant with ECS (elastic#64452) [Endpoint] Remove todos, urls to issues (elastic#64833) [Uptime] Remove hard coded value for monitor states histograms (elastic#64396) Feature/send feedback link (elastic#64845) [ML] Moving get filters capability to admin (elastic#64879) Remove edit alert button from alerts list (elastic#64643) [EPM] Handle constant_keyword type in KB index patterns and ES index templates (elastic#64876) [ML] Disable data frame anaylics clone button based on permission (elastic#64830) Dashboard url generator to preserve saved filters from destination dashboard (elastic#64767) add generic typings for SavedObjectMigrationFn (elastic#63943) Allow to define and update a defaultPath for applications (elastic#64498) [Event Log] add rel=primary to saved objects for query targets (elastic#64615) [Lens] Use a size of 5 for first string field in visualization (elastic#64726) [SIEM][Lists] Removes plugin dependencies, adds more unit tests, fixes more TypeScript types [Ingest] Edit datasource UI (elastic#64727) [Lens] Bind all time fields to the time picker (elastic#63874) [Lens] Use suggestion system in chart switcher for subtypes (elastic#64613) Improve alpha messaging (elastic#64692) [Ingest] Allow to enable monitoring of elastic agent (elastic#63598) [Metrics UI] Fix alerting when a filter query is present (elastic#64575) ...
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
…bana into pipeline-editor-part-mvp-2 * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (90 commits) remove unused import address review feedback [Ingest pipelines] Cleanup (elastic#64794) [Ingest] Edit datasource UI (elastic#64727) [Lens] Bind all time fields to the time picker (elastic#63874) [Lens] Use suggestion system in chart switcher for subtypes (elastic#64613) Improve alpha messaging (elastic#64692) [Ingest] Allow to enable monitoring of elastic agent (elastic#63598) [Metrics UI] Fix alerting when a filter query is present (elastic#64575) skip flaky suite (elastic#64812) (elastic#64723) [Maps] do not display EMS or kibana layer wizards when not configured (elastic#64554) [Reporting/Test] Convert functional test code to Typescript (elastic#64601) make inserting timestamp with navigate methods optional with default true (elastic#64655) [EPM] Update UI to handle package versions and updates (elastic#64689) Minimize dependencies required by our telemetry middleware (elastic#64665) [Telemetry] oss api tests (elastic#64602) [ML] Adding endpoint capability checks (elastic#64662) Update jest config for coverage (elastic#64648) [SIEM][NP] Fixes bug in ML signals promotion (elastic#64720) share single data plugin bundle (elastic#64549) ...
Closes #64239
This PR adds an alpha badge to overview page. It also includes a link in the footer to view more details about the alpha release inside a flyout. This flyout includes links to documentation and a discuss forum. I used our url shortener service to generate a short url which we can update outside of the codebase later.