Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Edits create anomaly job intro text #64607

Merged
merged 8 commits into from
May 5, 2020
Merged

[ML] Edits create anomaly job intro text #64607

merged 8 commits into from
May 5, 2020

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 27, 2020 •
edited
Loading

Summary

This PR edits the text in the following panel:

image

  • Change “supplied configuration” to “Use pre-configured job” or “Use a recommended configuration”?
  • Change “The fields in your data have been recognized…” to “The fields in your data match known configurations. Create a set of xxx (recommended or preconfigured) jobs and dashboards”.
  • Add period at end of “Find anomalies in Kibana sample web logs data”.
  • Remove “Use one of the wizards…”
  • Add hyphen in “Multi-metric”?
  • Fix sentence in Multi metric description (“Detect anomalies in multiple metrics….) so that it’s clearer that it can be one or multiple metrics with an optional split field.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@lcawl lcawl added WIP Work in progress :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 v7.8.0 labels Apr 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@lcawl lcawl marked this pull request as ready for review April 30, 2020 18:57
@lcawl lcawl requested a review from a team as a code owner April 30, 2020 18:57
@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes and removed WIP Work in progress labels Apr 30, 2020
@peteharverson peteharverson self-requested a review May 4, 2020 11:25
@lcawl
Copy link
Contributor Author

lcawl commented May 4, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented May 4, 2020

@elasticmachine merge upstream

@peteharverson peteharverson changed the title Edits create anomaly job intro text [ML] Edits create anomaly job intro text May 5, 2020
peteharverson
peteharverson reviewed May 5, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest edits LGTM, but would you be able to add in a change to the 'Create job' breadcrumb as noted above?

x-pack/plugins/ml/public/application/routing/routes/new_job/wizard.tsx
@@ -45,7 +45,7 @@ const multiMetricBreadcrumbs = [
...baseBreadcrumbs,
{
text: i18n.translate('xpack.ml.jobsBreadcrumbs.multiMetricLabel', {
defaultMessage: 'Multi metric',
defaultMessage: 'Multi-metric',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing how this breadcrumb looks, I noticed that a recent PR #64667 changed one of the breadcrumbs for the 'Create job' stage to 'Create jobs' (plural). I think this should always be singular 'Create job'. All of the wizards other than the data recognizer one only create one job, and I don't think the text of the breadcrumb should change for the one use case of using the data recognizer wizard for a module which has multiple jobs. Would you be able to add that edit to this PR please - x-pack/plugins/ml/public/application/routing/breadcrumbs.ts CREATE_JOB_BREADCRUMB.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I've added that change.

@lcawl
Copy link
Contributor Author

lcawl commented May 5, 2020

@elasticmachine merge upstream

peteharverson
peteharverson approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest edit and LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 415d33b into elastic:master May 5, 2020
@lcawl lcawl deleted the ml-create-job branch May 5, 2020 18:38
@lcawl lcawl mentioned this pull request May 5, 2020
Merged
lcawl added a commit to lcawl/kibana that referenced this pull request May 5, 2020
@lcawl @elasticmachine
[ML] Edits create anomaly job intro text (elastic#64607)
6e60632 
* Edits create anomaly job intro text

* [DOCS] More edits

* [DOCS] Removes obsolete translations

* [DOCS] Addresses feedback

* [DOCS] Update create job breadcrumb

Co-authored-by: Elastic Machine <[email protected]>
lcawl added a commit that referenced this pull request May 5, 2020
@lcawl
[ML] Edits create anomaly job intro text (#64607) (#65340)
3086157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcawl @elasticmachine @spalger @kibanamachine @peteharverson