Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CCR client integration test that asserts that the UI consumes the expected API when editing a follower index #64440

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

cjcenizal
Copy link
Contributor

This PR adds the client integration test suggested in cjcenizal#24 as a followup to #63653.

@cjcenizal cjcenizal added chore Feature:CCR and Remote Clusters v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 24, 2020
@cjcenizal cjcenizal requested a review from sebelga April 24, 2020 16:09
@cjcenizal cjcenizal requested a review from a team as a code owner April 24, 2020 16:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

… expected API when editing a follower index.
@cjcenizal cjcenizal force-pushed the chore/test-edit-follower-index branch from 4dd0020 to 4604be9 Compare April 24, 2020 16:13
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjcenizal
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cjcenizal cjcenizal merged commit 84aef39 into elastic:master Apr 27, 2020
@cjcenizal cjcenizal deleted the chore/test-edit-follower-index branch April 27, 2020 19:20
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Apr 27, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added backport missing Added to PRs automatically when the are determined to be missing a backport. and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Apr 29, 2020
cjcenizal added a commit that referenced this pull request Apr 30, 2020
… expected API when editing a follower index (#64440) (#64559)

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:CCR and Remote Clusters release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants