[ML] Add kibana setting for file data visualizer max file size #64427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
release_note:enhancement
review
:ml
v8.0.0
Feature:File and Index Data Viz
jgowdyelastic
requested review from
walterra,
alvarezmelissa87 and
peteharverson
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Apr 24, 2020
There was a problem hiding this comment.
Tested and LGTM. Just one typo to correct I think.
Is this edit to the docs still valid now that the setting has been moved into the advanced settings page? #64006
|
retest |
|
@elasticmachine merge upstream |
lcawl
reviewed
Apr 24, 2020
| coreSetup.uiSettings.register({ | ||
| [FILE_DATA_VISUALIZER_MAX_FILE_SIZE]: { | ||
| name: i18n.translate('xpack.ml.maxFileSizeSettingsName', { | ||
| defaultMessage: 'File Data Visualizer maximum file upload size', |
There was a problem hiding this comment.
In the docs we don't differentiate between the "Data Visualizer" and the "File Data Visualizer" (I think it's because they're both on the same "Data Visualizer" tab). IMO it's not necessary to have the "File" qualifier here either:
Suggested change
| defaultMessage: 'File Data Visualizer maximum file upload size', | |
| defaultMessage: 'Data Visualizer maximum file upload size', |
lcawl
reviewed
Apr 24, 2020
| value: MAX_FILE_SIZE, | ||
| description: i18n.translate('xpack.ml.maxFileSizeSettingsDescription', { | ||
| defaultMessage: | ||
| 'Sets the file size limit when importing data in the File Data Visualizer. The highest supported value for this setting is 1GB.', |
There was a problem hiding this comment.
Ditto re "File Data Visualizer":
Suggested change
| 'Sets the file size limit when importing data in the File Data Visualizer. The highest supported value for this setting is 1GB.', | |
| 'Sets the file size limit when importing data in the Data Visualizer. The highest supported value for this setting is 1GB.', |
lcawl
reviewed
Apr 24, 2020
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| export const FILE_DATA_VISUALIZER_MAX_FILE_SIZE = 'ml:fileDataVisualizerMaxFileSize'; |
There was a problem hiding this comment.
Not mandatory, but if you follow my other suggestions, it might be a good idea to synch here too:
Suggested change
| export const FILE_DATA_VISUALIZER_MAX_FILE_SIZE = 'ml:fileDataVisualizerMaxFileSize'; | |
| export const FILE_DATA_VISUALIZER_MAX_FILE_SIZE = 'ml:DataVisualizerMaxFileSize'; |
lcawl
reviewed
Apr 24, 2020
|
|
||
| [horizontal] | ||
| `ml:fileDataVisualizerMaxFileSize`:: Sets the file size limit when importing |
There was a problem hiding this comment.
If you accept my suggestion about changing the setting name, it will need to be updated here too:
Suggested change
| `ml:fileDataVisualizerMaxFileSize`:: Sets the file size limit when importing | |
| `ml:DataVisualizerMaxFileSize`:: Sets the file size limit when importing |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Apr 28, 2020
…ic#64427) * [ML] Add kibana setting for file data visualizers max file size * adding failsafe for setting * fixing id * [DOCS] Updates Data Visualizer setting Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: lcawl <[email protected]>
jgowdyelastic
added a commit
that referenced
this pull request
Apr 28, 2020
… (#64624) * [ML] Add kibana setting for file data visualizers max file size * adding failsafe for setting * fixing id * [DOCS] Updates Data Visualizer setting Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: lcawl <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: lcawl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuring the max file upload size is now done via a setting in the Advanced Settings page of kibana's management app.
Reverts some of the changes made in #62752
Basic validation looks for a data string using a regex. max and min testing is not possible.