-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Node Pipelines] Show flyout after editing or creating a pipeline #64409
Merged
jloleysens
merged 7 commits into
elastic:feature/ingest-node-pipelines
from
jloleysens:ingest-node-pipeline/open-flyout-create-edit
Apr 28, 2020
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0c8917c
Show flyout after editing or creating a pipeline
jloleysens a2c86df
JSX comment
jloleysens 42247e2
Merge branch 'feature/ingest-node-pipelines' of github.com:elastic/ki…
jloleysens 867b074
Show not found flyout
jloleysens 0f83eaf
update not found flyout and fix behavior when viewing details from table
alisonelizabeth e6b8489
Reset pipeline name in URI when closing flyout
jloleysens 3cd5d76
Remove encodeURI
jloleysens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
.../plugins/ingest_pipelines/public/application/sections/pipelines_list/not_found_flyout.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
import React, { FunctionComponent } from 'react'; | ||
import { FormattedMessage } from '@kbn/i18n/react'; | ||
import { EuiFlyout, EuiFlyoutBody, EuiCallOut } from '@elastic/eui'; | ||
import { EuiFlyoutHeader, EuiTitle } from '@elastic/eui'; | ||
|
||
interface Props { | ||
onClose: () => void; | ||
pipelineName: string | string[] | null | undefined; | ||
} | ||
|
||
export const PipelineNotFoundFlyout: FunctionComponent<Props> = ({ onClose, pipelineName }) => { | ||
return ( | ||
<EuiFlyout onClose={onClose} size="m" maxWidth={550}> | ||
<EuiFlyoutHeader> | ||
{pipelineName && ( | ||
<EuiTitle id="notFoundFlyoutTitle"> | ||
<h2>{pipelineName}</h2> | ||
</EuiTitle> | ||
)} | ||
</EuiFlyoutHeader> | ||
|
||
<EuiFlyoutBody> | ||
<EuiCallOut | ||
title={ | ||
<FormattedMessage | ||
id="xpack.ingestPipelines.list.notFoundFlyoutMessage" | ||
defaultMessage="Pipeline not found" | ||
/> | ||
} | ||
color="danger" | ||
iconType="alert" | ||
/> | ||
</EuiFlyoutBody> | ||
</EuiFlyout> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that you added
encodeURI
to the above calls to history.push so I added here too, however I am not sure that they're necessary (if i'm not mistaken). the base path should hopefully be URI safe, as a nit I would say we can remove them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good point. I think the base path should be safe as well.