[Ingest] Make all saved objects namespace agnostic, move to NP plugin #64360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
v8.0.0
release_note:skip
|
Pinging @elastic/ingest-management (Feature:EPM) |
jfsiii
reviewed
Apr 23, 2020
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| export function registerSavedObjects(savedObjects: SavedObjectsServiceSetup) { | ||
| Object.entries(savedObjectTypes).forEach(([, type]) => { |
There was a problem hiding this comment.
If we don't care about the key, Object.values is also an option.
jfsiii
approved these changes
Apr 23, 2020
|
@jfsiii Thanks for testing! |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Apr 24, 2020
…elastic#64360) * Move saved object type registration & mapping to NP plugin; normalize and prefix saved object type names * Replace hardcoded saved object type names with constants * Adjust output type name * Review and import fixes * Update tests, fixtures, and instructions
jen-huang
added a commit
that referenced
this pull request
Apr 27, 2020
…#64360) (#64465) * Move saved object type registration & mapping to NP plugin; normalize and prefix saved object type names * Replace hardcoded saved object type names with constants * Adjust output type name * Review and import fixes * Update tests, fixtures, and instructions Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note: To test this PR, you will need to clear your ES data and do
yarn kbn bootstrap.1) Commit b6b658e
.kibanaindex which has a large number of other types registered to it.datasourcesandagentsas names for example can be ambiguous and may conflict in the future with other apps.2) Commit 0a8d0d3