Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM][Detections] Disable mappings for rule_actions params #64350

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

rylnd
Copy link
Contributor

@rylnd rylnd commented Apr 23, 2020

Summary

Addresses #64097 for 7.x. The errant mapping is going out with 7.7, so we'll need to backport this to 7.7.1 once 7.7 goes out. Because this one relies on #64029 the 7.7.1 backport will probably just end up being a separate branch.

We ended up not needing a migration because there are no data changes necessary; this just prevents params from creating mappings that we don't want/need.

For maintainers

These are most analagous to alerting params, which use the same terminal
mapping.
@rylnd rylnd added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 23, 2020
@rylnd rylnd requested review from spong and patrykkopycinski April 23, 2020 19:48
@rylnd rylnd self-assigned this Apr 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@rylnd rylnd marked this pull request as ready for review April 23, 2020 21:52
@rylnd rylnd requested a review from a team as a code owner April 23, 2020 21:52
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks for cleaning this one up @rylnd 🙂

@rylnd
Copy link
Contributor Author

rylnd commented Apr 27, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd merged commit 9e8809b into elastic:master Apr 27, 2020
@rylnd rylnd deleted the rule_actions_mapping branch April 27, 2020 19:14
rylnd added a commit to rylnd/kibana that referenced this pull request Apr 27, 2020
These are most analagous to alerting params, which use the same terminal
mapping.

Co-authored-by: Elastic Machine <[email protected]>
rylnd added a commit that referenced this pull request Apr 27, 2020
These are most analagous to alerting params, which use the same terminal
mapping.

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants