Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Global search API #64284

Merged
merged 21 commits into from
May 18, 2020
Merged

[RFC] Global search API #64284

Changes from 6 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
86d6ce4
initial file import
pgayvallet Apr 23, 2020
2aa6e80
update types
pgayvallet Apr 23, 2020
6bdc15f
update RFC PR number
pgayvallet Apr 23, 2020
b3a31fa
first draft complete
pgayvallet Apr 23, 2020
6971597
draft v1.1.0
pgayvallet Apr 24, 2020
2e1c006
initial self review
pgayvallet Apr 24, 2020
cc473fe
nits and comments
pgayvallet Apr 29, 2020
cbdc44c
add 'preference' option
pgayvallet Apr 30, 2020
5d6e4cb
change meta type to Record<string, Serializable>
pgayvallet Apr 30, 2020
3a094aa
specify cancellation
pgayvallet Apr 30, 2020
5d750e0
remove generic for GlobalSearchResponse, use distinct type on client …
pgayvallet Apr 30, 2020
24b1ec3
use plain string instead of enum for GlobalSearchResult.type
pgayvallet Apr 30, 2020
15ece40
remove terminology from unresolved questions
pgayvallet Apr 30, 2020
0987e0d
update pros/cons of core vs plugin
pgayvallet Apr 30, 2020
8180c3a
GS is exposed from a plugin instead of core
pgayvallet May 8, 2020
aed714f
remove the server.publicAddress proposal, return mixed abs url / rel …
pgayvallet May 8, 2020
9bf9231
distinguish result type between GS api and result providers
pgayvallet May 8, 2020
d2289f7
return batched results, no longer sort
pgayvallet May 8, 2020
66d6db9
remove request from GlobalSearchProviderContext
pgayvallet May 8, 2020
3de606a
add maxResults to GlobalSearchProviderFindOptions
pgayvallet May 8, 2020
fc6bf13
nit/typo
pgayvallet May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading