-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Endpoint] Show Policy Status on Host Details using Policy Response API #64116
[Endpoint] Show Policy Status on Host Details using Policy Response API #64116
Conversation
Pinging @elastic/endpoint-management (Team:Endpoint Management) |
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
@paul-tavares - I proposed test cases in Issue 163: https://github.com/elastic/endpoint-app-team/issues/163. These 3 apply to this PR:
|
…etails-policy-status # Conflicts: # x-pack/plugins/endpoint/public/applications/endpoint/view/hosts/details/host_details.tsx
Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in terms of the test cases we talked about 👍
id="xpack.endpoint.host.details.policyStatus.success" | ||
defaultMessage="Successful" | ||
id="xpack.endpoint.host.details.policyStatusValue" | ||
defaultMessage="{policyStatus, select, success {Success} warning {Warning} failure {Failed} other {Unknown}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wew
…etails-policy-status # Conflicts: # x-pack/plugins/endpoint/public/applications/endpoint/store/hosts/action.ts # x-pack/plugins/endpoint/public/applications/endpoint/store/hosts/middleware.ts # x-pack/plugins/endpoint/public/applications/endpoint/store/hosts/reducer.ts # x-pack/plugins/endpoint/public/applications/endpoint/types.ts # x-pack/plugins/endpoint/public/applications/endpoint/view/hosts/details/host_details.tsx
…etails-policy-status
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
…PI (elastic#64116) * Add policyStatus to store + drive UI color/label from status value * Add Middleware placeholder to handle API call (once available)
…bana into pipeline-editor-part-mvp-2 * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (152 commits) [Ingest pipelines] Simulate pipeline (elastic#64223) Ability to get scoped call cluster from alerting and action executors (elastic#64432) Add editApp and editPath to embeddable (elastic#64297) TSVB validation: Allow numeric values for axes (elastic#63553) [ML] Fixing optional plugin dependency types (elastic#64450) [Logs UI] Alerting (elastic#62806) [Endpoint] Show Policy Status on Host Details using Policy Response API (elastic#64116) [Maps] update LayerWizard previewLayer to take layerDescriptor instead of ISource (elastic#64461) Remove SO root property index signature (elastic#64434) [ML] Functional tests - stabilize job row details validations (elastic#64503) [Ingest] Add Global settings flyout (elastic#64276) Bump cypress dev-dependency from 4.2.0 to 4.4.1 (elastic#64408) Migrate saved object of type url to kibana platform (elastic#64043) [NP] Migrate ui capabilities (elastic#64185) Bump karma-mocha dev-dependency from 1.3.0 to 2.0.0 (elastic#64407) Migrate kql_telemetry saved object registration to Kibana platform (elastic#64149) Remove SO autocreateindex error and error page (elastic#64037) Fix issue with yarn.lock (elastic#64496) Bump @hapi/boom dependency from 7.4.2 to 7.4.11 (elastic#64433) Bump gonzales-pe dev-dependency from 4.2.4 to 4.3.0 (elastic#64401) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx # x-pack/plugins/ingest_pipelines/public/shared_imports.ts
Summary
Drive the Policy Status value displayed on the Host Details panel using the Policy response API (not yet implemented).
Checklist
Delete any items that are not applicable to this PR.