-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update string field mappings to text/keyword #6411
Conversation
@@ -46,16 +46,16 @@ module.factory('SavedDashboard', function (courier, config) { | |||
|
|||
// if type:dashboard has no mapping, we push this mapping into ES | |||
SavedDashboard.mapping = { | |||
title: 'string', | |||
title: 'text', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note these mapping changes are going to break for anyone upgrading from an existing Kibana 4.x installation in which they have not saved at least one of each type of saved object. Eg, if they've saved visualizations and dashboards but never saved a search, saving a search will fail.
Tests are passing, so this is available if it's decided that we should move everything from string to text/keyword. |
Marking this as blocked until we sort out the gameplan here. |
For now Elasticsearch has put support for |
How should we proceed with this PR, then? |
We need to hold on this PR until we get the reindex stuff in |
07baa1a
to
552cd41
Compare
This can't go in until we build in a capability to reindex and version the kibana index, so I'm going to close it for now. We can continue to track the issue here #6404 |
I don't think we should conflate the two. #6404 is a blocker for this, but it should be done without also introducing all the string/keyword changes. |
Whoops, I meant to do this to the corresponding issue, my bad. |
Fixes #6409
This is a WIP to update all of the
string
field mappings in Kibana to eithertext
orkeyword
, whichever is most appropriate for each field. In cases where I have some doubt about whethertext
orkeyword
is most appropriate I'm leaning towardstext
since it's matches the basicstring
definition we were previously using.I've got things fixed up to a point where I can start up and use Kibana without getting any errors. Now I'm working on updating the functional tests and functional test fixtures, but I'm currently blocked by this bug: elastic/elasticsearch#16945