Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM][CASE] Server common constants #63952

Merged
merged 1 commit into from
Apr 21, 2020
Merged

[SIEM][CASE] Server common constants #63952

merged 1 commit into from
Apr 21, 2020

Conversation

cnasikas
Copy link
Member

Summary

Create cases server common constants.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 20, 2020
@cnasikas cnasikas requested a review from XavierM April 20, 2020 11:15
@cnasikas cnasikas requested a review from a team as a code owner April 20, 2020 11:15
@cnasikas cnasikas self-assigned this Apr 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@cnasikas cnasikas mentioned this pull request Apr 20, 2020
Merged
2 tasks
stephmilovic
stephmilovic approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review and passed manual testing locally via browser and sh scripts. just a few nits on naming, other than that LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💚 Build #41822 succeeded edbfad422fc6b41a3ed554ad6a7bf65a65d14213

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cnasikas cnasikas merged commit 6987171 into elastic:master Apr 21, 2020
@cnasikas cnasikas deleted the case_constants branch April 21, 2020 12:09
@cnasikas cnasikas mentioned this pull request Apr 21, 2020
Merged
cnasikas added a commit to cnasikas/kibana that referenced this pull request Apr 21, 2020
@cnasikas
[SIEM][CASE] Server common constants (elastic#63952)
ef962bb
cnasikas added a commit that referenced this pull request Apr 21, 2020
@cnasikas
[7.x] [SIEM][CASE] Server common constants (#63952) (#64062)
af3ba98
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

@XavierM XavierM Awaiting requested review from XavierM

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski

@angorayc angorayc Awaiting requested review from angorayc

@andrew-goldstein andrew-goldstein Awaiting requested review from andrew-goldstein

Assignees

@cnasikas cnasikas

Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cnasikas @elasticmachine @kibanamachine @stephmilovic @MindyRS